From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D00C33858412 for ; Tue, 14 Nov 2023 15:20:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D00C33858412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D00C33858412 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699975246; cv=none; b=n3X09lB9G0WSTcaEBI8Lturhl8jPRHSEPNCWkpMm1AU/kDnVlwwFK3c36lvj6jL4Yli/jLgBO2Dg79JguDBFd8BEuX4BKsE8/zXeA+XegWpnWotyZ7JFBIPHDfQIlQQamCSeABgMV3cVGwQ8jn3URN64Jyyoh/viIUJK/cMK6d8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699975246; c=relaxed/simple; bh=3EccRIVrwWABKGboIJasLhh4A7MujnzuFbI6Vzc572Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Ytjg0W9jpkjSnewqfXaZRPSk0xsHkLS9Gn7qZgT0a6EjKRHHJi6m6JfQ3aN8/xOu1PMd0l2m8q61rakowWtWl69fGpUNV8K4NfsU+usrw7DBpY5JUYQCjNgQZzY6JHU8/SqLcy0+cngURaDz7kWOnvOAoCPiUQd/KvcokE/pJBU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 3AEFKYjQ029985 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Nov 2023 10:20:38 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 3AEFKYjQ029985 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1699975239; bh=zkXxivF2TWDrgRrbhF8NeWffsFF5Nzw58Oluo+6hIHw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P9V5RiaxYE6q6IviPacgqXOqdsxgZIc6YzJowZlumyxcnayWTv+3c7/piKVNP8qSW KP2aBpSP618YxmDV8fKU6vRM/F1+mWjXSaUaLKblbwHawBJCgtVE2mDhv0GgE6pO78 dU7urYS5nL9hHeeXXX9XBOUu82gxwat8GjrP4dPU= Received: from [172.25.82.120] (unknown [12.186.190.2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BCA5C1E091; Tue, 14 Nov 2023 10:20:33 -0500 (EST) Message-ID: <7e5a631d-0928-4f1e-b888-205a37289980@polymtl.ca> Date: Tue, 14 Nov 2023 10:20:33 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] gdb: add gdbarch_pseudo_register_write that takes a frame Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20231108051222.1275306-1-simon.marchi@polymtl.ca> <20231108051222.1275306-18-simon.marchi@polymtl.ca> <87o7fwr0fw.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87o7fwr0fw.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 14 Nov 2023 15:20:34 +0000 X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/23 07:20, Andrew Burgess wrote: >> @@ -4080,6 +4096,27 @@ pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num, >> return pseudo_reg_val; >> } >> >> +void >> +pseudo_to_concat_raw (frame_info_ptr next_frame, >> + gdb::array_view pseudo_buf, >> + int raw_reg_1_num, int raw_reg_2_num) > > This function, and its overload are missing a /* See value.h. */ comment. Thanks, fixed. >> @@ -1670,10 +1677,25 @@ value *pseudo_from_raw_part (frame_info_ptr next_frame, int pseudo_reg_num, >> value *pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num, >> int raw_reg_1_num, int raw_reg_2_num); >> >> +/* Write PSEUDO_BUF, the contents of a pseudo register, to the two raw registers >> + RAW_REG_1_NUM and RAW_REG_2_NUM. */ >> + >> +void pseudo_to_concat_raw (frame_info_ptr this_frame, >> + gdb::array_view pseudo_buf, >> + int raw_reg_1_num, int raw_reg_2_num); >> + >> /* Same as the above, but with three raw registers. */ >> >> value *pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num, >> int raw_reg_1_num, int raw_reg_2_num, >> int raw_reg_3_num); >> >> +/* Write PSEUDO_BUF, the contents of a pseudo register, to the tthreewo raw >> + registers RAW_REG_1_NUM, RAW_REG_2_NUM and RAW_REG_3_NUM. */ > > typo s/tthreewo/three/. Fixed, thanks, Simon