From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2042.outbound.protection.outlook.com [40.107.104.42]) by sourceware.org (Postfix) with ESMTPS id 547FF383691A for ; Tue, 31 Jan 2023 14:45:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 547FF383691A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qrvf1FP5on6lX10+i3HJvxCGuzaAYFBrE9BuMImtOTc=; b=xnpQ4S1KzGKTdEpoVdd+n3mcAmG8Tmkyu67/dy7PiT0S5zy3/HeTO8Myt5oUFZAaad0Qax6F723jplAmqItwG7t8PPxOseFJ1EWig0t3sqtcOtOTI0VDgKl124hHbi64PCGwIx+BfzsLAb2jv73K4WKn5PspluySJwL3ScKALDg= Received: from DB8PR06CA0005.eurprd06.prod.outlook.com (2603:10a6:10:100::18) by PAVPR08MB9084.eurprd08.prod.outlook.com (2603:10a6:102:32d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Tue, 31 Jan 2023 14:33:40 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::3e) by DB8PR06CA0005.outlook.office365.com (2603:10a6:10:100::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Tue, 31 Jan 2023 14:33:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Tue, 31 Jan 2023 14:33:40 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Tue, 31 Jan 2023 14:33:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0278e3bd64ed5ccb X-CR-MTA-TID: 64aa7808 Received: from 397cebb6890d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6871063E-1750-4339-A7F7-845C640AAA92.1; Tue, 31 Jan 2023 14:33:33 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 397cebb6890d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 Jan 2023 14:33:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J3NP7axs2LevDgp4QFA8mhnA6/zL5GXCvPco4RA/9qVycuRsYUA28NJvjx6U8FP/aLQ3H5lUa9Rzrt7Tl7iccU3b0xYwLpi03pU88vMMydfqQTPhOz5b3kapKQE/dsnaMOcId+a762PeFLk/W/POdyySVVH66xKu8bIYHOY80WkhCodQbePQ/KWHFBaCfSyzbCMjjYCamSNKagGcxL/2WFJzBKSh3s2SfiaNvCbex11gpf7fJS5VSvCxu/TA6znOqp4v3CDL8Klein7nqjUZX6utJnR0mD6uoSkJYqwFOT8YhUlgoAvkeQdzF1as0NgMexpqAfJ1K0betK1BOTFofw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qrvf1FP5on6lX10+i3HJvxCGuzaAYFBrE9BuMImtOTc=; b=ehHWfjPSISforxxKa9JPB2sSQEF81x2tno3mZeLrKh+/cmfBvo27PIBXygs7DtTCUXoby5+k46F1SS6BQtKcJddbBoXjuyOVeWeDcAcBl4pjD6ksLeljifQnsUof5WA3lK1NT9eDqkE/2x9sTsNLzxEsn3WeIgFNjXR1Ogh/VI1B2feEfBSdMiGN/gJLUH7P1oFC70gve7J+Y4Tz7sVfJEyKjMtDWwGtrKdrZqEbbyGrAg9GJSvsIVTpCb0cvkcP2mCwQlYLDJGt/hKRoXGLkd37aVbKSV8or1h/pm27YEqLPzUZb/z0MKl9BapLTtPsXEkfq2TIzhTPOX/NdXL0KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qrvf1FP5on6lX10+i3HJvxCGuzaAYFBrE9BuMImtOTc=; b=xnpQ4S1KzGKTdEpoVdd+n3mcAmG8Tmkyu67/dy7PiT0S5zy3/HeTO8Myt5oUFZAaad0Qax6F723jplAmqItwG7t8PPxOseFJ1EWig0t3sqtcOtOTI0VDgKl124hHbi64PCGwIx+BfzsLAb2jv73K4WKn5PspluySJwL3ScKALDg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS4PR08MB7733.eurprd08.prod.outlook.com (2603:10a6:20b:510::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 14:33:31 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6%3]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 14:33:30 +0000 Message-ID: <7e60e8ec-9ee4-424a-c594-8093a9f9a992@arm.com> Date: Tue, 31 Jan 2023 14:33:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: GDB 13 release -- 2023-01-21 Update Content-Language: en-US From: Luis Machado To: Joel Brobecker Cc: Simon Marchi , Torbjorn SVENSSON , tom@tromey.com, gdb-patches@sourceware.org References: <95dc547e-59f8-95b3-903c-138d8842cea0@foss.st.com> <47dff98e-b714-2d72-bc3b-c14c4e0313d0@arm.com> <1689df81-6ab3-c167-24a4-415a86216b5a@arm.com> <16313f2c-90a1-4fa7-2af3-ef420cad18f6@arm.com> In-Reply-To: <16313f2c-90a1-4fa7-2af3-ef420cad18f6@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0165.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::8) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS4PR08MB7733:EE_|DBAEUR03FT042:EE_|PAVPR08MB9084:EE_ X-MS-Office365-Filtering-Correlation-Id: 6712ece8-e429-4c4c-facd-08db03982597 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KHyPrs5cqAgnwTE4h16WTB0pK/4n7LTtG1XnTIAxV0YbgvGwZ6VOHg1vD4SzW6rUGt6boE2CwBvB26ECNoHP5LcFue6SrRx/mF8riP3Kx8uMDpyRP/Id/Y5gmr8u8ex12pmILZpd4Rwvr6pjDFR/r1WehLkvzoH2RoEJ4IHT7HBaXpyoBoZrfPvL15LiiBhtQljbF+v+NlbkhAI30vIfwBM8d2CquqULbeRChWwc/dV1LxMlwIBy3wROcTAVq1exnP1dKLO5hsS0izvDQIqYmUdtr/hi79US2cgLj+qudS7MmRVXmtwdEqpOxnBOoaLVOscNPjmP0+v7MJ4ZN3nWMdeL8Tg2OYdCSBQxatjFhcioG7JOOTq+v7y1eJSFlIhCL7vzvz/pjvusBF9GBknirSfAtXK2JANxIQ1cRtNMTmAT+RbbVjW67pBXnO3iZ/V6Y6puspdeFOuJDNWLcny4sUAxlAJQZ0z4WnZl6aBp3hOih2RgaAlRQ1vC7+DjHo7uFkRn7zuw8ALy6kooE6176zzLqLhCMXNk6ECflQXOybsFXo42fEBtV1KTjWwbAL74EqSlKbCLYMCu8CI7ACt0eswpWrykNzjk4Xb+Je4F9I/zogGqd1HeifOLMaZyS0/AR3UJEab7xud+S4CDGcYdkVcnlf6TGLlqp/0UpHb7X7Qte16Obv5wSorf30w2FBPJ/p3FkMzdcgzD7aXGQyOHZzfrZTxgO4WRfh/V7DxuPd8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199018)(83380400001)(44832011)(38100700002)(36756003)(54906003)(41300700001)(6486002)(31696002)(86362001)(316002)(8936002)(478600001)(5660300002)(2906002)(6666004)(186003)(6512007)(6506007)(53546011)(26005)(31686004)(66946007)(4326008)(6916009)(8676002)(2616005)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7733 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 688c5e8d-e4f0-46b2-54ec-08db03981f87 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D/afF/QDx6p8EZoFzkiKBiS5f9RufYRruZJXZ/LJ0V9R3tIz+nFrHpYJBXgQXB/oGfiytT6aJvPvY1wmC7QpHMuTD7rzlKE37bdMksnZyB+Rl5ZizhAqx4yKKS7xkSqIhZlYcQpol6P7R3/FHMTQY/CrLjgjPc9qamrtrIOvWTtHPsgeowgYSevq5INrt6A9qr/llqOkDMr+D9vFk5NUCQNZUEW7Tz+fchIQF4/JrlMSfxAnrOBHnOihsi0d0KshR/e7ySO3gdP45PV9VwkZbQWp9m9ED+ud2mXP2UxAP7xH+61lGO50+owXwBhxANp4Us1VRbSSMms9lSynYKHCHZXztn9/dCcio0Ld/vkiHdGJflc2khVQWU2hsFICmUGQTnTdxdA/SJltEFZRBewgw6N4vlPw8qTlg4p6v0lJUMe0xbZvquyA2+bLcJCLaQejeNBfr2niIL2ZRlirZw1190wWKIHaIxyk+GcwuAKVanfYU9NHttEvgifELzuXxsmzrjsO3Xtb/Zr+6p9k64od7K9PW0omuAkS8Y/gLfDGYRA7VvvmFSw2ll4BaH1DKXhMAebtVZl3eEB7mgmtM0Maz5JBjmAnCrbPfSxvhdXLbwvXFh15tVJvMO8m7oJbsMVAg2a3KdkaNfqmWtA18TcdJqi11CdJiosNcq4Oqp8xCDSEkLkbXTpSvILsJ3+WqSjiX4oUiIBUI+QEvoHZw675yjMl//s1b/pTAo6USS1IxLI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199018)(46966006)(40470700004)(36840700001)(40480700001)(336012)(36860700001)(41300700001)(44832011)(81166007)(8936002)(6862004)(5660300002)(82310400005)(82740400003)(31696002)(86362001)(356005)(40460700003)(2906002)(70206006)(70586007)(47076005)(54906003)(83380400001)(316002)(6512007)(6486002)(478600001)(6506007)(6666004)(186003)(26005)(8676002)(4326008)(36756003)(53546011)(2616005)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 14:33:40.3530 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6712ece8-e429-4c4c-facd-08db03982597 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9084 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/31/23 13:57, Luis Machado wrote: > Hi Joel, > > On 1/31/23 07:03, Joel Brobecker wrote: >> Hi Luis, >> >> On Mon, Jan 30, 2023 at 11:23:06AM +0000, Luis Machado wrote: >>> On 1/29/23 11:52, Joel Brobecker wrote: >>>>>>>>       - With that said, the patch appears to simply add a cache, >>>>>>>>         so the logic of it all doesn't appear to be extremely >>>>>>>>         complicated. So I would rate the risk to be low. >>>>>>> >>>>>>> That's what it seems to me. >>>>>>> >>>>>>> I think another round of testing would be a good step to make sure there are no hidden bugs. >>>>>> My understanding is that the problem was making debugging borderline >>>>>> impossible.  Or at least, really, really unpleasant.  So I think it >>>>>> qualifies as a bug fix, and that the benefit is worth the risk. >>>>> >>>>> Right. Past a short number of frames, unwinding got really really slow. >>>> >>>> The part that I haven't been clear on is whether this affected everyone >>>> on Arm-32bit, or everyone on both Arm and AArch64, or just a subset >>>> of the users? >>> >>> Just a subset. >>> >>> It affects 32-bit m-profile Arm targets that report the additional stack pointers.  This is either >>> the org.gnu.gdb.arm.m-system feature or the org.gnu.gdb.arm.secext feature. >>> >>> I'm fairly sure these features are only reported by emulators and bare-metal targets. >>> >>> Now, a 64-bit gdb can debug 32-bit Arm as well, so you could have a 64-bit gdb running into this too >>> if the target is a 32-bit m-profile Arm. But the target is still 32-bit Arm. >>> >>> This doesn't affect AArch64 at all. >> >> Thanks for the extra effort explaining the impact. This is much clear >> for me, now. With your permission, I'd like to copy the text above >> as a comment in the PR. Would that be OK?> > > Yes, that's fine. Let me know if you want me to do it. > >>>> Regardless of the above, I agree we can backport. To avoid confusion, >>>> can I leave this to you, Luis, to confirm that the two patches I identified >>>> previously are the only two patches that need to be backported, and >>>> can you backport those for us, with a round of testing if you haven't >>>> done so already, just to double-check? >>> >>> Sure. I gave it a try with master and the test results look the same with or without the patches. >>> >>> Unfortunately the 32-bit Arm test results are not too clean as there is quite a bit of noise from >>> failing watchpoints tests. >>> >>> I'll try with GDB 13 just to be sure. >> >> Thank you. Once you've finished testing, whatever that might be, >> you can go ahead and push the patches. As disussed earlier, we all >> agree the risk of bad impact is very low. >> >> Let me know when this is done. It's starting to look like we might >> have a pre-release created this weekend! Maybe earlier, if I can >> carve some time out of my work schedule. >> > > I ran checks with the gdb 13 branch and the results look the same for a patched gdb compared to > an unpatched one. > > I'll cherry-pick both commits to gdb 13 once sourceware is back up. Done now.