From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2117.outbound.protection.outlook.com [40.107.116.117]) by sourceware.org (Postfix) with ESMTPS id 1B2FF3858D35 for ; Tue, 16 Apr 2024 16:14:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B2FF3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B2FF3858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.117 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713284053; cv=pass; b=OMxiFmswBv6tQYpx6AvCm9+OqVYbm73qlt+7isPWjj/XW9JXGIkFrP/7gIBozhcbUmP22Lz+Z66P2LMfTV7VZ4t0xeHwJk3mcCofLhEUhi+SabwvceqW7104mDHtSpuDaaG/CF1q9tnwKQnbN/rf5+ztZ/1wC7PV8esOmZLFvUY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713284053; c=relaxed/simple; bh=ZoiGOK431iFanvR0eOYyZG7JlWiBRtRU0acfqPFJm2Q=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=yEcL0Npq9PavSwYHID7KbfSY2kAlXflEZMsQE1rwoWaU519YzhfB1/NBtmkK+eM8k6BqQh1X62hUVDxlY/UdfKfRnmwkAnCbaozGnsunNahL8s+lxtA/ZiH9HCzM0HTIQrPFfI54cMgv646Xca+RVVhe9D4t5d6PU4nA/oCJQiY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FOnsAwj2jwAjpCoLBmnj3HbmLAff/XnGU+EUweW2zVXy3Wx2UCKDu2uar98d4BwV8QXSgphB50q0ESIOURI/wpXXe/sh8kf+xWBvOYn8lhK0qqrAhIRwUlMZh9Jr4AoYugRyx8vB4om43V2FaoPc2dXxISGO3RlnU3OlpZeaMDIPySH5PV6YkxdZLkHajLpaVUGDlWjc3PhXTzU33pAVsWuSOS1berH2HlzmCF1TOKI8DXLe+9rrU+1VqNbeeJkytEZkoAoV13VhO3rEDseWDPGwxyAIpMvaEui+FPHNM+I905Ufp4pXfL9/+L9yubrBJW4unQOzgnu6uhMK7y/PiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fMrnJKOsblm3Mejvwsg6PHqQBjYbppaN2EV0rR891E0=; b=DVb3TrdJazrcCkMVbzD0dCjEkxemaUz5G3HLBC86XNNAlTbjUs6XbRCJBAnxBy5oB6yHWTOK89yDmNXrlW/RcSlixrDhgVDASvyhxrJBOBk9pvJEzf7MMhvCjtuHCUm1DL6SgobV0B+yrNOT2iRbppddpmsQwLdmIYQ7N0MctUhqcTXxxpHFEbyaSOKH2Fb4MttbTsJAx22gEx19kOLYZOMkgFvD9nNn5ePkAajHN0evmPCtEN7E4oX373YTH66etxxaMkgGR49FXIQYNtLyILxenT2spK3PJS8GP3i4+9V+0+w5wqRnh5oNBXAqWHsqGVrRJlpitWjP6OvyBQvglA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fMrnJKOsblm3Mejvwsg6PHqQBjYbppaN2EV0rR891E0=; b=ceSrFJFV5dv6Kg/w4MVfwVldr/fqIo6eqKf1FWtINJ4B35QkRVwn/VYEmDfokVtNVBT2o3/fhGnv9SblwC6o7aVPIBRh4he5t59f7/76m8NSbRqDMtnyv5U8I5VDt2OUezLGtYk08+7DgV2pwooCd7riGjsHFsVJbR5DY9POH/bAzYG/W4ymEAOSNV2CTdoqzv44xOkeVN3buzRwRyfCn841toEYiwa4mg3vnwBHKL011myM3OonSfD+AIUGsLWc6TjZ4YFYmqGfat8sU/QFlNndwjtLvSvF5p3j1hfxWSYf9I7FJad/DcJK7/g6YTWt9SNSvl44UUP1sweuKu3NvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YT2PR01MB10699.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31; Tue, 16 Apr 2024 16:14:04 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1%5]) with mapi id 15.20.7472.027; Tue, 16 Apr 2024 16:14:04 +0000 Message-ID: <7e747028-383d-4ce4-a38f-c5ba08c68cb2@efficios.com> Date: Tue, 16 Apr 2024 12:14:02 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/make-target-delegates.py: don't handle "void" in parse_argtypes To: John Baldwin , Simon Marchi , gdb-patches@sourceware.org References: <20240416155229.1543806-1-simon.marchi@polymtl.ca> <11e63b74-829d-49e1-bcd2-a784ce2afda0@FreeBSD.org> Content-Language: fr From: Simon Marchi In-Reply-To: <11e63b74-829d-49e1-bcd2-a784ce2afda0@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0341.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6b::7) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YT2PR01MB10699:EE_ X-MS-Office365-Filtering-Correlation-Id: f7c54f63-8c90-447c-9a04-08dc5e303c21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3Lz66ffPuzJahNlKej2bO1VstLnmm718Wlm2p9tO9lOa+T0pUJOS6rX0scSC5PVMHtoVGmx5OuYpvNPPqekYwdRwWiDQU2rtPbLmf2e4PEm5AuzysqgthY5ff1soPXL5UyjA0A/wq2AkeCgremJkVXzBsGFRTjRjdbCCTe8J+vpUcJMZ6ti01369AQjW9Ng+ZN/933l8E5+l+bMv2YQP+wA6I30JETUZYDsW/1gE4MrOcLUShdq9ucUqjidQ0mya9wRsWqDrv3Ks+X+sW+xonQ2jlTT5Gx6c/BXbVdwYoBPVJSP1n8qv0TUUxlhx41eP9tw4woZ3ZYEFoaeJHVBtScSLImSD7Fy34o941Ne5EmQc7iTYYlygFh5hJOtuZFikMeRtpsQjGg2YtrEHRpWJhRsvDKxHlG51CE1TEnOlPwMWcEXv6b33bAm+Cx4SwvAqhILF/FHn6GGirny2UuS4UFIN4uYaqCqPKh54Ly2pn2jD3XDxxieTpQeeDslbn+kdGG5QSpbj//TpXacjR/BKWwBS6qHZCc4+b4I1ee/GoMxLBzig3/8kX7mQCIyAGe5BQ3HdvtcwitdaaDc5XhXCJ1zvjKpQe7kNJV9SWM7eolyd4rMR3urPod3KRO/tvxkdPwHpKm+pQ7wpFu/5ikVF540pZFPTebrsyZOCWPFEFQw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STl1RXhEenZaL1d5T1R2SnBJY1M2OHVHSGZFUVJHVktzNnpwU3oyVDJLYVVZ?= =?utf-8?B?bXhBallnaFdiVnRqQ3hObUxZZHQ1dTFLdWhqWXd4RW54RlJLVGErTTRnVXZa?= =?utf-8?B?akdPQms4UklRQ1N4ZzhDQXJaTDBVRWtPV1h5UGJwV2dJVGNsNWZlVS9Za2c4?= =?utf-8?B?L1dYUEZLc1U3L2NzTUtSNWdBUnc4Z0FnSFNaK1lxRWpwRmZBb0xKZDEreWxo?= =?utf-8?B?VnFBS2lFb01UTGoyVGJnZG9ybk5BbUlKbG5JbDlIMUxodEhkZ0J3em16NlVu?= =?utf-8?B?SU5YQm5EQ3psL28vdUNISGEyOFkweU9TUkVDOVdZbWR2Nlh6V3htTEYvUGwv?= =?utf-8?B?b1FhVUx5YStSL0g1dXBjTHFRODg5eEZiYjJiL3dWN1UxVktIQzJIMXZrNGZj?= =?utf-8?B?LzVZTmYwbk9SOE14cGIxK3VQUGJaSXJ6SHNBTHFqb1RlanhXUmFFZWtDVG0y?= =?utf-8?B?V2krWDJWVnpwTnIwSC8rMDV2VllQK1JjWDBYTFdtVGxYNTBpamtwc2tIYS9N?= =?utf-8?B?eTY2Rjd6enl4SWpVZFpQb0RRNlYybFNSSFY4bUJUbmZrQmY2a2l6MEYxMXdC?= =?utf-8?B?T2xkazJ6eS91L0Nta3JXNUV2WjBjTEkxWXRpVFRUQU9LS1dwRkU2VWlSbm1T?= =?utf-8?B?VGhGOE00Q0d6NU1nd2FvbzBEekFIVTVFRGtXdEVOZk1JL2VIbGxKYjhYdjF3?= =?utf-8?B?VTA4UU5CbWgvWWJnWWJQaXp2VlNqTVQ1QThnNC9uY0VVUXlSZEEyajFFQk8x?= =?utf-8?B?ajg1bU4wZnk5aE8vZlJkQ2dJV1lGUUh3NFJqZGFjOXdrcDdDNCtuMTVkb3dB?= =?utf-8?B?V1dEa1AxRlNWTmpsMnlKSEVSVE5EN0N1clhLeVFrbnk0cy9wMXhqcFduUzI5?= =?utf-8?B?Lys2MmZRSGo1RTAwK0crUE9Ma1MvaURwdTd2VW8rdmVMMlBNV2pWV3RtWStX?= =?utf-8?B?ckxKWGpnODBLaUMvcTBxQTFraklmRjFscDlEdVRPdUNrdVlaWlFDSWZFQzJ2?= =?utf-8?B?U2ppbjByYkwyTGRmK3FVMm4wNXorMkFJdWQ0VTlBY1E4OTBHL0p2ZU14amhw?= =?utf-8?B?SUxvTzhqUFJBNFBjcTF5MzhsYW1VVjJJazlTR1RsdjhyWjR1b0Y5Y1hCQnVV?= =?utf-8?B?MDNPYytyWEZscWc5dFlTZmxIT1dicWU1Uk9yUW9SOGlpL2pLbERWdWN0N1dy?= =?utf-8?B?WDJ3ZFpmaGI1RjFVZERLMng5eWhoVlZrVGhaYkxsalJkOHZUd2Vxd3JEZnJH?= =?utf-8?B?UVkrRlBrSnYzUkprQldYMEFyWXlZWDJXV3hncWdMeGxRbU1tSDVPVWhPTjln?= =?utf-8?B?aGVXYnVmWTFSWFlleHlCY2lqbmc3T2g0bmxDWnIzUVBZUHFXS2pLZXlJd3Nw?= =?utf-8?B?eGMrZnNGVUtyamJENk9pekJNamZpektPMFNxODBEcVVHTnJCUVR6SG9MTzgr?= =?utf-8?B?b2NCUWtoOWp0Tkl0UXBUcDl6T2dMUVBuMFNZUHJCODlHdFNGMGZlWGl3QjR3?= =?utf-8?B?QzdaQm5menpCRHVnZmlKYy9kK3JzbGJ5dkJQcTB4Z0FmakpxR241bk5MOXoz?= =?utf-8?B?akZ4YVJnN2lRUDI3VS9laTRYY2VVYktNTmt6amIvTjZRQnZBR0ZqUzQrWHlJ?= =?utf-8?B?SjR6M2VrcTFyeHQvV2Mxb0VJbWJ3aXRyYkE3SmFFVDkwaUE5bjY0MFMrSjZT?= =?utf-8?B?ZzRDTDY5YXpEMDNWM09yekJnR00yMElsWEZLSjgyNHlaS2hQYjVUNk9Ma3Nj?= =?utf-8?B?ejdHZnU3TDYzWmZ5cHBxVjBHbzc4S1lacXNwa1E2azZ1bTFQbC8vc0VEMVdo?= =?utf-8?B?U3psT0dndmthdkpVa2cyeThFaExkKzRxK0hOK1JJT0prV3BseUkrMVdDb2Z4?= =?utf-8?B?U0ZIS01vbktaMmI4L0hFOFdUdStBd1BQT2lwUU82VVRzWkM0SWVlWmRXRUY0?= =?utf-8?B?UDNvaVVJRG00QzJWTXNsdmphdVlqdkR4Nm51U0d4ZmNXL2lJNUJqSUtBYm5W?= =?utf-8?B?NkFHUXlHbjhVSnQrWmxLeWt4Z3g1M0o5bVZFRzVqVzZHNk9ya21xd3B0bUJq?= =?utf-8?B?TGtkbjRBdWowRmJaZGJnVHZNQTMxaWNCM3ZRd0dsS3lzTHh2eE1vTkhCMmIv?= =?utf-8?Q?jftkJEDCdziquBuK8ihGml0r1?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7c54f63-8c90-447c-9a04-08dc5e303c21 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 16:14:04.1255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9jPy/7XMC6pb1EPZPGRhhKbYZHgJwi4EsqS+zvV+eRwWuBHKBVUzKNDwh1r94LtkEIu6epfMc57DfcM3DdRfYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB10699 X-Spam-Status: No, score=-3038.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/16/24 12:06 PM, John Baldwin wrote: > On 4/16/24 8:52 AM, Simon Marchi wrote: >> From: Simon Marchi >> >> I suppose this was needed when we had `void` in declarations of methods >> with no parameters. If so, we no longer need it. >> >> Change-Id: I0a2b398408aa129634e2d73097a038f7f80db4b4 >> --- >> gdb/make-target-delegates.py | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/make-target-delegates.py b/gdb/make-target-delegates.py >> index 4d18d2802ced..1893fc63ca84 100755 >> --- a/gdb/make-target-delegates.py >> +++ b/gdb/make-target-delegates.py >> @@ -149,8 +149,9 @@ def parse_argtypes(typestr: str): >> typestr = re.sub(r"^\((.*)\)$", r"\1", typestr) >> result: list[str] = [] >> for item in re.split(r",\s*", typestr): >> - if item == "void" or item == "": >> + if item == "": >> continue >> + >> m = ARGTYPES.match(item) >> if m: >> if m.group("E"): >> >> base-commit: 3f6a060c7543332d0cb4377fc318e2db01ea1d3c > > Seems ok to me. I assume it doesn't result in any differences in the generated > code today? Exactly. I'll add a mention in the commit message. > Approved-By: John Baldwin Thanks, will push. Simon