From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110450 invoked by alias); 30 Jul 2017 18:31:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110422 invoked by uid 89); 30 Jul 2017 18:31:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:617 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Jul 2017 18:31:21 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v6UIVEqh021419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 30 Jul 2017 14:31:19 -0400 Received: by simark.ca (Postfix, from userid 112) id A65F21EA05; Sun, 30 Jul 2017 14:31:14 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 98BE21E043; Sun, 30 Jul 2017 14:31:03 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 30 Jul 2017 18:31:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA v2 02/24] Introduce and use gdb_file_up In-Reply-To: <87a83lao3t.fsf@tromey.com> References: <20170725172107.9799-1-tom@tromey.com> <20170725172107.9799-3-tom@tromey.com> <87a83lao3t.fsf@tromey.com> Message-ID: <7e75f607a657ebe57bc4830b393d9573@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 30 Jul 2017 18:31:14 +0000 X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00443.txt.bz2 On 2017-07-30 18:25, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> The name could lead people to think that this deletes/unlinks > files, > Simon> don't you think? > > I don't expect anybody to use this name anywhere. I believe I chose it > because it's the typical naming scheme for these deleters. I can > change > it though. Please suggest a different name. > > Tom Ah ok I see, delete in that sense. And fclose is the most common way to delete (as in de-allocate) a FILE *, so it makes sense. Fine with me. Simon