From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30821 invoked by alias); 9 May 2018 23:09:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30812 invoked by uid 89); 9 May 2018 23:09:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sk:PROCESS, *args X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 23:09:18 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54C184059FFC; Wed, 9 May 2018 23:09:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D62FC10B009A; Wed, 9 May 2018 23:09:15 +0000 (UTC) Subject: Re: [PATCH 1/3] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error To: Joel Brobecker , gdb-patches@sourceware.org References: <1525458603-33351-1-git-send-email-brobecker@adacore.com> <1525458603-33351-2-git-send-email-brobecker@adacore.com> From: Pedro Alves Message-ID: <7e9a3425-4b6d-10c9-0945-73b39bd8bb6f@redhat.com> Date: Wed, 09 May 2018 23:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1525458603-33351-2-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00227.txt.bz2 On 05/04/2018 07:30 PM, Joel Brobecker wrote: > Trying to start GDBserver on Windows currently yields the following > error... > > $ gdbserver.exe --once :4444 simple_main.exe > glob could not process pattern '(null)'. > Exiting > > ... after which GDB terminates with a nonzero status. > > This is because create_process in win32-low.c calls gdb_tilde_expand > with the result of a call to get_inferior_cwd without verifying that > the returned directory is not NULL: > > | static BOOL > | create_process (const char *program, char *args, > | DWORD flags, PROCESS_INFORMATION *pi) > | { > | const char *inferior_cwd = get_inferior_cwd (); > | std::string expanded_infcwd = gdb_tilde_expand (inferior_cwd); > > This patch avoids this by only calling gdb_tilde_expand when > INFERIOR_CWD is not NULL, which is similar to what is done on > GNU/Linux for instance. > > gdb/gdbserver/ChangeLog: > > * win32-low.c (create_process): Only call gdb_tilde_expand if > inferior_cwd is not NULL. LGTM. Thanks, Pedro Alves