From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 9FC7F3858C42 for ; Sat, 16 Dec 2023 09:26:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FC7F3858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FC7F3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702718799; cv=none; b=C5PqsaIjk2KYayhghehydsdXG2dseEWvmqz56QMKG0Vn9RsAgjkfjxLPSXCJdJD2QQEQgqF/MCDzm/31yeFa7bXM4ojVgdVT9AcTV99BjIf2e9hLz58F6CrEjGRG42DiuOZpe8lACClN3sXRrAPb7UdMKQHeUBPmJ89c61c42Lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702718799; c=relaxed/simple; bh=0D20KRuN7yCIgr+nyOlWv+zpMcNm7dblTXf9CSZbQuE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=q79m1n1k0HuT5RvFQrbDKoJuEDRiTYfhyG4d+om17hWL9w6NJpqNT9042y+Fasktp0paDOX/eGRcCcg1klaUrd3lM4LOnSOvQjf6XJrrzq4IzxaX+fvlAKNA3ENXWsIzab164PtMrGjgSHyQGWbuXlLFeqGdu1CFam+C4eYVJuQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 745BE1FDCE; Sat, 16 Dec 2023 09:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702718797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aJzKmCEBpePV1BVi6KjOgYFXd6X+YC0on3PnRICNEc=; b=W4M4hWzDIFZ6rC0jZ2Xv/mZzNhgPBaHEJcc7bQxQhMDBg5Puclw9efyqA9oIqU34CG6rsM dYxqJh3pi8yGOwi560Sv7yl3Fosl7dHf8MpmYZu8MPyCLs3ChXQicN64XJ15petE5Howc/ NZNKSoQoSWobKVihlzUfKK9H+H0/efE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702718797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aJzKmCEBpePV1BVi6KjOgYFXd6X+YC0on3PnRICNEc=; b=QrM5RuzNLxVuInB5bIdLV3UcZYgqcx99NrJa1+IutV/Ek9joRi8syTu612kmxwOFjZyVPA gMJiEqrcPI2MCmCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702718797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aJzKmCEBpePV1BVi6KjOgYFXd6X+YC0on3PnRICNEc=; b=W4M4hWzDIFZ6rC0jZ2Xv/mZzNhgPBaHEJcc7bQxQhMDBg5Puclw9efyqA9oIqU34CG6rsM dYxqJh3pi8yGOwi560Sv7yl3Fosl7dHf8MpmYZu8MPyCLs3ChXQicN64XJ15petE5Howc/ NZNKSoQoSWobKVihlzUfKK9H+H0/efE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702718797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9aJzKmCEBpePV1BVi6KjOgYFXd6X+YC0on3PnRICNEc=; b=QrM5RuzNLxVuInB5bIdLV3UcZYgqcx99NrJa1+IutV/Ek9joRi8syTu612kmxwOFjZyVPA gMJiEqrcPI2MCmCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5A88D136CF; Sat, 16 Dec 2023 09:26:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TJpbFE1tfWVcaQAAD6G6ig (envelope-from ); Sat, 16 Dec 2023 09:26:37 +0000 Message-ID: <7e9b02eb-dd08-4419-a11d-953449cedbba@suse.de> Date: Sat, 16 Dec 2023 10:27:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Use more box_width in tui-regs.c Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231215113752.29375-1-tdevries@suse.de> <87msub8os1.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87msub8os1.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spam-Level: X-Spamd-Result: default: False [-2.65 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.56)[98.05%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Authentication-Results: smtp-out2.suse.de; none X-Spam-Score: -2.65 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/15/23 16:32, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> /* Now create each data "sub" window, and write the display into > Tom> it. */ > Tom> - int cur_y = 1; > Tom> + int cur_y = box_width (); > > It is sort of weird to see the pairing of "y" and "width", but I suppose > there isn't a "box_height" method. > Yeah, I may have confused width and thickness when choosing that name. Anyway, looking at one of the PRs you just filed, we may go to a hborder/vborder (horizontal/vertical) approach [ or even a tborder/bborder/lborder/rborder (top/bottom/left/right) approach ] and I suppose that could be a good moment to rectify this misnomer. > Anyway it seems fine. > Approved-By: Tom Tromey Thanks for the review. Committed. Thanks, - Tom