From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66902 invoked by alias); 26 Jul 2017 20:53:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65670 invoked by uid 89); 26 Jul 2017 20:53:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 20:53:15 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v6QKr87T030851 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Jul 2017 16:53:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 49D621E98E; Wed, 26 Jul 2017 16:53:08 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id D2F3A1E043; Wed, 26 Jul 2017 16:53:06 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 26 Jul 2017 20:53:00 -0000 From: Simon Marchi To: Ruslan Kabatsayev Cc: gdb-patches@sourceware.org Subject: Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode In-Reply-To: <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> Message-ID: <7ee96675bc6f2307642fb638a9b65839@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 26 Jul 2017 20:53:08 +0000 X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00414.txt.bz2 On 2017-07-26 21:19, Ruslan Kabatsayev wrote: > So, the patch seems to have been approved by one reviewer (see [1]). > But it > doesn't appear to have been pushed, nor do I have any further > instructions > on how to get it merged. What should I do? Hi Ruslan, The patch is fine with me too, it seems to work well and it's a good idea. It might be a bit more work to implement (an idea for another patch maybe), but do you think it would be nice if n and s did next and step when focusing a source window, but did nexti and stepi when focusing an asm window? When in an asm window, I think you will much more likely want to use nexti/stepi than next/step, so maybe they should be bound to the n and s rather than N and S in that case? In order to get the patch in, you have two choices: if you plan to contribute more in the future, we can get you write access to the repo, so that you can push your patches in once they are approved. Otherwise, we can push it for you. Let me know what you prefer. Thanks, Simon