From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CB7723858433 for ; Mon, 20 Mar 2023 14:57:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB7723858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B99251E110; Mon, 20 Mar 2023 10:57:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1679324238; bh=xFuNhwWXDv07h/wos5lQ9l1W07/pCiGzmd6+VFGL33I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pHJMsm12n9PhetwV7CIGiIQw1BqaSITQ0prftQjoncj09pKO0e3xHglMkkteR2b6M AFUf93KunfL4WChCKyUXrS3aMUPiHtKrcrRir2PfVdJJY7XTb+uHrHew4R6EFgOj6r 6AxLf5ZQcQ0/s2P4o3odn5IRJf/QHLaHZMa0zibI= Message-ID: <7eea0b7e-bc77-3f9e-4062-77940970d952@simark.ca> Date: Mon, 20 Mar 2023 10:57:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/5] Change linetables to be objfile-independent To: Tom Tromey Cc: Simon Marchi via Gdb-patches References: <20230308-submit-constify-linetable-v1-0-ca4057478141@tromey.com> <20230308-submit-constify-linetable-v1-2-ca4057478141@tromey.com> <87jzzne1vo.fsf@tromey.com> <87fsaaejnb.fsf@tromey.com> <87y1nwiyk2.fsf@tromey.com> <7ef34f41-d90a-8173-b0b8-08a19b0b4484@simark.ca> <87bkkscled.fsf@tromey.com> <0a02e351-0b13-c3b0-f324-b8e71ea44a7b@simark.ca> <877cvfcynt.fsf@tromey.com> <87r0tnauj0.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87r0tnauj0.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/17/23 18:21, Tom Tromey wrote: > Tom> #1 Renaming is fine but the "_raw" name was chosen to match psymtabs. > > Well, I have this partly wrong, sorry about that. > > psymbols themselves use the other name: > > CORE_ADDR unrelocated_address () const > > but psymtabs use: > > CORE_ADDR raw_text_low () const > CORE_ADDR raw_text_high () const > > and so do minsyms: > > CORE_ADDR value_raw_address () const > > I think one set or the other should be renamed. Which one do you > prefer? I could go either way. Anyway let me know and I'll rename > stuff. I prefer "unrelocated", since it's a bit more specific and precise than "raw". "raw" suggests that it's a value before some kind of processing, but it doesn't tell which processing that it. With "unrelocated", you know it's before relocation. Simon