From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26251 invoked by alias); 27 Dec 2017 00:30:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26233 invoked by uid 89); 27 Dec 2017 00:30:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:788 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Dec 2017 00:30:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vBR0Uctx031680 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Dec 2017 19:30:43 -0500 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 60AA21E02D; Tue, 26 Dec 2017 19:30:36 -0500 (EST) Subject: Re: [PATCH v4 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p To: Stafford Horne , GDB patches Cc: Eli Zaretskii References: <20171226134832.23497-1-shorne@gmail.com> <20171226134832.23497-5-shorne@gmail.com> From: Simon Marchi Message-ID: <7efaac98-a656-1453-5ecb-f3cf5184b7b7@polymtl.ca> Date: Wed, 27 Dec 2017 00:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171226134832.23497-5-shorne@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 27 Dec 2017 00:30:38 +0000 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00504.txt.bz2 On 2017-12-26 08:48 AM, Stafford Horne wrote: > tdesc_register_in_reggroup_p in now able to handle arbitrary > groups. This is useful when groups are created while the > target descriptor file is received from the remote. > > This can be the case of a soft core target processor where > registers/groups can change. > > gdb/ChangeLog: > > yyyy-mm-dd Franck Jullien > Stafford Horne > > * target-descriptions.c (tdesc_register_in_reggroup_p): Support > arbitrary strings. Please mention tdesc_use_registers in the ChangeLog. I also usually mention changes to comments, such as the change to tdesc_reg::group's comment. LGTM with that fixed. Thanks! Simon