From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AE805385801D for ; Wed, 7 Apr 2021 21:49:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AE805385801D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 137LnTkQ021315 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Apr 2021 17:49:34 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 137LnTkQ021315 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 79FCE1E01F; Wed, 7 Apr 2021 17:49:29 -0400 (EDT) Subject: Re: [PATCH 2/4] testsuite, gdb.mi: fix duplicate test names in mi-break.exp To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <77d4ac57ada8013cf55e111b073a849334dd10da.1617806598.git.tankut.baris.aktemur@intel.com> From: Simon Marchi Message-ID: <7f057f29-c202-9473-3fdc-5e01e70da109@polymtl.ca> Date: Wed, 7 Apr 2021 17:49:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <77d4ac57ada8013cf55e111b073a849334dd10da.1617806598.git.tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 7 Apr 2021 21:49:29 +0000 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 21:49:38 -0000 On 2021-04-07 10:55 a.m., Tankut Baris Aktemur via Gdb-patches wrote: > gdb/testsuite/ChangeLog: > 2021-04-07 Tankut Baris Aktemur > > * gdb.mi/mi-break.exp: Fix the duplicate test names. What would you think of using proc_with_prefix, as the patch below does? I find that adding the test proc name in the test names helps to give a bit of context. >From 03f0d5465a59a3e7de30ad19255b239f3a0cd459 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 7 Apr 2021 17:46:14 -0400 Subject: [PATCH] patch Change-Id: Ibb103c3de2b8fe257f83c569117c4fd422e41379 --- gdb/testsuite/gdb.mi/mi-break.exp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-break.exp index a7c37b365e93..19438f21f634 100644 --- a/gdb/testsuite/gdb.mi/mi-break.exp +++ b/gdb/testsuite/gdb.mi/mi-break.exp @@ -46,7 +46,7 @@ set line_callme_body [expr $line_callme_head + 2] set fullname "fullname=\"${fullname_syntax}${srcfile}\"" -proc test_tbreak_creation_and_listing {} { +proc_with_prefix test_tbreak_creation_and_listing {} { global srcfile global line_callee4_head global line_callee4_body @@ -96,7 +96,7 @@ proc test_tbreak_creation_and_listing {} { "delete temp breakpoints" } -proc test_rbreak_creation_and_listing {} { +proc_with_prefix test_rbreak_creation_and_listing {} { global line_callee4_body global line_callee3_body global line_callee2_body @@ -165,7 +165,7 @@ proc test_rbreak_creation_and_listing {} { "delete temp breakpoints" } -proc test_abreak_creation {} { +proc_with_prefix test_abreak_creation {} { mi_create_varobj tpnum \$tpnum "create local variable tpnum" # Test that $tpnum is not set before creating a tracepoint. mi_gdb_test "521-var-evaluate-expression tpnum" \ @@ -183,7 +183,7 @@ proc test_abreak_creation {} { "524\\^done,value=\"10\"" "eval tpnum after tracepoint" } -proc test_ignore_count {} { +proc_with_prefix test_ignore_count {} { global line_callme_body mi_gdb_test "-break-insert -i 1 callme" \ @@ -196,7 +196,7 @@ proc test_ignore_count {} { {"" "disp=\"keep\"" } "run to breakpoint with ignore count" } -proc test_error {} { +proc_with_prefix test_error {} { mi_gdb_test "-break-insert function_that_does_not_exist" \ ".*\\^error,msg=\"Function \\\\\"function_that_does_not_exist\\\\\" not defined.\"" \ "breakpoint at nonexistent function" @@ -226,7 +226,7 @@ proc test_error {} { "conditional breakpoint with garbage after location" } -proc test_disabled_creation {} { +proc_with_prefix test_disabled_creation {} { global line_callee2_body set bp [mi_make_breakpoint -number 6 -type breakpoint -disp keep \ @@ -241,7 +241,7 @@ proc test_disabled_creation {} { "test disabled creation: cleanup" } -proc test_breakpoint_commands {} { +proc_with_prefix test_breakpoint_commands {} { global line_callee2_body set bp_no_script \ @@ -281,7 +281,7 @@ proc test_breakpoint_commands {} { mi_gdb_test "-break-commands 9 \"bt\" \"set \$i=0\" \"while \$i<10\" \"print \$i\" \"set \$i=\$i+1\" \"end\" \"continue\" " \ "\\^done" \ - "breakpoint commands: set commands" + "breakpoint commands: set more commands" mi_send_resuming_command "exec-continue" "breakpoint commands: continue" @@ -318,7 +318,7 @@ proc test_breakpoint_commands {} { # code. In-depth testing of explicit breakpoints is accomplished in # gdb.linespec tests. -proc test_explicit_breakpoints {} { +proc_with_prefix test_explicit_breakpoints {} { global srcfile global line_callee3_head line_callee4_head global line_callee3_body line_callee4_body -- 2.30.1