From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9C7E63858D20 for ; Mon, 11 Mar 2024 16:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C7E63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9C7E63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710174188; cv=none; b=LliBXfqEnvysTESjl9K+9aWYoGOrucPYGQ5q8p3KMZPC0uPkqSx9tXCYAgK+laIq/sg9DrQNYCZUw/zxhOVgMqbrqTXAG1dl+6PYBYoK7j69gt6XGrnjcw0ALvwsTQvahq9uhcsUGDQtazsYC82/9Y+YtKDDhuu1azoSn0sbOHA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710174188; c=relaxed/simple; bh=eKoJarnFuFhGu8y8Yd6PTmz0OtM4mRKVtZOm5ndaCS0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XkonXV4Vg0EdzqUfFCHErVur0Gl2X2xIkIEtJXNzYgkGz3XBveTsdz7/i+EZ2yQks4JwmNCAbh9b1Rgh0482YRzBmi7hlNSafcgGGAOo5lgUmK3nhoxQ1IWNzyITnDaakaXlM0Ce0X9NoEuZrmKr7XKFHxez7+a2NZh6op9gEkg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 42BGMxbD021952 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 12:23:04 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 42BGMxbD021952 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1710174184; bh=Udu9NIXXjKwFgWeiQqXf5KzUEn6BFrZXxmM8aHptWus=; h=Date:Subject:To:From:In-Reply-To:From; b=HIIQrbgzAAQqA7vmClwCqSuhL/7J1x/OMHPB2T+HijpHiUDGVK2A815H8hrt91hAN fk/cQruN/qr/gaXHwZ/oUI5c1gTghm7nJk2u9qTcWEA6rT6sCD49qcAwH7EdcxvAIL ca9y4S4tjQpjnSE8yuyVaSmZTCWA0aB6F0IZs/9s= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6395D1E0AC; Mon, 11 Mar 2024 12:22:59 -0400 (EDT) Message-ID: <7f3d74e0-1825-477d-9842-1d7f7fce221a@polymtl.ca> Date: Mon, 11 Mar 2024 12:22:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/build] Fix static cast of virtual base Content-Language: fr To: Andrew Burgess , Tom de Vries , gdb-patches@sourceware.org References: <20240222161804.1134-1-tdevries@suse.de> <87frx39s43.fsf@redhat.com> <1e54180b-6665-43c7-9c3c-fdf72bd29a07@polymtl.ca> <8734sxqd3i.fsf@redhat.com> From: Simon Marchi In-Reply-To: <8734sxqd3i.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 11 Mar 2024 16:22:59 +0000 X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/11/24 06:25, Andrew Burgess wrote: >> This is similar to what I proposed here: >> >> https://inbox.sourceware.org/gdb-patches/24af4ea8-5426-4ce4-b1c5-12858b38a952@simark.ca/ >> >> The idea is the same, to have a static_cast in the DEVELOPMENT branch. >> I kinda like my version better, as it factors out the static cast >> (notice that both branches have identical static_cast lines after your >> patch) and the ifdef is just around a single assert. Also, I'm pretty >> sure the nullptr check is not necessary, as both dynamic_cast and >> static_cast can handle it. > > I agree yours is better. Do you have an official patch somewhere that I > can add a +1 too? If not then below is an updated version inline with > you proposal. Feel free to push your version if you have it somewhere. I didn't have a proper patch ready, what you sent LGTM. Thanks a lot for taking care of it. Simon