From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2074.outbound.protection.outlook.com [40.107.102.74]) by sourceware.org (Postfix) with ESMTPS id B6FCA3858416 for ; Wed, 12 Jan 2022 12:14:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6FCA3858416 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEN86lNTPFIuKNzZGczSIFJ1KJNkNRBgs35SFvDErSVsyhKOUpiV9x4lSfQ40HjSdJpTGF9PDmc1VJRNPUCrDq6yIONR3agFm93DN/wvJ4Vae/Fu/etMntkKh/ZPaaD7qwdqRUpJxtIfYAomFYNmSFOlrgvpaDt/Ig0vIEgw0DbviNB65VVVnY849yNB78FrutwKbFi7ph0fibXJCL0g+p0kviokK4MHrEncwEl90+btmaLr91hSp+tzOPgAO3gUz/eQ5f5tSBqYMoxvmvNXSVMfLCMs6zPhRmA+NJhGPr37ppxdBLe39XDQWglKoEbmKr1h7GHoOiuapRBMoXtcPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/G7gh4LWqveFrnb7Yju4p9QyTXhpRk4D525K+1CI9qQ=; b=Ie5CRr7VhJjspB2YqV9aAWUxm4geSvQ6/T9YTYzZ2QR749VacqFCK921LkXfgekKVOpIR5oydfxk/v7/1FJbaefeqIGRhEpACTWH8ei4LBzQ5j8crqqLDJSUHlDVG7lNh+qNp0B9x4uRyvlPr6kjYCfcRtwsfgdwn58dufi7QNCWg+HYLKJIf0CAeKjUeGIYbH2QfsPHlsjFahuYHedQTDgvBE7nVLDnYcackC1Go9VSZr2wbeTQl6GSDPwlBCu/8L/tt5Fhohqolko8ly23n7XQFP4d93Lu/gPoEq1iFmUlhZpbgAG+t8xHHrGOQ87HnZmr5bDANr/PvRYGUIDrYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5196.namprd12.prod.outlook.com (2603:10b6:408:11d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Wed, 12 Jan 2022 12:14:31 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::8a:f482:ebd8:3135]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::8a:f482:ebd8:3135%5]) with mapi id 15.20.4867.011; Wed, 12 Jan 2022 12:14:30 +0000 Subject: Re: [PATCH v4 05/28] Add to_value method to dwarf_location class To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20211105113849.118800-1-zoran.zaric@amd.com> <20211105113849.118800-6-zoran.zaric@amd.com> <87pmpyyiny.fsf@tromey.com> From: Zoran Zaric Message-ID: <7f652c5a-ca89-3f37-a3c1-7c86d7a41006@amd.com> Date: Wed, 12 Jan 2022 12:14:27 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <87pmpyyiny.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0147.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::8) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f37f97d-6d24-4b4b-b431-08d9d5c51618 X-MS-TrafficTypeDiagnostic: BN9PR12MB5196:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IXW++Opn+h2bsqEEXWhFU6FRZjPBbMUu8PT3X7c7E/84K/eF6OHJU4NmZ5SpDHASvFWoVd1x3DeioTdr86gEZL+EIupOgt7LJz5zPggvrT3CZC63x58pvkVzQBYoV1jYG0S3iUFsFfJaLwlm/m/U0JhMPzgZ8l+D2NaW3aeDCaAX48gf6tLfrOk0P8ya4UFTCJrzgsUBx67kaA2op+fFNirsGtcoUkpmCkOZc/igA5W6p5UWOEtezPa5X4bxenKx8FlYbQfB4EtQtMFJM7GFDeeQFd4AIaYXGvxXnhcHqfNU+M6tN5SGUCnk3Ba1Wk093DF+uC17/URdPD+UmXaa45v2UJB64Q33IR7N41EpeTBAGpAUMEL63IfltpEOB3px/6y+5aWF418aogHS/du8csmrEY6kHP/VHwmU3hDCZ0NxtO0bz+gpmB1o9ZBdD7B/y0VY+w80BmHrz+6Es/CIVeWunESEbn5HW7KtkQoF8zXXOzBJZ3SYrLFXdELKsDOkrLraFwibfXJge4D/QcnnmM4xuNhdHLgFlbJx0yqV8JWxoqf6F490PPVAeZx5x42R9+wFsLcZ6OZ0VKhdddKA0CnoTbPq2DdR4rMJF1KcMoYO8rJxn8aPzHbnEMzi9ngQ23EBytbhKFsHIYWsIVpYQQCEKabXJ38h69yMCSD8gc/in8JKWwqTjsBOGpsPw1w0qLhyYOKljGP7a4svbvwZydvpwMNpmjIdfxfg17o9ArGbjWkXu9AuuphIwRu2zz/a X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31696002)(66476007)(5660300002)(66946007)(8936002)(6666004)(66556008)(6486002)(44832011)(8676002)(316002)(508600001)(86362001)(6506007)(6512007)(2616005)(36756003)(38100700002)(2906002)(186003)(83380400001)(31686004)(110136005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0h5em1tTXBKWnlraTUrcUxLRFBZa3dsN1dKdVI5dHhlZFNFN01NSXJPUi9n?= =?utf-8?B?RExyL0hKZDZ4SmxNdTZQekd4aU5ORU5iZ3Z2R2ZldnZyZGVuanRCaSs4YzY1?= =?utf-8?B?VnJZb3pxYXNMU2Rqck0wZ1JxOC80bER6UXlUeTRyOEI4V0tVeC9EMXZLUTIz?= =?utf-8?B?ZDA4MEROM2FGZlpQM05jczcwMVZ6dW9JbG01RSs3QmJTUDBPOE03dVppSEMz?= =?utf-8?B?TjJ2REwxYmljaEI4MzhKUXJOMEJlVmV5SlFuTUxJbXpES0lESThHRGtxRmN0?= =?utf-8?B?dEs0MVUwM0NBeHNYejhyN25WYVg0OUZQRmdvYmxoNXZaeDE4WVpKOGF0ZXF3?= =?utf-8?B?TGJwMTJRODhCbFM0WGN5dmpJdlVzc1ZKRnJWN0VzK1FvdDArUWJtOVk5QkFT?= =?utf-8?B?VU5TRzBmTlJkdGFNdnRPKy9SSFpUQ29xYnRVTGJicHdoSG9zSFNHTWgxVGFK?= =?utf-8?B?d2dkd0FXejRHd1p6UFBzV1gvVU5HeWx1cld1b1VzUzNBdWIwMktjNGJ2SmNR?= =?utf-8?B?ZUUwb3RCNVdrKzVONHdlTEZkT2ZVMW1XdittMjkvL0xSd1RvMlE2Y0hMSVRr?= =?utf-8?B?RXVGaVlVemRZMlJFUzJPRmZra3hHaEZLVFNyR21QSU9nKytrNXA4MkNsYk90?= =?utf-8?B?b2JqNEYzWDlZaTJHazFDSHRKVmpLb0pKOXdna092U0g1QytLZ2duMkRCMjJi?= =?utf-8?B?akVYamI2cVVhbWM1WXEyamZSdGJHZDk0UHdnMHF3MkNEaWtJam4rSHl4M0la?= =?utf-8?B?c01GampyQVdBNGRhWWlEV1hFMmNFS2xqZklBNDY4SjNCWk9aOUF4aHp2ZDhP?= =?utf-8?B?SmVyV2VNaFBpakZjeHJIUnF6MjZ6azhKNTUrUmx6WWJWaTFERzBPMkE2UzZw?= =?utf-8?B?dTEwZ0ZTU2xSWUtpMzlJV3YwOURLSWdKWmR0aEVRbFlBSU1BcUY0akJtZGJU?= =?utf-8?B?RnNzZThlQWJVUC9XQlY3eWI4SGFYOFhEN1hkTUZaazV5Z0xlRUorVUF5RmF0?= =?utf-8?B?V0dHczVndnlIQnd0UHpuSkhxZjU4NnUzcnV3OWJXRE9YQkczNE1pMFFGNHJ2?= =?utf-8?B?R2ovWCtPVzNsMk52SytEVHpxSFE0ckFzbHdJUmRMWHkvRC9Kc0VnM00wcGJk?= =?utf-8?B?U3J4R2RIa25QODJ3dERvQXlSaXlqVExXWkZaN0Q4c29rY2t2K1VoZ2lHOE5U?= =?utf-8?B?UXpRMGxPYmk2Z0tJOUErUGdGMzFaWGFFNGZUaVpnUUJRWEIwTDVXM3hrUjF2?= =?utf-8?B?aC8zQkl4ZTkrb3J3U2ZJSG9OekFWbnNDd05OazE3QXh4SnNqTFpwd01tSHJ3?= =?utf-8?B?VVVNRjYvTGIxay9QSjZHWHlqWWMyUUdGWkVLU091bGQ4bkFpZ1o4ZU5TUGhl?= =?utf-8?B?N21MMzhvWDRBWGRrV2w4YVlZcUhtVXh4Z2l5UExVcTNHbWQyRnBzazhQcFJR?= =?utf-8?B?SlFBd0gwS2piR21Ba0dUcDBDUXVmS0x3ajBoamNVWVhFd3FPcWFvWDg3VHQ3?= =?utf-8?B?UWxzQmFidkRxcUtkRHBhMG9WY1N4OEJxeURXbDd2akZXbFJTc1RtU0xDWFpW?= =?utf-8?B?Z21DeTFiN2VqNEFpM0dkRGRXMDJvYTA2VE5LZVFhanAwQmY3c3BPbzkzMlFB?= =?utf-8?B?eG9sc1ZpN3ZKODFZTWkvUVdzejNod2FKeFliYTY3amV2aXZjVFliN0d5Sy9Z?= =?utf-8?B?RjBEMUg2ejRsaGY4ZTNlUU0rTWtwRzF3QVNITHJjUXlHZmRlYWJKYWJaR0xh?= =?utf-8?B?S2ZUbWRsNnBFUVcwUHVGNXRpY0pERm1JL0x5MTRVYXo0a05QNCtCN01DeXhS?= =?utf-8?B?S25IY3k4UTVXN3RoSzBtbG1UWUdYcHpZUlJMdFJLanpSeVN5aUdxVUlYS3BM?= =?utf-8?B?YlZ1cjdUYUR6UnA2TUJFM0VRR01LbWY0L1hxbUJtUTlReW96VnZ0QWVkM1cy?= =?utf-8?B?NjFKNHpWVkJNcm1TbG9BeTlMQlBGdXNtSUh0azlNNm43RUZrTS9lQ00yKzQr?= =?utf-8?B?SDZ1OHU2K3hzRGNrK1hYYVp4Z0NkdDR5aGxIaGhBbUU4SnRZMkxuVDhScXJR?= =?utf-8?B?QmdWdXAvQWpUVHl5OXprdURnbE5ySUhETVlrZXhobE80V1VuUnFuNmV3OVk2?= =?utf-8?B?d3JyeUtYNnJvOXh0UVRMNmx3OVJPZFBkbVJha2hyNk41MVJIUEFHUFBJK2xo?= =?utf-8?B?cVllTFlXaHBiYmFpckxpbTVxcWhnZW5PYVEzMFhQUDg5a3FEYTJwbzNGSW5r?= =?utf-8?Q?WX9/T2JEbA9cX13r2IS3Kh+IRA1uA0I7pkiewo9O4o=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f37f97d-6d24-4b4b-b431-08d9d5c51618 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2022 12:14:30.7502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZKdZLMFiAi+LKIfb/ZOo8A8F6X6xrjC2+1dKZCUTGq7BlzcCHoP+DzK+JoxXI/nSOLqhz1huDKBXBn9h9cxoog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5196 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 12:14:36 -0000 > > Zoran> Currently, we only know how to convert from a memory location > Zoran> description into a value, but it is resonable to expect a set > Zoran> of target hooks that would let the target decide on how to do > Zoran> other conversions in the future. > > When would this be useful? > > Anyway, this patch looks ok. > > Tom > This is a bit difficult question to answer. From the class design point, it is useful to have an unified interface for all DWARF stack elements. Having the generality and flexibility of a location description being on the stack and using that in conjunction with DW_OP_call like operations (for refactoring), one could have a need to convert a resulting implicit location description into a value. Also, there were some suggestions of operations that would use the value on the top of the stack as a register number or an index to a register bank. In that world, the expression could push a register location description (as a base of indexing), convert it to some kind of value representation, apply index calculation to it and then use that new operation on the result. In reality, we (AMD) don't need that flexibility, but it made sense to me to not be over restrictive where I didn't needed to be. Zoran