From: Simon Marchi <simark@simark.ca>
To: Shahab Vahedi <shahab.vahedi@gmail.com>, gdb-patches@sourceware.org
Cc: Shahab Vahedi <shahab@synopsys.com>, Tom Tromey <tom@tromey.com>,
Anton Kolesov <anton.kolesov@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH v4 2/3] arc: Add hardware loop detection
Date: Sat, 1 Aug 2020 10:53:38 -0400 [thread overview]
Message-ID: <7f7c4518-ef40-4ff0-d7c2-05bc6463a926@simark.ca> (raw)
In-Reply-To: <20200723193532.25812-3-shahab.vahedi@gmail.com>
This patch is also OK with these nits fixed.
On 2020-07-23 3:35 p.m., Shahab Vahedi wrote:
> diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c
> index 0c7e045e54b..59e698bb18b 100644
> --- a/gdb/arc-tdep.c
> +++ b/gdb/arc-tdep.c
> @@ -2006,6 +2006,35 @@ arc_check_tdesc_feature (struct tdesc_arch_data *tdesc_data,
> return true;
> }
>
> +/* Check for the existance of "lp_start" and "lp_end" in target description.
> + If both are present, assume there is hardware loop support in the target.
> + This can be improved by looking into "lpc_size" field of "isa_config"
> + auxiliary register. */
> +
> +static bool
> +arc_check_for_hw_loops (const struct target_desc *tdesc,
> + struct tdesc_arch_data *data)
> +{
> + const auto feature_aux = tdesc_find_feature (tdesc, ARC_AUX_FEATURE_NAME);
> + const auto *aux_regset = determine_aux_reg_feature_set ();
To be consistent, I'd suggest using the star in both places or not use it in both places.
> +
> + if (feature_aux == nullptr || aux_regset == nullptr)
> + return false;
If a function (I'm thinking of determine_aux_reg_feature_set) can't (according to its contract)
return nullptr, don't check for nullptr, that's:
(1) unnecessary
(2) confusing, since by reading this code my mind goes searching for a reason why
determine_aux_reg_feature_set might return nullptr
I suppose that tdesc_find_feature can return nullptr, if the feature is not present.
> diff --git a/gdb/arc-tdep.h b/gdb/arc-tdep.h
> index 6ca759a661d..e752348a262 100644
> --- a/gdb/arc-tdep.h
> +++ b/gdb/arc-tdep.h
> @@ -23,6 +23,7 @@
>
> /* Need disassemble_info. */
> #include "dis-asm.h"
> +#include "gdbarch.h"
I suppose that adding this is correct, as this file uses some things from gdbarch.h.
It's a change unrelated to the topic of this patch, so it's preferable to send it as
a separate patch, with its own explanation.
Simon
next prev parent reply other threads:[~2020-08-01 14:53 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 12:52 [PATCH 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-03-26 12:52 ` [PATCH 1/4] arc: Add XML target features for Linux targets Shahab Vahedi
2020-04-24 13:46 ` Tom Tromey
2020-03-26 12:52 ` [PATCH 2/4] arc: Recognize registers available on " Shahab Vahedi
2020-04-24 13:50 ` Tom Tromey
2020-03-26 12:52 ` [PATCH 3/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-04-24 14:00 ` Tom Tromey
2020-03-26 12:52 ` [PATCH 4/4] arc: Add arc-*-linux regformats Shahab Vahedi
2020-04-24 14:01 ` Tom Tromey
2020-04-06 9:13 ` [PING][PATCH 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-04-20 16:51 ` [PING^2][PATCH " Shahab Vahedi
2020-04-28 16:04 ` [PATCH v2 " Shahab Vahedi
2020-04-28 16:04 ` [PATCH v2 1/4] arc: Add XML target features for Linux targets Shahab Vahedi
2020-05-14 14:49 ` Simon Marchi
2020-04-28 16:04 ` [PATCH v2 2/4] arc: Recognize registers available on " Shahab Vahedi
2020-04-28 16:56 ` Eli Zaretskii
2020-05-14 15:01 ` Simon Marchi
2020-06-17 15:46 ` Shahab Vahedi
2020-07-13 15:48 ` Simon Marchi
2020-07-14 9:05 ` Shahab Vahedi
2020-04-28 16:04 ` [PATCH v2 3/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-05-14 15:09 ` Simon Marchi
2020-06-15 23:13 ` Shahab Vahedi
2020-06-16 0:58 ` Simon Marchi
2020-04-28 16:04 ` [PATCH v2 4/4] arc: Add arc-*-linux regformats Shahab Vahedi
2020-05-14 15:12 ` Simon Marchi
2020-06-15 23:37 ` Shahab Vahedi
2020-06-16 2:08 ` Simon Marchi
2020-05-14 11:43 ` [PATCH v2 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-07-13 15:45 ` [PATCH v3 0/3] " Shahab Vahedi
2020-07-13 15:45 ` [PATCH v3 1/3] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-07-15 2:52 ` Simon Marchi
2020-07-15 20:35 ` Shahab Vahedi
2020-07-15 21:23 ` Christian Biesinger
2020-07-16 1:59 ` Simon Marchi
2020-07-16 13:28 ` Simon Marchi
2020-07-22 13:36 ` Shahab Vahedi
2020-07-22 13:49 ` Simon Marchi
2020-07-22 14:33 ` Shahab Vahedi
2020-07-22 14:54 ` Simon Marchi
2020-07-13 15:45 ` [PATCH v3 2/3] arc: Add hardware loop detection Shahab Vahedi
2020-07-15 2:55 ` Simon Marchi
2020-07-13 15:45 ` [PATCH v3 3/3] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-07-15 3:03 ` Simon Marchi
2020-07-23 19:35 ` [PATCH v4 0/3] arc: Add GNU/Linux support Shahab Vahedi
2020-07-23 19:35 ` [PATCH v4 1/3] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-07-30 23:34 ` Simon Marchi
2020-07-23 19:35 ` [PATCH v4 2/3] arc: Add hardware loop detection Shahab Vahedi
2020-08-01 14:53 ` Simon Marchi [this message]
2020-07-23 19:35 ` [PATCH v4 3/3] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-08-01 15:01 ` Simon Marchi
2020-08-01 23:31 ` [PATCH v4 0/3] arc: Add GNU/Linux support Simon Marchi
2020-08-04 7:59 ` Shahab Vahedi
2020-08-04 12:42 ` Simon Marchi
2020-08-04 8:57 ` [PATCH v5 0/4] " Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 1/4] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-08-04 13:08 ` Simon Marchi
2020-08-04 13:18 ` Shahab Vahedi
2020-08-04 13:20 ` Simon Marchi
2020-08-04 14:12 ` Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 2/4] arc: Add inclusion of "gdbarch.h" in "arc-tdep.h" Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 3/4] arc: Add hardware loop detection Shahab Vahedi
2020-08-04 14:28 ` Eli Zaretskii
2020-08-04 16:17 ` Shahab Vahedi
2020-08-04 16:42 ` Eli Zaretskii
2020-08-04 18:15 ` Shahab Vahedi
2020-08-04 8:57 ` [PATCH v5 4/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-08-04 12:49 ` [PATCH v5 0/4] arc: Add GNU/Linux support Simon Marchi
2020-08-04 13:05 ` Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 " Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 1/4] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-08-05 14:31 ` Eli Zaretskii
2020-08-21 16:16 ` Simon Marchi
2020-08-24 20:14 ` Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 2/4] arc: Add inclusion of "gdbarch.h" in "arc-tdep.h" Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 3/4] arc: Add hardware loop detection Shahab Vahedi
2020-08-05 11:09 ` [PATCH v6 4/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
2020-08-17 8:07 ` [PATCH v6 0/4] arc: Add GNU/Linux support Shahab Vahedi
2020-08-17 14:12 ` Eli Zaretskii
2020-08-25 15:47 ` [PUSHED " Shahab Vahedi
2020-08-25 15:47 ` [PUSHED 1/4] arc: Add ARCv2 XML target along with refactoring Shahab Vahedi
2020-08-25 16:00 ` Eli Zaretskii
2020-08-25 15:47 ` [PUSHED 2/4] arc: Add inclusion of "gdbarch.h" in "arc-tdep.h" Shahab Vahedi
2020-08-25 15:47 ` [PUSHED 3/4] arc: Add hardware loop detection Shahab Vahedi
2020-08-25 15:58 ` Eli Zaretskii
2020-08-25 15:47 ` [PUSHED 4/4] arc: Add GNU/Linux support for ARC Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f7c4518-ef40-4ff0-d7c2-05bc6463a926@simark.ca \
--to=simark@simark.ca \
--cc=anton.kolesov@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).