From: Pedro Alves <palves@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't include *sol2-tdep.o on Linux/sparc*
Date: Thu, 25 Jun 2020 10:57:50 +0100 [thread overview]
Message-ID: <7faf3651-4d93-8609-ddfc-51f2359a822b@redhat.com> (raw)
In-Reply-To: <ydda70ro8pe.fsf_-_@CeBiTec.Uni-Bielefeld.DE>
On 6/25/20 9:23 AM, Rainer Orth wrote:
>> From a quick check, this should just work today: the functions declared
>> in sparc*-sol2-tdep.c are only called in Solaris-specific files already.
>> I'll give it a try separately. sparc{32,64}_sol2_init_abi are currently
>> declared in common files (sparc*-tdep.h), but they can just be made
>> static and the declarations removed.
> the following patch does just that: tested on sparc64-unknown-linux-gnu
> (build only due to PR tdep/26170) and sparcv9-sun-solaris2.11.
I got curious and looked into git history to find why that was done
in the first place.
'git blame configure.tgt' points at a4ce5b0d0204 as the commit that
converted the old .mt files into configure.tgt.
And then:
$ git blame a4ce5b0d0204^ -- ./config/sparc/linux64.mt
points at:
commit 691342f948aa4f8c4f4e039669276faf753a36b4
Author: David S. Miller <davem@redhat.com>
AuthorDate: Mon Feb 27 06:14:51 2006 +0000
2006-02-26 David S. Miller <davem@sunset.davemloft.net>
* config/sparc/linux.mt (TDEPFILES): Add sol2-tdep.o.
* config/sparc/linux64.mt (TDEPFILES): Likewise.
Which is... drumroll... a big nothingburger:
https://sourceware.org/legacy-ml/gdb-patches/2006-02/msg00492.html
So, nothing to see here, move along. :-)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-06-25 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 13:15 [RFC][PATCH] Move common handlers to sol2_init_abi Rainer Orth
2020-06-24 10:27 ` Rainer Orth
2020-06-24 14:56 ` Simon Marchi
2020-06-24 20:57 ` Rainer Orth
2020-06-25 8:23 ` [PATCH] Don't include *sol2-tdep.o on Linux/sparc* Rainer Orth
2020-06-25 9:57 ` Pedro Alves [this message]
2020-06-25 12:03 ` Rainer Orth
2020-06-25 8:26 ` [PATCH] Remove obsolete gdbarch_static_transform_name Rainer Orth
2020-06-25 9:18 ` Pedro Alves
2020-06-25 12:07 ` Rainer Orth
2020-06-25 15:20 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7faf3651-4d93-8609-ddfc-51f2359a822b@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).