From: Tom de Vries <tdevries@suse.de>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Add gdb.arch/ppc64-break-on-_exit.exp
Date: Thu, 11 Nov 2021 10:51:38 +0100 [thread overview]
Message-ID: <7fbada3f-4fe8-9c7b-b16c-790b869ee45a@suse.de> (raw)
In-Reply-To: <20211110165007.18f4fd61@f35-m3>
On 11/11/21 12:50 AM, Kevin Buettner wrote:
> On Wed, 10 Nov 2021 11:57:27 +0100
> Tom de Vries <tdevries@suse.de> wrote:
>
>>> I think your new test is okay, though (of course) it would have been
>>> nice to have a test which doesn't depend on particular OS instances.
>>
>> Well, how about this one? Does it reproduce for you, also in source
>> file mode ("if { 1 }" -> "if { 0 }" in the case-case) ?
>
> I tried it both ways, using C source, and also using assembler on
> two different versions of ppc64le Fedora, Fedora 35 and Fedora 32.
>
> Testing showed one pass for each of the runs when using builds against
> recent upstream sources (w/ your fix). When tested against the
> installed GDB (which does not have your recent ppc related fix), the
> tests correctly showed 1 failure per run.
>
> I like this test better!
Nice :)
Thanks for the testing.
I also managed to find the usual recipe for switching between assembler
and compiled version: "if [info exists COMPILE] ". I've updated the
patch accordingly, and committed.
Thanks
- Tom
next prev parent reply other threads:[~2021-11-11 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 19:24 [PATCH][gdb/testsuite] Work around skip_prologue problems in gdb.threads/process-dies-while-detaching.exp Tom de Vries
2021-11-02 11:38 ` Tom de Vries
2021-11-02 17:13 ` Kevin Buettner
2021-11-04 11:20 ` [PATCH][gdb/testsuite] Add gdb.opt/break-on-_exit.exp Tom de Vries
2021-11-09 16:35 ` Kevin Buettner
2021-11-09 16:58 ` Tom de Vries
2021-11-09 17:29 ` Kevin Buettner
2021-11-10 10:57 ` [PATCH][gdb/testsuite] Add gdb.arch/ppc64-break-on-_exit.exp Tom de Vries
2021-11-10 23:50 ` Kevin Buettner
2021-11-11 9:51 ` Tom de Vries [this message]
2021-11-10 11:56 ` [PATCH][gdb/testsuite] Add gdb.opt/break-on-_exit.exp Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fbada3f-4fe8-9c7b-b16c-790b869ee45a@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).