From: John Baldwin <jhb@FreeBSD.org>
To: Joubert Nel <joubert@joubster.com>, Tom Tromey <tom@tromey.com>,
Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Feedback sought: patch to enable gdb to build on macOS Mojave
Date: Wed, 20 Feb 2019 16:49:00 -0000 [thread overview]
Message-ID: <7ff6bf6d-1d02-6e87-e734-2f6177efcc9e@FreeBSD.org> (raw)
In-Reply-To: <FEDACE7A-EF8D-44DD-A665-1B0CCEF9E08D@joubster.com>
On 2/19/19 10:50 PM, Joubert Nel wrote:
> Great.
>
> I read the contribution checklist and I think those are all great guidelines.
>
> Before I prepare a formal submission email, it would be helpful to hear whether the actual code differences seem acceptable: https://gist.github.com/joubertnel/267ca0fff4eaad494cc19ec3ba7953ed
Especially for a patch that small it is easier to review it inline.
I think the first hunk is fine.
The second one probably isn't the right fix. The earlier 'res' is an
'int' for the return value from darwin_decode_notify_message. The
later one is a pid_t for the return value from wait4. I would perhaps
rename the second 'res' to 'wpid' instead of using the int.
For the third one it looks like you can just remove the line entirely.
priv is already set to 'get_darwin_inferior (inf)' at the start of the
function, so that assignment is redundant.
--
John Baldwin
                                                                           Â
next prev parent reply other threads:[~2019-02-20 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 17:41 Joubert Nel
2019-02-18 20:38 ` Kevin Buettner
2019-02-18 22:47 ` Tom Tromey
2019-02-20 6:50 ` Joubert Nel
2019-02-20 16:49 ` John Baldwin [this message]
2019-02-23 23:14 ` Joubert Nel
2019-02-25 22:41 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff6bf6d-1d02-6e87-e734-2f6177efcc9e@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=joubert@joubster.com \
--cc=kevinb@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).