From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 81425385840D for ; Wed, 24 Apr 2024 18:29:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81425385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81425385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713983343; cv=none; b=TgefMCRWUmDxoXIzy36Rj5ORY3BD/17Tc+LX6piMyyeJUhpgBn0mI7cwqbAPdDleU+jhtY4V9ZuyoJxASFZ3KShqO9mTDSG/69LwPiqXpAYU8n5fYJhDOGNzzUvN9qH6e3CS3wGKS9qqNbQNUb+mujVkE364fhlZkXAxQwcvabA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713983343; c=relaxed/simple; bh=q5lAGZlxuLCedQHLDJmO5DdKMDmZqRMf574ttMgsikk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jW+bTikiYQegBrzoUoPczU6a+SQnsyM/hpUCTLM4fj03scq4+folbUhsb35wjkeRJ6omtA0hdJ4EzzOCPDgV7koCK3Gr9vDFNognYJbrNjKnIIdJTnzRMuknH/0yhgkb9PatskGHcogrL3KT9ejtFMvp9h0ynmG/324jg4BV28M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43OICQqH005156; Wed, 24 Apr 2024 18:29:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=MVhhHT5c8gpNNMpl57LIIWKAJvNyAbxYgRKqDavcFz0=; b=j2H3vyqXdWPOdRtOfyP354cKewcBLT0DT6nMR1CoCWQgLzATgcTD7AKX5wCawaOPBBuN bWffd3nU3VIpk94/SuomMrW10Btm8wQJBXfNr4t5JNnEbHQavYcaCXasUQrujlkASMSR pnifLSlRMCiccEx7ETcWM4sge47bGuc0MWJRx85NXGI1wCdKVI4wC9RtGlMxhhUxuMyr Lr3S9K/nEH8zuy6jptgq5qGal3aEXkiUXAGQzf/YbCwsHZepHfCWiXcXKT3Ww2q8GBdf /vcFwtdi4F+8884hcNyk2mwfn+DVDFUzIyUPTWutqquyJNPSQ62N1POIVZ/kR5A7NFMc Hg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xq75881t4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 18:29:00 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43OGGHgQ005355; Wed, 24 Apr 2024 18:28:59 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xmx3cm1kn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 18:28:59 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43OISuL630605730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2024 18:28:58 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 43BA95805F; Wed, 24 Apr 2024 18:28:56 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC46B58056; Wed, 24 Apr 2024 18:28:55 +0000 (GMT) Received: from [9.67.133.93] (unknown [9.67.133.93]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 24 Apr 2024 18:28:55 +0000 (GMT) Message-ID: <8032f800-235f-4181-a84e-2f2fb2a086b7@linux.ibm.com> Date: Wed, 24 Apr 2024 11:28:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] [gdb/testsuite] Fix end_sequence addresses Content-Language: en-US To: gdb-patches@sourceware.org, Tom de Vries , Carl Love References: <20240408120445.12544-1-tdevries@suse.de> <20240408120445.12544-3-tdevries@suse.de> <7d515dd6-f327-4587-89c6-ed7e93b7efdd@linux.ibm.com> From: Carl Love In-Reply-To: <7d515dd6-f327-4587-89c6-ed7e93b7efdd@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: NNyCCQbQpcxtMRtIziMZbYFbCcAa6SId X-Proofpoint-ORIG-GUID: NNyCCQbQpcxtMRtIziMZbYFbCcAa6SId X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-24_15,2024-04-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 impostorscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404240085 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom: The following patch fixes the issue for me on PowerPC. Please let me know if it looks ok and if the patch works on your systems as well. Thanks. Carl ---------------------------------------------------------------------- Fix end_sequence addresses for dw2-lines.exp The patch: From f0d556d14b1d1c3f8e2f9c13b08adca22e1b8c9c Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 17 Apr 2024 12:55:00 +0200 Subject: [PATCH] [gdb/testsuite] Fix end_sequence addresses I noticed in test-case gdb.reverse/map-to-same-line.exp, that the end of main: ... 00000000004102c4 : 4102c4: 52800000 mov w0, #0x0 // #0 4102c8: 9100c3ff add sp, sp, #0x30 4102cc: d65f03c0 ret ... is not described by the line table: ... File name Line number Starting address View Stmt ... map-to-same-line.c 54 0x4102ac x map-to-same-line.c - 0x4102c4 ... Fix this by ending the line table at $main_end. Likewise in a few other test-cases, found using: ... $ find gdb/testsuite/ -type f \ | xargs grep -B1 DW_LNE_end_sequence \ | grep set_address \ | egrep -v "_end|_len" ... Tested on aarch64-linux. --- gdb/testsuite/gdb.dwarf2/dw2-gas-workaround.exp | 2 +- gdb/testsuite/gdb.dwarf2/dw2-inline-header-1.exp | 2 +- gdb/testsuite/gdb.dwarf2/dw2-inline-header-2.exp | 2 +- gdb/testsuite/gdb.dwarf2/dw2-inline-header-3.exp | 2 +- gdb/testsuite/gdb.dwarf2/dw2-line-number-zero.exp | 7 +++++-- gdb/testsuite/gdb.dwarf2/dw2-lines.exp | 2 +- gdb/testsuite/gdb.dwarf2/dw2-vendor-extended-opcode.exp | 4 +++- gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp.tcl | 2 +- gdb/testsuite/gdb.reverse/map-to-same-line.c | 1 - gdb/testsuite/gdb.reverse/map-to-same-line.exp | 3 ++- 10 files changed, 16 insertions(+), 11 deletions(-) The issue in file dw2-lines.exp is the change - DW_LNE_set_address bar_label_5 + DW_LNE_set_address "$main_start + $main_len" The label bar_label_5 is in function bar, not function main. The new set address should have been $bar_start + $bar_len. --- gdb/testsuite/gdb.dwarf2/dw2-lines.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp index 85d5e9c8afb..af5b6b71768 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp @@ -104,7 +104,7 @@ proc test_1 { _cv _cdw64 _lv _ldw64 {_string_form ""}} { line [line_for bar_label_4] DW_LNS_copy - DW_LNE_set_address "$main_start + $main_len" + DW_LNE_set_address "$bar_start + $bar_len" DW_LNE_end_sequence } } -- 2.44.0