From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34451 invoked by alias); 3 Oct 2018 17:33:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30506 invoked by uid 89); 3 Oct 2018 17:33:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=whoever X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 17:33:07 +0000 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 166A2A8BB; Wed, 3 Oct 2018 17:33:06 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 759CB9D8A1; Wed, 3 Oct 2018 17:33:05 +0000 (UTC) Subject: Re: [PATCH v2 03/10] Use unsigned as base type for some enums To: Tom Tromey , gdb-patches@sourceware.org References: <20181002044420.17628-1-tom@tromey.com> <20181002044420.17628-4-tom@tromey.com> From: Pedro Alves Message-ID: <8037ff67-25db-de97-f64c-8f9b24f38778@redhat.com> Date: Wed, 03 Oct 2018 17:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181002044420.17628-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00079.txt.bz2 On 10/02/2018 05:44 AM, Tom Tromey wrote: > -fsanitize=undefined complains about using operator~ on various enum > types that are used with DEF_ENUM_FLAGS_TYPE. This patch fixes these > problems by explicitly setting the base type for these enums to > unsigned. It also adds a static assert to enum_flags to ensure that > future enums used this way have an unsigned underlying type. > > gdb/ChangeLog This LGTM, except a nit. During the discussion around v1, the conclusion was that we can't add the assertion to the class, but adding it to operator~ would work. That information is lost on whoever ends up reading this code later on. Could you add a comment? Or if you prefer, update the commit log to mention it? > enum_flags operator~ () const > { > + gdb_static_assert (std::is_unsigned::value); > return (enum_type) ~underlying_value (); > } Thanks, Pedro Alves