From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90868 invoked by alias); 1 Nov 2018 19:44:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90855 invoked by uid 89); 1 Nov 2018 19:44:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:e334bc9, nit, H*f:sk:87efc7n, H*f:sk:875zxin X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Nov 2018 19:44:54 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wA1Jim23008077 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 1 Nov 2018 15:44:52 -0400 Received: by simark.ca (Postfix, from userid 112) id F3A321EABA; Thu, 1 Nov 2018 15:44:47 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 29D341E93F; Thu, 1 Nov 2018 15:44:45 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 01 Nov 2018 19:44:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c In-Reply-To: <875zxinoo9.fsf@tromey.com> References: <20181018223100.20693-1-tom@tromey.com> <20181018223100.20693-4-tom@tromey.com> <6a239617-b748-0a9f-185b-2adcb19c50bc@ericsson.com> <87efc7nohb.fsf@tromey.com> <875zxinoo9.fsf@tromey.com> Message-ID: <8058a0ece13c51beacf25fd4dc6a73f4@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00005.txt.bz2 On 2018-10-31 11:03, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> It would be normal to look at TMPDIR on unix systems. > > Simon> Ah, indeed. How is it with this little fixup on top of the > patch? > > Seems reasonable, thanks! > > Simon> + char *tmp = getenv ("TMPDIR"); > > A tiny nit: you can use const char * here. > > Tom Pushed with that fixed, thanks! Simon