From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by sourceware.org (Postfix) with ESMTPS id AEE83393A41B for ; Wed, 12 Jan 2022 10:23:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AEE83393A41B ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D+qL3x+fy1P2M2d/asaNvzKTbe/x7CgZjKfXh6NPGOi1RFs74+ni7jDHg0ZEZrEjbrTutQnKsSL6BMqdm0pcYGrboLvEVPABMMVkqo9giRRrdrWLPgTVrtps6PyLn5p9rislDftjcCXJFOzfr3kSdZpUNiZK4dUjQRNSj91XwCyYvFSfVxlXBdts+nN0Jtakc1S3Bw7F/5BleHUZx/+TNKGf1S0SFhhiPBOrppDWKymqqAhff+orFJxwEA0Tt8DKW9Ay433TTuoVULKNuHN2zoh071+lWueuLH0GWZpj3hLxsjhWTtKd0IcXDcdf8Xql6ov0uFB2eBdLUfnkdygCNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAlXTbCYiinDhTeedWiJjMz9Oytu0pKMYnCP01e1PDw=; b=W4YvqTfQEK1A9VqS6B788J66l9NRo2n+vOxzjw9IeIYViVMxsEdm6AJ4Cj5G4yIGtxZsc8LXLjYNaesW1XJNtvI/ydAA0XbyYsaysPULd+07Hr+2Tg4Ob/e4Q2nQES7BvltKQyKYmPdZyS+rV9PKpX2V9LzLz+fmHwmynmSFGu1CSdQ2254arj0KQzqIXG85IyPBNw5oN04KjYK37yzhbucj887kZL/P7yTqoDkBMGUTQ3LOHrNxKoej0Msd3d17S+gahuf7d9lqttEpQIoUnn1tRA58nxbAC/uRIh0c2ZEYs7BkXVnMO/usF3uzEawzBNhFMiAGguS5IkGG2BzcMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5209.namprd12.prod.outlook.com (2603:10b6:408:11a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Wed, 12 Jan 2022 10:23:32 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::8a:f482:ebd8:3135]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::8a:f482:ebd8:3135%5]) with mapi id 15.20.4867.011; Wed, 12 Jan 2022 10:23:32 +0000 Subject: Re: [PATCH v4 03/28] Add new classes that model DWARF stack element To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20211105113849.118800-1-zoran.zaric@amd.com> <20211105113849.118800-4-zoran.zaric@amd.com> <87y24myjt2.fsf@tromey.com> From: Zoran Zaric Message-ID: <806fd253-23c0-0821-ff90-2e921faf9ecb@amd.com> Date: Wed, 12 Jan 2022 10:23:27 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <87y24myjt2.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0010.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::15) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87b7e3a8-fb8d-4f95-4244-08d9d5b59562 X-MS-TrafficTypeDiagnostic: BN9PR12MB5209:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PUSFAcSwSNnisRQiFY16K4o9uMuHpFL+vETmaYiPkuvDp5h66bgvjTlUUHi/SYt+ZAAJABXnkOOe4cSx9/gjY89AZi2n9rHXl6aQWROp3lZMrun9314IhF1OcnvoIaGA6LoYVhjw7W2ID7N0O13KIwlWEmuEIZ41XD/qiR4lJgHq/JEoPijGoUcTnMOf8KzTf/Lneh2ml9utCX1sbULwFS2quO4xRENIZDBV83neth4djd9z7zLOFe3EXvS8ZEjiVpZkRXub66b3/jDAv47lGMsKMrMR3KRSz7Za+B8fPti+QgqEi0MpuflG4XHKGS2gTjjnn1zR8SedjP1ISSTetmMc35Sf/hbZKj8HoEGg8sfZL0+809cZYt+RRvGtabe6S9BojzYK0Q4S0/d+WmPyAsAqb4IG7boFBi0kZS+pR+UZa6s61lkp2OQkI0okjIyoDDYasc2tOZmCBvJVXKW0eWU0obTMNDmXXvY65SWoYO4axFz8Giexl1D1TaknXFaUe4W4jbBFCwioad4KjmH4GHJ3VRV9T+w076K6i/TKcKzgNn8Ln8gUS40rMD7VG5y4kaGDfgKt60drQZkPaZW1Q9m9eTyRI/ohr8ZdNwbLzqcZ+xYW+zq5Z5Nk+cd///ZJD1bntOi1sspOWYRl5v840u98uU+Dl5BYe8X/cn3iXStQcnzDa0IYWo2EEhC1D7tP1rkWFt0nFVe561E0995ib8NRQEX7wUCvZlD1oPl6u5k3iHMIZ0wtxpwS3Ldo5pG9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4744005)(6506007)(6512007)(186003)(8676002)(6486002)(31696002)(31686004)(508600001)(8936002)(38100700002)(5660300002)(66946007)(110136005)(66556008)(66476007)(6666004)(2906002)(2616005)(44832011)(316002)(86362001)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VStpa1ZPUUozWWVCbnBYcVN4QjUrRXhJR3pQOE13NEhBZWs1ZEV2RjlhTmQv?= =?utf-8?B?WThlaFVhNkVWV3VSekh1LzEzK1ppYkZ2QS9rZ05VdWFYZHhPeHVVNSsweTlr?= =?utf-8?B?b3FnZDlualF0V0pFMjJlcDhVRnh4TGZmWWhmM1AxWVVybEVYNzl1dTZJQnhZ?= =?utf-8?B?Y1NWVFh1bDJndFd6aUk3RktMMWtiSlVZbEVJRHNHeFoyeXR0V0Z2UjJzcWo1?= =?utf-8?B?NG9TN0w5ci9EZFVxSDJCOUcwUFdnRlZLQ0U1amQrL3dkVUtKQ3pLcHZpN05L?= =?utf-8?B?UDMxUjF5bzVWR0tINUhwRzVaeDljcVBoVHdZSFpKMGVpZVRUT0Q3cGVJM0JB?= =?utf-8?B?dTZVSHZ0aE9YcnBhTkdkKy9FSjIwZTVyQnYvUnR5TVVpcE5vT0QzYndHOE5Z?= =?utf-8?B?RnVmclJEamIzZ2Q2Zi9CR0JPdE1pamNDc05BbWxqN1dTNmJlT1FSZVpKRjgr?= =?utf-8?B?ZHp1Tnk0cE5lcnloS01iUVF4cFBPNVpFc2xkV1ZrVnRaMU1xUEp3R3FvTkpo?= =?utf-8?B?eURRSDhPREZmWXZySFR2Q0ZLeGJPWW0yamc1cTZKYnZpa2IxaFliZWZJUnJP?= =?utf-8?B?dW5sVkhRTHVqVkJRZzFuTDZXaktTTlo5OE85MkppeTh2Si9Wc3k1UWtKN0ov?= =?utf-8?B?UUF5Q0lZRjVMSjdUdkVJZHgySUI3OW9YclpPbjdSMGVhV21VRUFwK0RJQ3pp?= =?utf-8?B?S2pjcXhzeTBVU29lZ2FaUkM1bFQ1OFRmL25qaFY1U3RrU0hOQ0VIcDc1YXZw?= =?utf-8?B?R2o1YkhmMXErZW9DbXA0VGV4L1Z2bit0Nlk2c2NFeHNmcjdRYVBVRGdEeXdR?= =?utf-8?B?TnJlLzJReHVJemhNY3llcWViUDlJK040WUhNWU5sU2xwQlU1R0FMQXgzUnF3?= =?utf-8?B?M01rT2IzdUpaYVlhTEY2Tml6eVpNa2FlUDk3bkVXRGNtQmg1eHdPQ2FQZWVG?= =?utf-8?B?YnJUVlo0MU8yendtU0VFd1VCaTR1dWxaeTkxTGpLRDQzbXVTaHJqczBBd21x?= =?utf-8?B?MHpmN0NXekJPRWl2WVY5TTlWRm5SMGxXMVM1b3loQ1JMM2xpTXd6bE1nUTN1?= =?utf-8?B?bXEraGNqOFpsVmNraHpaUlF2R0pWekk5cDdsbmF2Y3l1aEJCUnZkbTFZODNR?= =?utf-8?B?R0JvYndkcmZjaFcxYjNwZzRYVGNCanZOUnhNOGx6Umd5aXB6VDN4UXBwSUt3?= =?utf-8?B?NXVjNDcwdzJQNGNZM0tmMFR2UHBwU3BlUnFqTEcrQmxaVTgwazRVZ0pndUVn?= =?utf-8?B?dkVrV1lYUGNuMGY2NXk4WGZxMXBVbGttZ0FQNVZJTHo4VDlQNFdGZVlRaVN5?= =?utf-8?B?NG5pbGVXMit2SEIyTEJENTYyY2dxZENVVHVPQ2hRRHFmYzB2QzR0WlRpejBz?= =?utf-8?B?NFNtNTIyS2dlbGp4M21KM1J6alRsOEFvdlMxMFpOOSt3aUFMeE1jM1UrODYx?= =?utf-8?B?bjQvMmFUeUJyQXhjQ2U1NHUzM1RrUzRJUldackc2WE1taXVacFZ2UHJTSkt6?= =?utf-8?B?b004NjBQbXpORWdHSkhwMTdVVFdIejF0am1PV2hwdVFaTTZxRHJBQjc5d3Jp?= =?utf-8?B?RER4dFJCWlpvRmRBZUNqV0pwYzRmMzdsbERiZVM2U3Z2Rm1XNzJ3TUZFK3BO?= =?utf-8?B?MFVmVlp4NHQwdm1PK013NEt0UVZlZUFEdDhvM01iWEtsenpUVjY3UFg0TlVo?= =?utf-8?B?cjlKOXFucHVqcFlqMnp3eWZuNWoyRFJBeEV1YkRMNUJFcU82WHltVEtRWE5t?= =?utf-8?B?VGxncDJ5L2JCcVBrN3dhT0xOTVRSWmxiMndXZWxVRXR0ais0dCtzTzQ0VzJY?= =?utf-8?B?U0V2Mm1YclF2ckdPWFNvNjVuK2J5dzdKaW9rOFZ2VWNySTZIY1FBVTU4ZVkz?= =?utf-8?B?TmE0ajl0dFJHc3lobnBhL0ltUkdOc1hGOHAySzRXUHQ0aWx0SGtVcnliM1N0?= =?utf-8?B?bHZXUWJyQzZWc0VHVEZXVHBCOUlGWG56azFEeG9IL2tYQmNqRlFYM2lFYUZo?= =?utf-8?B?K1NEcklicXZ4QmQ3WWkvY0k3aS9XSkU4b2JFajdpeWtLcm9oeUN4eUxHQzky?= =?utf-8?B?MmNWV0dPRjgrM0l0V3lPdHZNWmtwSUNNeGUxakhwZUdDeHpWNXVBVVY4NkVK?= =?utf-8?B?eVdhblBoS3RHbWxGSU80NlZUZkNlSjNIZ2RQbXRJd1VJcmZqQjZ5RUtHQ3lM?= =?utf-8?B?bHFGcllzSGRQVENsdUZCYXUyL0hhUUJ4YXFWTmJWck0wc0xpTEk2NHpxT0JT?= =?utf-8?Q?GWHDOiVAuM8O6ojSk8vSk3hogDrhaZS+zMUzlizp1s=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87b7e3a8-fb8d-4f95-4244-08d9d5b59562 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2022 10:23:32.3707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5HuFgrQq2CRA2eNnRD4eSxb4HsmuSaZGGYTupuhuw0ZidHMMyaUtfQkrkCf6Vl8GnHReg4FC9rljRLhuYaKCug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5209 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 10:23:38 -0000 Thank you for reviewing the patch series Tom. > > Zoran> + Types of locations descirbed can be: register location, memory > > Typo, "described". > > Zoran> + > Zoran> +class dwarf_memory final : public dwarf_location > > This one needs a comment. > > Otherwise this patch looks ok to me. > > Tom > This will be fixed in the next iteration. Zoran