From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2053.outbound.protection.outlook.com [40.107.244.53]) by sourceware.org (Postfix) with ESMTPS id B124C3831ED9 for ; Thu, 26 May 2022 20:42:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B124C3831ED9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D7koH4mj001Ex4ksv9NE179I1LILygA7OVwysHQIcj1DD8htv1ZIlYQMxEmJpd8T93EISVQ71rirHaHilNN9OV4HcT08to8IUQZcxcGGz5M21A3Eq27REIWjd9O0ur3LI/18A/O11hGCOXHD1cPyCWKJ0yjZr851/FWTh0SdVB/wXslzQbQ2ND0oBYy44PYBpt4wshR3+0Yi9N9XYSUBB2QsTwsGVy6gA7U1rtkCUqc1dFGTpJ9Dgx/8aV78xXWF9yNdhibAPA82tbn7baAZbgDmK0+XYrz8GlVp2Wve8Tf5GIK4nhUrCQbouu6mZiDUwV8F3pLH2S0MvakKOFyOog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XAV0q4gl8rfuuhABJyL/6rcpGbEpTLC9LcoxZ/L3O+8=; b=ORCQ2MEWKHZARc7hfXfRfh4xRDHfTpkYh1dKwSbi1pmC6ULiVbmf9PDqGxSgzdCIMGHIdP9HHZbUgHDxJC2kTgImDzDwzy0DDNIEWRe9uXAY12DMyys+Pbg1qOT8FKzfulIl6Am6UpxYFLJ1DIgZNnsECt8uE22JTnl2ZEsW3lro/SnYaWGcTweLQJ6OLclgLH7hniX7Zd8EWQ5TotI/xzVuRX1SDZ4wRojWIpJMDmoP7KqvE4G4yQjk9hp+k6TIzHvOyMfEgeMTKeXcuRaxOWhF8XPV6ngztwQ50vva/VjOjoVxTamXLcnBk4d4WUxDDVvoDcE0R+cmQxb4AWs9BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by DM5PR1201MB0220.namprd12.prod.outlook.com (2603:10b6:4:4e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 20:42:07 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::e032:96b9:c743:3a9b]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::e032:96b9:c743:3a9b%9]) with mapi id 15.20.5293.013; Thu, 26 May 2022 20:42:07 +0000 Message-ID: <80766d16-9003-ff3c-756c-432c4d512e79@amd.com> Date: Thu, 26 May 2022 21:42:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 2/2] gdb: Change psymbol_functions::require_partial_symbols to partial_symbols Content-Language: en-US To: Tom Tromey , Lancelot SIX via Gdb-patches Cc: simark@simark.ca, lsix@lancelotsix.com References: <20220520225530.372343-1-lancelot.six@amd.com> <87a6b46utm.fsf@tromey.com> From: Lancelot SIX In-Reply-To: <87a6b46utm.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR10CA0077.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::18) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d2ecc0b3-5329-4b10-bc85-08da3f5832ba X-MS-TrafficTypeDiagnostic: DM5PR1201MB0220:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D/K2QXrKi6tCvrTcdLGV2cpfrwIECPTQVj/8imsCRRE1hYQ/OmY72yNQFFjCQ3r5CDei6+4rSczE1DVO2oUZqMPK3KEZSvn6Cw0sq13tuNZnk1g1Nwfwf/4sSOTwU6CdG+98mYmmJOehQWODRn1nPzx77WgybdVb3j3AAc00ygkCvNR2Kue04Ii0zX07Kdqm9LIYQSUXKLjwYkfNYfTgF2ml+oa2NWOoXf+LQp/ooP1oj+iSQPfjYLvLRLZ4E6Wk3DEqRoVS/JGjCD4B3BeWXbSi+lXLOqbi/6SQqIjPlq1kcTlKu6YmpmKjDaet/4Ru7x35a1jXEHP6Hmj9wAciuAMnukhYFBxWw/ibbTWr/ygWj6DdKoYMP7QCM0r/bSowr0xVl+RxFYF6Jae2RUx18+JDJvBmBpsz2lGdex77sG+wGxVCQU1GAJFV+9Qt8n1YFqMXFMJq4XChhcwfvmlHE39N/GX9IUlqLcgtv4m8czP3YNxhwgUx4ptvXR8KYqrbYPmdi77oZrok7PgtRRe29+hwSJminFujykr3shRJykBB3+/C+grUwndYLXlTQtNp3jeSU8MRHlyAJdqOD7bGpgYoAhTtOaAdvdoV+tRwmQaLYyI2zk5u5HgeTQlGSUEvLg30812Q9XWXneTmirSXLjNMaKxHc8MjYA3ZQZwZluis014cB32+kbNKirsO4/hA1re7TdEdLMoCokbZngKUYLwYEMtY0RkeXPSimVsZI/0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5745.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2616005)(6666004)(4744005)(5660300002)(2906002)(31686004)(186003)(110136005)(6486002)(6506007)(53546011)(6512007)(83380400001)(8936002)(38100700002)(31696002)(66556008)(86362001)(66946007)(66476007)(4326008)(36756003)(316002)(8676002)(508600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXRQc0xvOXFaZm92UHVKUTJFdzBvOXFBRitLU01ZQVQ2SnVGK1RNNmJwd0ts?= =?utf-8?B?MDR5Ulc0Tm5HNXF1NVd6Z2pQS3U2K200S1NJMUk3S1lWTGZrMzFadUZxU3pn?= =?utf-8?B?UnJGdXFxbDMrSG1XVE13NTViT2hqTitsem5nVVNhOG9zNnE4SUg2TEpZOXc2?= =?utf-8?B?NjdkeEp1cXUwMjhDT1IreFFWWGdpUkllYlR2U2FzTFJMaHoybkJ1dFpGL0ZY?= =?utf-8?B?YjVRazRPcXl2TllkY3cwUUt1T2hHZlR2UDFER21mOHFrUzRWYzZNWlhMWEM2?= =?utf-8?B?RXNtR3FYOWZhdVBGZ1ZFTTNzcThOWVJYbGJQbHFrZUNRcFg3WUNIQXVUdFlP?= =?utf-8?B?K2Mwd0tubnBRc2NpQ1d1VmR1VW1KemdmaVdsNmpQTnJpV3BZWG1ZbGZkekNR?= =?utf-8?B?UmFtamRhcU45RkFtbyt3aG05Um5jS2VQR3hJdnF5VkNYalg1YXFTNkxjdUpl?= =?utf-8?B?SGNLckFkdnJpMzZWeFlzWS9hdnI5ZmRqVllxOUYvbndheUNkZXNrTk9PMFNn?= =?utf-8?B?U0o2RE40anl4b01kZnIwQzhJNGM2Mlk1YTl5U3gvNmJoelpZKzJ1eEhzc2xZ?= =?utf-8?B?cDdBVE9ZdzJtMk1sOW45MWRYUkxRMnFqNlVXSXF6RUdqQW5HWVFsY2paWlBn?= =?utf-8?B?OVhSNHpZbmZuYWI1SnRNWDd2UDNIdWk4MjJBY0tHZWw4bnlIblZpZzJXa2RG?= =?utf-8?B?Qkg0RUQ4UTZYZnZwL0piYXZwcklPbk5GYTIyTkZKek9NY3FqSFlTSE4vR3Zn?= =?utf-8?B?UnZIc09iR1ZSVXJSNEp0U2cvL0lzZG11ME9mMi9aMmxLT2NZWnVjU09XVjMx?= =?utf-8?B?cUZoMEJjamMvTGM1dHkyREs3R2RlWGdMUWdLVXdSQVZTSmptM1ZqSW1PbzNk?= =?utf-8?B?TnYvL1FFSSsxUE95Q2hXajJhWVlDUzJDRjVYSm1rUk9OMzBXclE0OEtaUGs2?= =?utf-8?B?MVJWNXpIenRrY3RvUzJ6NnhLQUFubVlWRHpkRklPZlY5VXdPYy9pUXVYTzVp?= =?utf-8?B?cS8yTGpkL3pITndnTEJDRTc3VEtkamVub0svYkpNMGhmK0NQSlMzM3NYdldS?= =?utf-8?B?c0F0RS91bDhtMlIrWG82YS9LR3o2SFE3bUZNOXFEQ2QwaHJMTFZFWityVVlm?= =?utf-8?B?TEFIYjVYSXE2aUFSeWtHbGNybUo1RFNiUU8zQUpQU2tDSG54UkM3Q2hYZmg3?= =?utf-8?B?SThDTStGejgyT2E4ZTgxWitIUHU1MGxhSnp0UndqLyt4VDdVbzB6SVlrcVc4?= =?utf-8?B?QUs1R1BrSmdEWGZtVHl2YzdRWHdTYmJqcm9vek5ZMVR6SHBUNWZMVHUweGpn?= =?utf-8?B?WmwyMG5JNGgyaCtqaXJZazU2a0dRNk5CLzN6ZGRpSG4wQ3ZpWC9HTlJzQkxq?= =?utf-8?B?dWVDZWhJQWwxL2FDSlFNVDE2TEkzTDlkVWd2VS9Tby9LRnE0RiszL3p1SGty?= =?utf-8?B?U1ExOW40cWZxYjloc01uNHNCZURlYUJmZVNxUWltL0FYVXJJcFcvcE1ZSGNu?= =?utf-8?B?U2xsakQyU2VOSlJCWTA1b0o3VHVEelRkTmVlUG01WjFoNXpXY2hITTZGNVI1?= =?utf-8?B?YU9IcHBtRWc2NEFFU3cyVGFqRnY1WXVicTlSSmd0ZTM0d0hCYmROM3RqQ1o5?= =?utf-8?B?Q3lRL0ppMW5RczRpZXJTZ1F5akovczhNYysvZW5aZXJiaTJMU3pCRjJ2RUY5?= =?utf-8?B?QXh3OG5qQXRFZFRZNGFqbXJ4eis0d1RoODk1NEtwaGhSVHlYbUZtQ05lT0JB?= =?utf-8?B?VlB0UHdONktQcm5iZG5mU0V3NXNaUEgyVDlkQXF2UjBITDhOaEVzQnlqTWdO?= =?utf-8?B?R2o1anJwME9lc25KemdrN1Q1MmNDVENLSFgzSmFxM2dqZ1FrR08rcDErRGpx?= =?utf-8?B?OUFTL3NOVjNWaHFoSUhVdFpKbGNBMXAyckVsMEdSR0szN3NJVTZKTVFmUjE3?= =?utf-8?B?bnVZd3VQN3FLOWtoU1VqYnBuOWVKTDlYMmRWQkt2TmtyVU5nWERna2RMSXR5?= =?utf-8?B?ZHJ2VHFUQnJ4YXFpYTlUTWRIYXZaSjd3TnFHNjdycE54ZjBkcExuSlNtSXZY?= =?utf-8?B?U1hOb0xpSEZqbjJHTjBGSnJFU0M3c1BZNzNNQ0x1blA0bzZNOE03bVNPVnR5?= =?utf-8?B?NFNXN2dJN0dnSTY0YVR5K0dFc29Db1pxbkt3amtjWVBWLzlNUUIxVXlhVVdL?= =?utf-8?B?b3l5a3lDMlN0YXl5eVo5aGdWZkpuaUtnVDF1VGd5VG53QitSQ1ZpV2MveU5D?= =?utf-8?B?UXRoUDN6aWc1bzJWdm04c3BwMWtqOXd0RlV5ZlpONFBiYVcrTUdhclQzTzVX?= =?utf-8?B?MldRdkE5U0JPQ3pqRjhJYlhHNzB3cUZ0U0JTUzd1SHJrcDNkK2pGa1Nkd2RJ?= =?utf-8?Q?uyUq7EM9Q25UsDv8tJUAG7gZZFZ4IUzLu4aSym5eFVg43?= X-MS-Exchange-AntiSpam-MessageData-1: kDEDylRgT/LpRw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2ecc0b3-5329-4b10-bc85-08da3f5832ba X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 20:42:07.0397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wWFF3JFXLgGlcomym88Pt+a7KVZIMOuMw0u6OJlE6KDz2X37dq/FNuZPdVzpi0n7QrwjiridqpuUkp0FgrTCwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0220 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 20:42:12 -0000 Hi, Thanks. I just pushed the 2 patches. Best, Lancelot. On 26/05/2022 18:57, Tom Tromey wrote: > [CAUTION: External Email] > >>>>>> "Lancelot" == Lancelot SIX via Gdb-patches writes: > > Lancelot> Here is an updated (V3) version of the last patch of the series which > Lancelot> renames require_partial_symbols into partial_symbols and updates the > Lancelot> relevant comments. > > FWIW this looks good to me. > > Tom