From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50920 invoked by alias); 20 Oct 2016 21:56:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50895 invoked by uid 89); 20 Oct 2016 21:56:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:304 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 21:56:11 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3BEC8624CD; Thu, 20 Oct 2016 21:56:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9KLu8oD022229; Thu, 20 Oct 2016 17:56:09 -0400 Subject: Re: [RFA v2 16/17] Convert dwarf_expr_context_funcs to methods To: Tom Tromey References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-17-git-send-email-tom@tromey.com> <94f5892b-e4d2-f903-36e2-513e37f3947b@redhat.com> <878ttmid6e.fsf@tromey.com> <87a8dyhetz.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <809be0c1-b118-d785-f82e-24bc40f31970@redhat.com> Date: Thu, 20 Oct 2016 21:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87a8dyhetz.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00629.txt.bz2 On 10/20/2016 10:48 PM, Tom Tromey wrote: > Pedro> Should we remove the parens throughout? > > Tom> I made this change. > > Here's the updated version of this patch. > It also fixes some "CTX" comments. Thanks! This is OK. -- Pedro Alves