From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id A0D3E385B835 for ; Thu, 16 Apr 2020 21:34:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A0D3E385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1587072845; bh=2xQ+lryYraK2KX9ztUHHKsXROGQy3q/NGbU153BkTCA=; h=X-UI-Sender-Class:To:Cc:References:From:Subject:Date:In-Reply-To; b=ADx6rhEwn5aYvDMdrm61XFew0fXYKwvbMzdXO1VU9bqWm9NIFQyv/tWGahbO2sXDU 252dXMoqtzh3u4hKSY67HNOlogn4M/D/IRypLCqFjuI7JIoaKmfUe7nTrIT3x2EonB DnwTmHFJxDZ0SrHL0+f0uqacra9M3qr+kGEgeJJ0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MYeMt-1jlzw60ceh-00Vi97; Thu, 16 Apr 2020 23:34:05 +0200 To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200416165859.10785-1-n54@gmx.com> <877dyf19fw.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat Message-ID: <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> Date: Thu, 16 Apr 2020 23:32:40 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <877dyf19fw.fsf@tromey.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FICbaeN0TQTJiL0QbNROA0glNsNMnTCoV" X-Provags-ID: V03:K1:dMaYl22avwyb1A7AVTZzdhAwiQ1DyjZYnbuw+SbAEMXp56TcoeA ikWuaG0VZK1VeDtlUUoawW5K/0Mk2WypzdfBPriQR1QxBcW8IT1VGRCvOdnNEqlTpkFrtJs Nb0y8927W/8uowVYA+UsrsaswmP0aOCxNxslruwF0sd4rcH7BPBYDuL5inUeJcx4AebilIz 4pA7AAJ6CKX+guu1vbqyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:jH0L/MFIT6Y=:A7/2Q0Vee82UN7ddQig4t3 hSit3rTG0WJ5j7cOBpO3urYRoAjqD4G9R1ek+GDN8Q76KKy9p5rM30iSBRQ1X7qBdHLE/fNXH W/48IrQOHQjSo0z5nrIECja0HDYBe01o7CHpG459lfKnYXOYPr7mgDWo+h9IPN6Y8SlX1Bdkt I8HDTGmPFdtOELGzH4L+Sxcx6dQf0bS75EKzGrJy0Q3h7LviuuIE84sY09nkmi3UDXUwMFQC9 vkSc2ksLaEwHKT1Mr88S4dM/QFQBcUDhhJMzg7wIWSMk/9ofqqdIqtew1Na7R9hqx/l8snTLC SDEzj9tU04+jmG4/1gESVdzPi8V+lJEtHWMdBfW06oHL/bhD/w4ni6RMSFoWdIGOuG34emnqI D0rIbhAJ2eoVZwHpJctdVgizx+SXl+bKWFVGHqBDfBt0rVTyjJT/v3tSOPkc3vc5NqQsPeozn 0Wdnffho8tItjoh6tf7O0e93WrJ3FXEXDGB3ltsXD6T78085FmwS0IF/FITjVoZ8UWQKsjk+5 TJm8BprZGRH1Sk5IbyYnFaDddK0z7tHTK1b0zauvFGkb4TgCV0oWdztgS6I4Lma38Ra+0uEFU G6yqybZhvUNH1vEULQbmqNn/sWgfhzU4WcszUgJCcVqSh8r5MBzvZfzndH8tGaWoSd8eGhQhQ XZaGPDlzbSYHH4daO9xZdpFsbQkIlPpejMbLJtDYO//mQLjsqt2ED7z2O62Tp8FG4Q4TiZ0p2 U3Rb4lVigP4vIzubuxpcI7tcrM0wH/aJXZLfvHdvS5v9ZGEiH5K38YifahhkgQ+OoaZ6ZGEaQ d6H5rCkGbka1kcxiiwybtgVnCv7Ry44qRHC0eDi4OniNn37J0kCQbP0T3Yg2qE6vLcFjuyloG GgVcq9+rPW3pIYz1l+K8cbvsNrLnnjCrvbtBp2AjxH6rh8jJLsKu7GEvzTb27xR4efktcFsiE LvPd+cWYM012l3W1t3JgbkSVeWfbwFblk3ZbMJ1587/Tup3wSzObOlm1FbU6c1qYaeiek1LRc gPURdMlw4k56KpjIpC7dFphKdFab0lU+anHdiZsy/NCsgnJNZqFN9Q4PvyM584AMVNDXWQtvv fOA7c1UyljkPfFeF3My5HJ6oQWrtCPhDzjn0dnJT29SbVrq/pVl8cgt5EBc4/JLY1079IyRHU 152QQu79FUKt3FL6rHKDjNn2GKn5Eo8KVT2VAXF9h3oJPPUBuETbxd6L5EwgxLX6Am1No= X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 21:34:22 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FICbaeN0TQTJiL0QbNROA0glNsNMnTCoV Content-Type: multipart/mixed; boundary="mEy9twUrSUYIGqCtjfoIVWvh5Yn2T52UI"; protected-headers="v1" From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org Message-ID: <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat References: <20200416165859.10785-1-n54@gmx.com> <877dyf19fw.fsf@tromey.com> In-Reply-To: <877dyf19fw.fsf@tromey.com> --mEy9twUrSUYIGqCtjfoIVWvh5Yn2T52UI Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 16.04.2020 22:07, Tom Tromey wrote: >>>>>> ">" =3D=3D Kamil Rytarowski writes: >=20 >>> All major BSDs implement PT_GET_PROCESS_STATE, but they differ in >>> details and want to implement follow-fork functionality differently. >=20 Actually I was wrong in this detail. FreeBSD implements PT_SET_EVENT_MASK, but not PT_GET_PROCESS_STATE. >>> gdb/ChangeLog: >=20 >>> * inf-ptrace.h (follow_fork, insert_fork_catchpoint) >>> (remove_fork_catchpoint, post_startup_inferior) >>> (post_attach): Move... >=20 > I guess these aren't used on Linux, but what about rs6000-nat.c? Those= > are the only non-BSD users of inf_ptrace_target that I can see. >=20 > I'm not a big fan of the current code, because makes methods conditiona= l > on this define. It would be better I guess to have an intermediate > subclass for this situation. That would make it clear what code does o= r > does not rely on this. >=20 Personally, I would like to see more separation of OS specific features into OS-private files. > You don't have to do that, but I don't think we can put this in without= > knowing about the rs6000-nat case. >=20 > Tom >=20 IBM RS/6000 is AIX and it does not support PT_GET_PROCESS_STATE. At least not in the versions I could check. There was however support for PT_GET_PROCESS_STATE in HPUX, but HPUX handling was removed from GDB in 2015. --mEy9twUrSUYIGqCtjfoIVWvh5Yn2T52UI-- --FICbaeN0TQTJiL0QbNROA0glNsNMnTCoV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl6YzvkACgkQS7MI6bAu dmzS5hAAkj/GasbQOvFAzRdlxBTJq1T/Evh9a/c0NH2RNAvRfDEqGBtPRklOnFwH VC4O32a9f27pcN9y2UBBv/4jHoAXlOobr6GQgIu12nW23gFxF1lpgRbamkqoOTr6 Y8vjLUTJDnstyQnfbywjbof08Y9Jm3Qs1cal4SH3NxekJGNuS4OiiJxNUYvD5YnA JKmMk6Q7pKXw5Ypb8YjdSfqSjTi5atEwCAIjJ6cdlu7jeszBNf6WrYlnXbfnRVHA GVC8Zotd1puvNCVoYNEP6f4oNRhhtdde9IgtFcb+DU3l/I4XguWrt4Ng+DQfGQkq LoDbOSHffgZGIubhdhfOqu+m/7nAUdmr6Qci/Ua42MhnHoIKoDaUDcYW4Fh4yyOc cB7KvVkHrsKqoPiVn3Q/n8BfY+knNnpGC15QjTchjYcWHe3jJJRIk2cwPkv+TEgl QQ7n7GlFlQjZoYqdGfZVNmLu2KrKWF0tKNKZbRXJgT4yd8SwXOKmn8HtMw5PA71v jjq5vpXXvBsYPv14nGt4jVusQRmsp1xquhO4H6KFA7b2PDFGreavUTocPuaRuqXj grShM/tLGvcAM9lYSHoWNWncjd8A7DljvLvd4ceEOIZnd2AK+FP940uHMcPiQ4cn XdeNq8BUPPxQxZzqxC4L9uKyJIm5Mck08D33aeye+jQ62P2fEVY= =B5xS -----END PGP SIGNATURE----- --FICbaeN0TQTJiL0QbNROA0glNsNMnTCoV--