From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DE13538582AE for ; Mon, 18 Dec 2023 16:48:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE13538582AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE13538582AE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702918085; cv=none; b=I8P1Hrcz7REc7pJytJP8yFYr4dxpnaenZP5X+LylyjpidiMIkBGVRohas+RDnf+0qe1RGJVaeAOWRS7VZPk4hkSFsAPserI3mnfCGFdBmT7SkIslXo0uxBEApwalDfldgVZ6HKhn5TZBnhuSLcPQhwLyuN4ZhIdDpqDJ6MC4kn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702918085; c=relaxed/simple; bh=YiTLWdSl3zoOSt4Qaw5Y6uQiGB9lDKCYCOFI49IDLAY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=GDWnAf0hAl37OVUxTjJ0br5NgT0bfd2e1sVt2uJa37rksWNFlIjBRoxsnbmLTIzlT4XXv+mnjxWzzbDk1Um5Pw9Eq6TtfnlinVpsgcloQrJx5HajlgQTRB//6fFIYkwzGN+qnXV88pB7zMja2EmwqlIw11N3eRn/SY0UbJB0muA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702918083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oj1u/RlFWJYvM677uUT5p0SnQOfLUQoZlNT0pgsqLyA=; b=HyCO2HUCk3QiHX5lckfNdViDkT6p28euTBVRlB86Nm6uduuWzGo3MR3PAgIyyTMl/ydvGv 33cgE8DiogGnauNfzjx0LS2B6K4OeD/OlUC9zUPtAPzrX1d1i6Zsu5b8CveCOT/VXMH1dS YfYNWq8BjW1/rVGlpSl5i3t6WwYhABM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-YemzxJJnP56lAt1ubVJXPA-1; Mon, 18 Dec 2023 11:48:01 -0500 X-MC-Unique: YemzxJJnP56lAt1ubVJXPA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a236fc5feddso3746466b.3 for ; Mon, 18 Dec 2023 08:48:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702918080; x=1703522880; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oj1u/RlFWJYvM677uUT5p0SnQOfLUQoZlNT0pgsqLyA=; b=ca9A/exllsesgmBm9DVvWWcU/c4+EGrNbp125nWYLcZXfYM5lbcFFBE8ci3yfQGjUi 2OP8hn+W3BMD/00kr6f+GciTUoYctXTQHjOesRcRx/WUCEEsDW5O/+83fh+W6lbnsvuu cu4Nnct1nhPzZ3ygQFcQo7SZFxx73/soUz6n2Y47brVb59gH/vej8zvO5fuy4YmFfwE7 FzndJquoBHLF0hMc93vjxSv9NX6ukju1WogPaLfVWaQPsG6xnCk0h0OQUpXfWWcx709m 7qQJVCXxi8PWiwj/IwZcRf6iZHSgm8C2sUHYz7tHIynqXJ7Nj05UN++GB6IUzSAY0lZw KPqQ== X-Gm-Message-State: AOJu0YyjmmfWCwluXexBXneAVmTT4va6Y8bfxw6WxUoLkZs1U+Z9OsSP 6HXTQEDGwVW/wWfFBdZ7ywLnHRcShBPlsyQjhOZlJsHqfhnzEybLfbkOUksPvpEl2Gvh3G/bmNT KTsRepJ+kbRjYW/QzJDkAKShGp/T2Loj2ZQuzcaNos8cI4NcrEHv4b+FSRHl0+PlizPlNXrBgCF AVXodj X-Received: by 2002:a17:906:3f1a:b0:a1c:b6f8:6987 with SMTP id c26-20020a1709063f1a00b00a1cb6f86987mr5823915ejj.16.1702918080617; Mon, 18 Dec 2023 08:48:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEziaYsFzaWyw0/YOR3svR495JWCbnKMgvy933S6nkFmTNqqNvfnBP16bqpgKVimyqcwNTvVQ== X-Received: by 2002:a17:906:3f1a:b0:a1c:b6f8:6987 with SMTP id c26-20020a1709063f1a00b00a1cb6f86987mr5823905ejj.16.1702918080106; Mon, 18 Dec 2023 08:48:00 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id uv6-20020a170907cf4600b00a1e443bc037sm14464657ejc.147.2023.12.18.08.47.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 08:47:59 -0800 (PST) Message-ID: <812024b4-410f-f2f7-146b-ac128ad1d429@redhat.com> Date: Mon, 18 Dec 2023 17:47:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] gdb/testsuite: Test for a backtrace through object without debuginfo From: Guinevere Larsen To: gdb-patches@sourceware.org References: <20231213131606.676035-1-blarsen@redhat.com> In-Reply-To: <20231213131606.676035-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I've spoken to Andrew about a Linaro CI failure with this test (thanks Linaro!) and it seems I misunderstood the intent and workings of this test. I'll work on a v2 based on this new understanding, but it will take a while to be ready. In the meantime, feel free to ignore this patch, sorry for the noise. -- Cheers, Guinevere Larsen She/Her/Hers On 13/12/2023 14:16, Guinevere Larsen wrote: > From: Fedora GDB patches > > Fedora has been carrying this test since back in the Project Archer > days. A change back then caused GDB to stop being able to backtrace when > only some of the object files had debug information. Even though the > changed code never seems to have made its way into the main GDB project, > I think it makes sense to bring the test along to ensure something like > this doesn't pass unnoticed. > --- > .../backtrace-through-cu-nodebug-caller.c | 28 ++++++ > .../backtrace-through-cu-nodebug-main.c | 32 +++++++ > .../gdb.base/backtrace-through-cu-nodebug.exp | 89 +++++++++++++++++++ > 3 files changed, 149 insertions(+) > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > new file mode 100644 > index 00000000000..a33f86d1ece > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > @@ -0,0 +1,28 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2005-2023 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +typedef int (*callback_t) (void); > + > +int > +caller (callback_t callback) > +{ > + /* Ensure some frame content to push away the return address. */ > + volatile const long one = 1; > + > + /* Modify the return value to prevent any tail-call optimization. */ > + return (*callback) () - one; > +} > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > new file mode 100644 > index 00000000000..f958c0200c7 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > @@ -0,0 +1,32 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2005-2023 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +typedef int (*callback_t) (void); > + > +extern int caller (callback_t callback); > + > +int > +callback (void) > +{ > + return 1; > +} > + > +int > +main (void) > +{ > + return caller (callback); > +} > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > new file mode 100644 > index 00000000000..9b5ec3af428 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > @@ -0,0 +1,89 @@ > +# Copyright 2010-2023 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test that GDB can generate accurate backtraces even if some of the stack > +# trace goes through a function with no debug information. > + > +standard_testfile -caller.c -main.c > +set objmainfile ${testfile}-main.o > +set objcallerfile ${testfile}-caller.o > + > +# recompile the inferior with or without CFI information, then run the > +# inferior until the point where the important test starts > +# returns TRUE on an ERROR. > +proc prepare_test {has_cfi} { > + global srcdir subdir srcfile srcfile2 objmainfile objcallerfile binfile > + if {$has_cfi} { > + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ > + object [list {additional_flags=-fomit-frame-pointer \ > + -funwind-tables -fasynchronous-unwind-tables}]] != "" } { > + untested "couldn't compile without cfi" > + return true > + } > + } else { > + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ > + object [list {additional_flags=-fomit-frame-pointer \ > + -fno-unwind-tables \ > + -fno-asynchronous-unwind-tables}]] != "" } { > + untested "couldn't compile with cfi" > + return true > + } > + } > + if {[gdb_compile "${objmainfile} ${objcallerfile}" ${binfile} \ > + binfile {}] != ""} { > + untested "couldn't link object files" > + return true > + } > + > + clean_restart $binfile > + > + if ![runto callback] then { > + fail "$has_cfi: Can't run to callback" > + return 0 > + } > + return false > +} > + > +if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" ${objmainfile} \ > + object {debug}] != "" } { > + untested "couldn't compile main file" > + return > +} > + > +if { [prepare_test false] } { > + untested ${testfile}.exp > +} else { > + gdb_test_multiple "bt" "verify unwinding breaks without CFI" { > + -re -wrap " in \[?\]\[?\] .*" { > + # It may backtrace through some random frames even to main(). > + pass $gdb_test_name > + } > + -re -wrap " in main .*" { > + fail $gdb_test_name > + } > + } > +} > + > +if { [prepare_test true] } { > + untested ${testfile}.exp > +} else { > + > + # #0 callback () at ... > + # #1 0x00000000004004e9 in caller () > + # #2 0x00000000004004cd in main () at ... > + gdb_test "bt" \ > + "#0 +callback \[^\r\n\]+\r\n#1 \[^\r\n\]+ in caller \[^\r\n\]+\r\n#2 \[^\r\n\]+ in main \[^\r\n\]+" \ > + "verify unwindin works for CFI without DIEs" > +}