From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v3 1/2] gdb/regcache: return REG_UNAVAILABLE in raw_read if NOT_AVAILABLE_ERROR is seen
Date: Wed, 23 Mar 2022 14:05:57 +0100 [thread overview]
Message-ID: <81359dca66e7ebf211e9d5a4d7453e72e0f82b8b.1648040449.git.tankut.baris.aktemur@intel.com> (raw)
In-Reply-To: <cover.1648040449.git.tankut.baris.aktemur@intel.com>
In regcache's raw_read, it is possible that 'raw_update' fails with an
exception. This could happen, for instance, if the debugged thread is
already exited and the target cannot fetch its registers. Catch the
exception and return REG_UNAVAILABLE if the error is of kind
NOT_AVAILABLE_ERROR. This makes clients' lives easier.
Regression-tested on X86_64-Linux.
---
gdb/regcache.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 00d7a10e289..c57d2e4c345 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -598,7 +598,17 @@ enum register_status
readable_regcache::raw_read (int regnum, gdb_byte *buf)
{
gdb_assert (buf != NULL);
- raw_update (regnum);
+ try
+ {
+ raw_update (regnum);
+ }
+ catch (const gdb_exception_error &ex)
+ {
+ if (ex.error != NOT_AVAILABLE_ERROR)
+ throw;
+
+ m_register_status[regnum] = REG_UNAVAILABLE;
+ }
if (m_register_status[regnum] != REG_VALID)
memset (buf, 0, m_descr->sizeof_register[regnum]);
--
2.33.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-03-23 13:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 9:15 [PATCH v2 0/2] Querying registers of already-exited processes Tankut Baris Aktemur
2022-02-08 9:15 ` [PATCH v2 1/2] gdb/regcache: return REG_UNAVAILABLE if raw_update raises NOT_AVAILABLE_ERROR Tankut Baris Aktemur
2022-03-16 15:18 ` Bruno Larsen
2022-03-23 12:55 ` Aktemur, Tankut Baris
2022-02-08 9:15 ` [PATCH v2 2/2] gdb: raise and handle NOT_AVAILABLE_ERROR when accessing frame PC Tankut Baris Aktemur
2022-03-16 17:26 ` Bruno Larsen
2022-03-23 12:55 ` Aktemur, Tankut Baris
2022-03-23 13:34 ` Bruno Larsen
2022-03-24 8:46 ` Aktemur, Tankut Baris
2022-02-22 7:31 ` [PATCH v2 0/2] Querying registers of already-exited processes Aktemur, Tankut Baris
2022-03-07 8:00 ` Aktemur, Tankut Baris
2022-03-23 13:05 ` [PATCH v3 " Tankut Baris Aktemur
2022-03-23 13:05 ` Tankut Baris Aktemur [this message]
2022-03-23 13:05 ` [PATCH v3 2/2] gdb: raise and handle NOT_AVAILABLE_ERROR when accessing frame PC Tankut Baris Aktemur
2022-05-04 7:19 ` [PATCH v3 0/2] Querying registers of already-exited processes Aktemur, Tankut Baris
2022-12-23 17:10 ` Aktemur, Tankut Baris
2023-01-17 20:40 ` Aktemur, Tankut Baris
2023-01-24 10:35 ` Aktemur, Tankut Baris
2023-01-31 20:14 ` Aktemur, Tankut Baris
2023-02-20 13:07 ` Aktemur, Tankut Baris
2023-03-03 7:46 ` Aktemur, Tankut Baris
2023-03-28 13:40 ` Aktemur, Tankut Baris
2023-12-18 14:40 ` [PATCH v4 " Tankut Baris Aktemur
2023-12-18 14:40 ` [PATCH v4 1/2] gdb/regcache: return REG_UNAVAILABLE in raw_read if NOT_AVAILABLE_ERROR is seen Tankut Baris Aktemur
2023-12-18 14:40 ` [PATCH v4 2/2] gdb: raise and handle NOT_AVAILABLE_ERROR when accessing frame PC Tankut Baris Aktemur
2023-12-20 22:00 ` John Baldwin
2023-12-21 6:41 ` Eli Zaretskii
2023-12-27 18:41 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81359dca66e7ebf211e9d5a4d7453e72e0f82b8b.1648040449.git.tankut.baris.aktemur@intel.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).