From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, Gary Benson <gbenson@redhat.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Indicate batch mode failures by exiting with nonzero status
Date: Fri, 31 Aug 2018 14:42:00 -0000 [thread overview]
Message-ID: <813f3a12-ff85-c48a-aede-7aa89b1ae889@redhat.com> (raw)
In-Reply-To: <87pnxy1u94.fsf@tromey.com>
On 08/31/2018 03:32 PM, Tom Tromey wrote:
> Maybe calling clear_gdb_spawn_id, but I don't know if that's best or if
> there should be something else.
Yeah, if we compare with gdb.base/quit.exp, that is missing
as well as the "remote_close host" call. For the latter, when I last
touched quit.exp, I remember fretting a bit about whether the remote_close
was really necessary, but in the end decided to keep it, I don't recall
exactly if I kept it because I found it's necessary (probably for
remote hosts), or because it doesn't hurt.
Now that I look at gdb.base/quit.exp again, I see that gdb.base/batch-exit-status.exp
can hang forever in the same way that 15763a09d4ae fixed, isn't it?
Gary, any reason you didn't do the "eof" thing here too?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-08-31 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 10:47 Gary Benson
2018-08-22 14:37 ` Eli Zaretskii
2018-08-23 8:00 ` Gary Benson
2018-08-23 16:37 ` Pedro Alves
2018-08-30 20:26 ` Sergio Durigan Junior
2018-08-31 13:30 ` Gary Benson
2018-08-31 14:33 ` Tom Tromey
2018-08-31 14:42 ` Pedro Alves [this message]
2018-09-03 16:12 ` [PATCH] Fix batch exit status test failure on Fedora 28 Gary Benson
2018-09-04 11:39 ` Pedro Alves
2018-09-04 14:37 ` Gary Benson
2018-08-31 15:38 ` [PATCH v2] Indicate batch mode failures by exiting with nonzero status Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=813f3a12-ff85-c48a-aede-7aa89b1ae889@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).