From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2070.outbound.protection.outlook.com [40.107.116.70]) by sourceware.org (Postfix) with ESMTPS id 8917D3858C20 for ; Tue, 29 Nov 2022 16:43:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8917D3858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YBQjAYn0ogva+AX4Yi0Pg11sEsM5DNHNzf3njjj1vWTZJOnCEBK9ccUY+cB+OXbJOPbBh4cT56tVCP1e3tXeZ8XyGGOEUjQMwqefpq5iMshS2ydekSu69/vUc5FR5W8TNnkrVSWk71QUIervfn3qeWsurxAC3ZotDFMN3JxYA4IduyE131VdclGP3GVH/9otilSIE5slmmmYEQrY1tNr0bj5p04n2ucIonF0k2x3DCCwfRS56OEK3fgEapgwHo8YPYvQrvne+NsjvQ/rJGM+TQfw6GHQh141Mi5Xo1sxudM+uiJEw8KIQ8l4G7XjJhTTMiWv19ilAmBg52fe3yzG/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MdyDApsfwKNCL1gr8OubkhrMq5xLucJ2HMT94UvVv4c=; b=fmAnZx56e7b9HuJ3lLrvwK2UfpFFcZcQFj5xADklce/v9ZfpY3dnZFwMztY41qoGWD2IoOkLUXJghJiCeG9FYOkVSSLRoVdQPoK9OXlKitpcGX4q+8Ss8jW62WEmfjZHA5txXG4BhWJPIH20YPD/ofC3XX/kBoJUkFHETZKJ9vjuioSUE9eIbYHHSg/5EthnMWZCtNlySsCl8tYD1IQ90MbsA3FRh5IYLFdP2ohkbkSqdlZUlerc6MjcXxI8EyUWzYUpODsopsUWvnvaXlg33aJmRztCAD2fztV1tfcVEiVh5VY79tSELnV/NT1Wq3UKue+5Qe3Yh7fCOjahN+0xRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MdyDApsfwKNCL1gr8OubkhrMq5xLucJ2HMT94UvVv4c=; b=ZVKzS4005kGEHlLrhQueQJ3d5t1zkr0kgwZK/MX/50xn/HYbj/jCRzZqY/NkGt50rlnSZJ8TiXS3jdQBFdQ3QDFAhVP9Pgaqg2rRODmBdE7t4fz1EG2/g7kfctshYHuSCyTMxBxuibushMDL7bTf+saI+z/fx72vbdxKKnvIbV0tPT6moXLQniacIyrXXC6vkgtilU5TUicqIaydiVx3oI0+wGHXgS9SdPQ7t/it4VmtmQPnJfsmIHLx7A5zR/sa7HpktejHK8ViKSh0HF7ysjKPm6kEmiG6EXmSYK+zOx/sHit8F2Xn56ygT/yqvl6GhTPSZBAgEr3CJ6FzmuKBng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB8495.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:56::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:43:29 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::948b:ac25:c50c:f52e]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::948b:ac25:c50c:f52e%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:43:29 +0000 Message-ID: <815d1249-6984-fce6-854e-c751f99bf455@efficios.com> Date: Tue, 29 Nov 2022 11:43:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] gdb/testsuite: make gdb_unload use gdb_test_multiple Content-Language: fr To: Tom de Vries , gdb-patches@sourceware.org Cc: Simon Marchi References: <20221122155546.599061-1-simon.marchi@efficios.com> <20221122155546.599061-2-simon.marchi@efficios.com> <7ddb7298-d036-52bb-933f-f225157735a0@suse.de> From: Simon Marchi In-Reply-To: <7ddb7298-d036-52bb-933f-f225157735a0@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YT3PR01CA0113.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:85::16) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB8495:EE_ X-MS-Office365-Filtering-Correlation-Id: 3693e4ce-8cdb-497b-fcad-08dad228d7d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3NVauaoqVoGnuK1lo9sVrwOwThzddEpA87pYpT8w8I1Q4ahRIDKlUHSVuBvG9I76RTP7DjqI1ChunoenMUuWWftW0nLIMQxr9zrD16nXW+x2+6GCwzt55A19O18WiAF6ZqRdI04Qb9g9g7r8gWWhwl+nNesSVJ3j7ygOyWD9Ry50PAP9GStclyH52YIeV0pmbzkGUVZqi3JjHgHoOH0isrC3eG5TTGsLgD2qLEtKilVxRsjGLUjDs6jeFTvVzjplB5231qxBaXCK9zxU1ijPNCG/ZWh44zCFeHBxy8qwDIGUezz52JAHcqRSgDpSQqw2Ixke9dgtVnMgzJfvNCA8pZHfuY6TsBAg5+aR90bv73QgsTkbpoS2j2k8tpUY+ah0wT2WS3ViHeIDCWlvPaDptbQtne1d4D8iM0VSYZ64kK2d0qUS07puFA66AZacJzlJHz+xPtl8nktAHkOBqsM4tnGb0xovBIuCLjhLbGZ5ZHVLvUGcjfyVOhOBvJDHa6af757n75rO5U/6gPn2Os0kYBNF6/mSgxcYh+N7EaC89iEh5dwFrWxHtpGzd5Iy3uUjyHQ9vaRJr7MfMXltKqkWmGzeZ/B+X04b33AE0aXjErUrjC76+SLxX//kPkGop52j294NnXPi0zZA/U+vM8wXAZ07sAXlC5+5vjQaGQU7YZm9dNgUBGJ+ScTf+CbAXGa/PSNfcY33r8rVd9g6eu3ywH7WaZvKIUEav4ozJ5jLdiAl5S1zv5icvc6xUfF0CgfpP5NcyEjKxSzhE178OXpuXkT+Cu+Qz1PzjvdeMeE3Njs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(366004)(396003)(39830400003)(376002)(451199015)(66476007)(38100700002)(6666004)(6486002)(966005)(31696002)(478600001)(41300700001)(36756003)(4326008)(66556008)(66946007)(8676002)(316002)(4744005)(8936002)(5660300002)(44832011)(2906002)(31686004)(2616005)(83380400001)(6506007)(84970400001)(53546011)(186003)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU5vdzdzWHp4aW5nRnI4QXo1ZHc0Z3F3SWx6b3gyYzVSb2x6eXkxSHc3TFVL?= =?utf-8?B?Mk9pUzhaTXRHNDVjSGJ1d3FKUU5TdngwNWRERHc5S2Nmai9VT20zZXpMZEUy?= =?utf-8?B?cDV3bG9tUys4WU1Qb3gzZDJJWmpnVUVneUNDSWx4Vy83MFl3WE9rNEsvY0tC?= =?utf-8?B?Rkx2eVc5WlZMVEhzTTBVbkZBWXAyZGxzWUhPRTFRYmlyYkdqOWl5MDFlK0Ew?= =?utf-8?B?R3FnNEtrSHppYlJycnZMUkNPanUrMXI3ZFBMaUltam9DZ0x4dlY1MTdKZVRn?= =?utf-8?B?UEs1L1VSY0NLRXRVKzdRMXMxU3pVMDFtOHYrVzA2dGwzcmdtQ3FvTWprRXVT?= =?utf-8?B?TEZ0SmZibFBnWDl5YXRaU2M2ZlZNSFk4RzRoU05HV1JCaTE1YnlORG1MbGRV?= =?utf-8?B?THpCYk0wL2ZXVXRQYjFVeE1UWm93TS8zdjVNY0dqN2NESmlyUUhyTFlUNFQx?= =?utf-8?B?S3ozU3R4VHBMRndwMVpMcThYeEZrUGVKMXlnbzNNUGFmVzF1QXI4NW5HUVl4?= =?utf-8?B?RHFNVDA0L0trQW90VU5pQlhreUR1dFBKLzM0TVBvbGVTZ0EvdU5sS0I0NEtv?= =?utf-8?B?ZHBFd2IyZlNjKytBRmU0Z05SeDYveEVNcnRCM0pQWUMzYmpMSTRCWWJTQ1F6?= =?utf-8?B?QmIrK2g3TS8xK3ZUWmZSSHFZcW5RVnFpdFhwUHdkN2NlSlVGajNjTFhNaklG?= =?utf-8?B?WHoveTh6VVp1SDNxUTdML0xUdjNpYk5RdHFIejREelp4RnR6VHAvV3dUR2hZ?= =?utf-8?B?cjFUcHhSMTFZd2lZcEFrM2JGNXNBSk44Q2VVQjZpQ0ZlKzlCMlpQQWkxcHI5?= =?utf-8?B?MlhqVGdlcnRzTUdjNW1aemFZUmZLSXBxS2NzK05rSlBqSjlLKzNSUUJBZ1JE?= =?utf-8?B?RC9jaTlnRHFBQUkyaU04ZTkxcEJaZEc2SFFsRHpGdVhlODdXT3RUbm1uSWpn?= =?utf-8?B?VEJCdE9KK2hKS3d4WDRKeWUrSTN6MGQ3UzBpckxRRlpFSkdXYTdMb1lDWTFI?= =?utf-8?B?aFBSRnAwclJoMXJDWVpWVm1idWp1ZEpTanRZWWVEeDI2cDhkZlFHRmNST2lu?= =?utf-8?B?eGV5VmNPVnV4MGY4aVBDN3UzNlR1WXFZZ1FyeFEzNnhzYWRKMkpjL24zSzRQ?= =?utf-8?B?OTBFdEJSbG1oZzc4NGxScHFuZDFsZ0k1YU5JdTA1MGx5bVBNRDZVWEhaNHpJ?= =?utf-8?B?aXQ5Nk9sMGhjeEg3ak9LK0xiSi9UNkhyeEFFdzBuV3lvamZ2SGIzTEdOSm1M?= =?utf-8?B?YjE2UHNUckJBbkxkR0w0UVEweVA5Ulo1YWZkdlRacFF1ZzU0dkpNWlBCMFZV?= =?utf-8?B?eXFuQk4zdTlvS0Y3S3NIMVlRTzY1R2tVaDJXZW5xTVd1V3VRUHpiVUJQNDJF?= =?utf-8?B?M0JjbWdTZjk1STI5dUFXeTAvV3UwRHRHdTAyeWhuc3pQYlZnZTFHMWtlNzY3?= =?utf-8?B?dkFSWHVhcVNkZm16cXZzdWRnTkVPbVhXWU9pamp2RVNOKzJ3L0crY0Vab2dw?= =?utf-8?B?V0gvakh6M3V0cy84TUhNNDhLaCtXM3N2MWF1MC9NMVNTMnpwZGVnZlZnanpr?= =?utf-8?B?U09HVmJ1Yk0wWFV5ekJFSU42MkVHMHhyZE1tS0RaMm14NzVCNjBUb21ITS9v?= =?utf-8?B?NkxUajA2UGJXbGtJbE9wc3FadGkvUDh4d3pMSTRVTG95Z0VJdjlnVUxGZE9X?= =?utf-8?B?WXMzNW5MNEdEU1kzUUFVd1Ayb1BQL3B1dlF3VUhTOWV2MEYySnduZTNuMlNt?= =?utf-8?B?cUhUOEtSSERWQnloWFRzS2RNYW1hakJ2TUQyNEJsa3IzSSs2TTVncGhNOGdG?= =?utf-8?B?V3hyK01IdFZlWVlxa0tGSmxoSTl3WXF6MVY4alNjQmQ2RUN5ck5WS2lzM1Z4?= =?utf-8?B?WWNGL29RcDFrUDhuWll4R01ZN2lUWlVzL0lHYkRrRnlaeW81bFJEN2FrMGQx?= =?utf-8?B?VzZjTTZGRm5pMENuMjVlYjQyWkd4VHV0TTFsN3pmUHRvR2VaSlU1c1ovSERp?= =?utf-8?B?K1pQNXA0VXpQdkFMeU53cDQxbjdQNFpmdnZaUkc0MWEvbzM1UURTQllWcDVV?= =?utf-8?B?Wk1ZWTZQK0RIdDVlRGJBZ1gvbXFKYmRMSUg4ajJIZkppRkI3c0JzQ014OGhz?= =?utf-8?Q?tThbmAL6vkcelw3T4psVFFb0X?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3693e4ce-8cdb-497b-fcad-08dad228d7d9 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 16:43:28.9664 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WW6jZZo922b7C9rnPYj29wwWLe4oRvw2kMJsQ9tUzjmphOyFHEqUXufwRgM7jXe6EDBZZZYLeHVpAs/KmOEAfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8495 X-Spam-Status: No, score=-3033.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/29/22 11:28, Tom de Vries wrote: > On 11/22/22 16:55, Simon Marchi via Gdb-patches wrote: >> From: Simon Marchi >> >> In the failure seen by Philippe here: >> >>    https://inbox.sourceware.org/gdb-patches/20221120173024.3647464-1-philippe.waroquiers@skynet.be/ >> >> gdb_unload crashed GDB, leaving no trace in the test results.  Change it >> to use gdb_test_multiple, so that it leaves an UNRESOLVED result.  I >> think it is good practice anyway. >> > > Agreed.  I do remember some cases where I had to downgrade from gdb_test_multiple to gdb_expect, but I guess for the common case gdb_test_multiple is the best. Ack. >> Make it return the result of gdb_test_multiple directly, change >> gdb.python/py-objfile.exp accordingly. >> >> Change gdb.base/endian.exp as well to avoid duplicate test names. >> >> Change gdb.base/gnu-debugdata.exp to avoid recording a test result, >> since gdb_unload does it already now. >> > > LGTM. Thanks, will push. Simon