From: Simon Marchi <simark@simark.ca>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Constify target_desc declarations
Date: Tue, 13 Sep 2022 09:38:41 -0400 [thread overview]
Message-ID: <81665c57-8c9f-3dc5-1c2d-9afffb4b84a4@simark.ca> (raw)
In-Reply-To: <20220912224733.2962282-2-keiths@redhat.com>
Thanks for doing this, this looks good to me.
> diff --git a/gdb/nios2-tdep.h b/gdb/nios2-tdep.h
> index cbf2599f5c0..78d5d8e0c97 100644
> --- a/gdb/nios2-tdep.h
> +++ b/gdb/nios2-tdep.h
> @@ -84,7 +84,7 @@ struct nios2_gdbarch_tdep : gdbarch_tdep_base
> int jb_pc = 0;
> };
>
> -extern struct target_desc *tdesc_nios2_linux;
> -extern struct target_desc *tdesc_nios2;
> +extern const struct target_desc *tdesc_nios2_linux;
Double space.
Simon
next prev parent reply other threads:[~2022-09-13 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 22:47 [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile Keith Seitz
2022-09-12 22:47 ` [PATCH 2/2] Constify target_desc declarations Keith Seitz
2022-09-13 13:38 ` Simon Marchi [this message]
2022-09-13 13:34 ` [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile Simon Marchi
2022-09-13 13:55 ` Keith Seitz
2022-09-13 13:57 ` Simon Marchi
2022-09-13 14:44 ` Keith Seitz
2022-09-13 14:10 ` Luis Machado
2022-09-13 15:11 ` Simon Marchi
2022-09-13 15:19 ` Luis Machado
[not found] ` <2e6adda3-3cdf-7520-eee9-d58f179537ab@redhat.com>
[not found] ` <3b7b0389-3cfe-ea44-7a22-9cb496debd4c@simark.ca>
2022-09-29 17:08 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81665c57-8c9f-3dc5-1c2d-9afffb4b84a4@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).