From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 11E103858D39 for ; Tue, 13 Sep 2022 13:38:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 11E103858D39 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BF1701E110; Tue, 13 Sep 2022 09:38:41 -0400 (EDT) Message-ID: <81665c57-8c9f-3dc5-1c2d-9afffb4b84a4@simark.ca> Date: Tue, 13 Sep 2022 09:38:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 2/2] Constify target_desc declarations Content-Language: en-US To: Keith Seitz , gdb-patches@sourceware.org References: <20220912224733.2962282-1-keiths@redhat.com> <20220912224733.2962282-2-keiths@redhat.com> From: Simon Marchi In-Reply-To: <20220912224733.2962282-2-keiths@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2022 13:38:43 -0000 Thanks for doing this, this looks good to me. > diff --git a/gdb/nios2-tdep.h b/gdb/nios2-tdep.h > index cbf2599f5c0..78d5d8e0c97 100644 > --- a/gdb/nios2-tdep.h > +++ b/gdb/nios2-tdep.h > @@ -84,7 +84,7 @@ struct nios2_gdbarch_tdep : gdbarch_tdep_base > int jb_pc = 0; > }; > > -extern struct target_desc *tdesc_nios2_linux; > -extern struct target_desc *tdesc_nios2; > +extern const struct target_desc *tdesc_nios2_linux; Double space. Simon