From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C21F03857C68 for ; Sun, 6 Mar 2022 16:27:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C21F03857C68 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 226GRZvW027182 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 6 Mar 2022 11:27:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 226GRZvW027182 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A95DC1EE1F; Sun, 6 Mar 2022 11:27:34 -0500 (EST) Message-ID: <817e66ba-c716-dec5-a917-fe6c9519165a@polymtl.ca> Date: Sun, 6 Mar 2022 11:27:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] Use function view when iterating over block symbols Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220304234002.5545-1-tom@tromey.com> From: Simon Marchi In-Reply-To: <20220304234002.5545-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 6 Mar 2022 16:27:35 +0000 X-Spam-Status: No, score=-3039.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2022 16:27:41 -0000 On 2022-03-04 18:40, Tom Tromey wrote: > This changes iterate_over_block_local_vars and > iterate_over_block_arg_vars to take a gdb::function_view rather than a > function pointer and a user-data. In one spot, this allows us to > remove a helper structure and helper function. In another spot, this > looked more complicated, so I changed the helper function to be an > "operator()" -- also a simplification, just not as big. > --- > gdb/stack.c | 47 ++++++++++++++++++----------------------- > gdb/stack.h | 11 ++++------ > gdb/tracepoint.c | 55 ++++++++++++------------------------------------ > 3 files changed, 37 insertions(+), 76 deletions(-) > > diff --git a/gdb/stack.c b/gdb/stack.c > index fe243b4310e..d373b9fa93d 100644 > --- a/gdb/stack.c > +++ b/gdb/stack.c > @@ -2240,8 +2240,7 @@ backtrace_command_completer (struct cmd_list_element *ignore, > > static void > iterate_over_block_locals (const struct block *b, The comment above this needs to be updated. Otherwise, LGTM. Simon