From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/6] Eliminate make_symbol_overload_list-related globals & cleanup
Date: Wed, 17 Oct 2018 17:25:00 -0000 [thread overview]
Message-ID: <818ad030-6665-71c7-006d-77ad6b5895c8@ericsson.com> (raw)
In-Reply-To: <20181015151115.6356-4-palves@redhat.com>
On 2018-10-15 11:11 a.m., Pedro Alves wrote:
> This gets rid of a few globals and a cleanup.
>
> make_symbol_overload_list & friends currently maintain a global
> open-coded vector. Reimplement that with a std::vector, trickled down
> through the functions. Rename a few functions from "make_" to "add_"
> for clarity.
LGTM, my only comment would be to avoid non-const passing by reference, as in
the previous patch.
Simon
next prev parent reply other threads:[~2018-10-17 17:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 15:11 [PATCH 0/6] Use gdb::array_view some more, plug leaks Pedro Alves
2018-10-15 15:11 ` [PATCH 1/6] Use gdb:array_view in call_function_by_hand & friends Pedro Alves
2018-10-17 1:45 ` Simon Marchi
2018-11-21 12:39 ` Pedro Alves
2018-10-15 15:11 ` [PATCH 3/6] Eliminate make_symbol_overload_list-related globals & cleanup Pedro Alves
2018-10-17 17:25 ` Simon Marchi [this message]
2018-11-21 12:47 ` Pedro Alves
2018-10-15 15:11 ` [PATCH 2/6] invoke_xmethod & array_view Pedro Alves
2018-10-17 16:21 ` Simon Marchi
2018-11-21 12:47 ` Pedro Alves
2018-11-26 17:18 ` Simon Marchi
2018-11-26 17:54 ` Pedro Alves
2018-11-26 18:28 ` Simon Marchi
2018-10-15 15:11 ` [PATCH 5/6] valops.c: Some more gdb::array_view Pedro Alves
2018-10-17 18:03 ` Simon Marchi
2018-11-21 12:48 ` Pedro Alves
2018-10-15 15:16 ` [PATCH 4/6] C++ify badness_vector, fix leaks Pedro Alves
2018-10-17 17:44 ` Simon Marchi
2018-11-21 12:47 ` Pedro Alves
2018-10-15 15:18 ` [PATCH 6/6] valops.c: Overload resolution code: Rename parameters/locals Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=818ad030-6665-71c7-006d-77ad6b5895c8@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).