[PATCH][PR build/26068] MinGW build failed due to ws2_32 dependency

[PATCH][PR build/26068] MinGW build failed due to ws2_32 dependency

[Adam Mitz]

gdb/ChangeLog:
2020-06-07  Adam Mitz  <mitza@objectcomputing.com>

        PR build/26068
        * Makefile.in: fixed library dependency order

---
 gdb/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index c3e074b21f..dee3c89c8e 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -611,8 +611,8 @@ CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(LIBCTF) $(ZLIB) \
     $(XM_CLIBS) $(GDBTKLIBS) \
     @LIBS@ @GUILE_LIBS@ @PYTHON_LIBS@ \
     $(LIBEXPAT) $(LIBLZMA) $(LIBBABELTRACE) $(LIBIPT) \
-    $(LIBIBERTY) $(WIN32LIBS) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
-    $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS)
+    $(LIBIBERTY) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
+    $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS) $(WIN32LIBS)
 CDEPS = $(NAT_CDEPS) $(SIM) $(BFD) $(READLINE_DEPS) $(LIBCTF) \
     $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU)
 
-- 

Re: [PATCH][PR build/26068] MinGW build failed due to ws2_32 dependency

[Simon Marchi]

On 2020-06-07 10:01 p.m., Adam Mitz wrote:
> gdb/ChangeLog:
> 2020-06-07  Adam Mitz  <mitza@objectcomputing.com>
> 
>         PR build/26068
>         * Makefile.in: fixed library dependency order
> 
> ---
>  gdb/Makefile.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index c3e074b21f..dee3c89c8e 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -611,8 +611,8 @@ CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(LIBCTF) $(ZLIB) \
>      $(XM_CLIBS) $(GDBTKLIBS) \
>      @LIBS@ @GUILE_LIBS@ @PYTHON_LIBS@ \
>      $(LIBEXPAT) $(LIBLZMA) $(LIBBABELTRACE) $(LIBIPT) \
> -    $(LIBIBERTY) $(WIN32LIBS) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> -    $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS)
> +    $(LIBIBERTY) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> +    $(SRCHIGH_LIBS) $(LIBXXHASH) $(PTHREAD_LIBS) $(WIN32LIBS)
>  CDEPS = $(NAT_CDEPS) $(SIM) $(BFD) $(READLINE_DEPS) $(LIBCTF) \
>      $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU)
>  
> -- 
> 

Hi Adam,

I think I can guess the reason for the patch, but please expand your commit message.  When
fixing a build failure, please at least quote the relevant portion of the build failure
(I'm guessing here it's undefined symbol at link time, something like that).  And for bonus
points, to help people agree with your change, you can explain why that happens, and how
your fix fixes it.

Simon