From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by sourceware.org (Postfix) with ESMTPS id F237E3858C42 for ; Tue, 23 Apr 2024 12:47:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F237E3858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F237E3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713876459; cv=none; b=iy0/OkXZdRUJZjMCNynLzV50kIRRYGc4x2yJzJdzn5pbfUgvtYVVZvVkT2iPs7nv/ozHUL5fYTLPoaaY7E+Wg5H2K/L8wuV5jWxfCPU85KKLaeps4c6TttKwmEYgUJu5exRnDIkA+sObbQSuQFH/buK9Nt9b9EpR+43JOZoliPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713876459; c=relaxed/simple; bh=St0G6i9SLlJiTJd/WYgw1aTg80TSaX/j0GcO2Ma3xc0=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=e8Ei53S+f6/9lst28A7AIeUZur42y1YaF289G0v3jOCgJJsVbret1qQTkVIAJJ+EIrnaAAwoHp5W1z0XrNY/97ONQRrYZAGgv3Gr+np/u+VT/XZJTM/9yRN8d6XktoDNw+kEWHOB9g8qrROzuiD2VZIDjjVuVrUCG/XHmsY296A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-41a5b68eceeso15467525e9.3 for ; Tue, 23 Apr 2024 05:47:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713876455; x=1714481255; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CdSEDZIjyYUIJ4tb+X5vNxvk9Fa9YlHnJ6L2RQnycuw=; b=kGv6LmbQ60KBt0sPOUB32vzoDfQ8g0dRupSjzBGQjajTG6srDpV4LxpQX3QQ+yri/9 SYn6IOL3i59Hkt84Mlvtuvgk4gXkC15YpRPoySg+TDckaUwFLMdeao+6kLP9Oeg0CZw7 tgi7yQHQKak6ruATFOjMeWsjAc3dmljoG21WDHeHznc7qyYdj7jI2HhnlyAWBqsjwfEz QrgbyzA4/wmmjAdQCyp2/b9/5l0Vd2a5cKrrJixe6NNbg4ph1j2QDU+gLTa7p5ygcAuC fnWP2e4uKM4/YrUiH+V9InjD4xnCV59nlbHhDxhwhSwBbGkDB/2SifTCAmfHMa1dTFN1 6ADw== X-Forwarded-Encrypted: i=1; AJvYcCWC6ztW3j5zKT5aZO3C67mLckiyPJ/lkucTtVAxinPpDnh4KW8GgYKfzppBNiZ9Fb3ys/6RNk12nmHq9AAFAPXC2tJSwC1Aa5diiA== X-Gm-Message-State: AOJu0YwO5rNW4XoRPQGj4i7m4A3ZPPowmnNGxquLSipj0DNW9P8tiNaJ roKGg0Z6j2BqZRP0Xlxkl4M6V3iOX/5AQzPpJGje46yS1L7jDapru0R7fw== X-Google-Smtp-Source: AGHT+IEUS0tisGVrngHy4D0vbaQay0RzuwXO+E4MfH97DUiZkYzs6g8zJIR7dXd1GEFHxVN7gd+b7A== X-Received: by 2002:a05:600c:4508:b0:418:2343:1eb with SMTP id t8-20020a05600c450800b00418234301ebmr8885581wmo.5.1713876454720; Tue, 23 Apr 2024 05:47:34 -0700 (PDT) Received: from ?IPV6:2001:8a0:f93d:b900:4f86:481:20cb:27d? ([2001:8a0:f93d:b900:4f86:481:20cb:27d]) by smtp.gmail.com with ESMTPSA id t13-20020a05600c198d00b00417da22df18sm23741028wmq.9.2024.04.23.05.47.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 05:47:34 -0700 (PDT) Message-ID: <8248b763-2325-4f9a-86d3-6e8ce7117290@palves.net> Date: Tue, 23 Apr 2024 13:47:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/12] gdb_target_is_remote -> gdb_protocol_is_remote To: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: <20240419151342.1592474-1-pedro@palves.net> <20240419151342.1592474-11-pedro@palves.net> From: Pedro Alves Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-22 09:30, Aktemur, Tankut Baris wrote: > On Friday, April 19, 2024 5:14 PM, Pedro Alves wrote: >> Subject: [PATCH 10/12] gdb_target_is_remote -> gdb_protocol_is_remote > > Similar to the previous patch, "gdb_target_is_remote" shall be spelled > "gdb_is_target_remote". Thanks. I fixed that locally. > >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index c072a4502b4..f37d54b16be 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -4700,7 +4700,8 @@ proc gdb_is_target_remote_prompt { prompt_regexp } { >> # >> # This is meant to be used on testcases that connect to targets >> # different from the default board protocol. For most tests, you can >> -# check whether gdb_protocol is "remote" or "extended-remote" instead. >> +# check whether gdb_protocol is "remote" or "extended-remote" instead >> +# (or call gdb_protocol_is_remote for either). >> # >> # NOTE: GDB must be running BEFORE this procedure is called! >> >> @@ -4731,6 +4732,14 @@ proc gdb_protocol_is_native { } { >> return [expr {[target_info gdb_protocol] == ""}] >> } >> >> +# Returns true if gdb_protocol is either "remote" or >> +# "extended-remote". >> + >> +proc gdb_protocol_is_remote { } { >> + return [expr {[target_info gdb_protocol] == "remote" >> + || [target_info gdb_protocol] == "extended-remote"}] >> +} >> + > > How about using `eq`, since this is string comparison? Also in the previous > patch in the comparison against "". I just find that == reads a little bit better. There is no risk that this ends up doing a numerical comparison, which would be the reason to use string eq. Note that we use == when comparing with gdb_protocol pretty much everywhere throughout the testsuite.