From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic311-30.consmr.mail.ir2.yahoo.com (sonic311-30.consmr.mail.ir2.yahoo.com [77.238.176.162]) by sourceware.org (Postfix) with ESMTPS id 869CE395445A for ; Thu, 17 Jun 2021 14:54:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 869CE395445A X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1623941691; bh=d8EqmUUbMU4LVdpYvoURwUXo77To8MwF8pFQDu3hq0O=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=snR9jOGMcl29RqemnJ5SDXF6FYA7qjdorFdp78pn1L956ROzJia/4V064N9vShyfxSSSjCspA1nB2fruMLF4fsuRUcbdyPO1ehQrJEj2/r4OCfSU9oDfbk4Z6THIiDZmT3tKjgHtWSJl8aIHG5dEBPW3+kUYgbuzVFT/2AxS1IZ6Z3zxdeAROOfdE+iGNcjVfKpGhWOLKdA4YSBMXhHrpEWILlTxfbHbvdxkUlpWXszCYL20SSH1ex1FBZGtNuACgp89rwNTFrQCA+WsPaecByiKHW0qDj7nNolfqoo6d2Ey0N7JrvNobBH/eQci9b4oq5TDQCAFoSlZ1vCl8Y09Qw== X-YMail-OSG: Af.uqS8VM1nV7_IxuWBQJcH.amLvLhKFzubrQo7Kxm44aCIbATrIAiejpUNG6L0 1xvCF2hF4oR2Mtb_hbaLh.VQTfD7NAJ1.A2HRK8iSHxFfAqSsq6Hj_NF8thtrtDEVY.6frzJJJ4z lJgfSrPd0LFlbSWjk85wYcI4i.jG1LimdQylrsler0sntg82a1l1ITM7VLhCMozao.6OcxWKO7cx H02Sy.YTXZ.2_.b2wtK0p0aD2Ni0JUEZDSie0ZbfeA05jPYRzo3oImkVC9OcKF7jo77mFEen3KG6 9W9DjI2V8O8hqM3IbyM1eoEPmIguygcpctJtrgu.xJvSZoj15Ri6mEhgSJqW6bWoxSi.LMTUAJ0P zliJUZbRYjnb2dQn_TwtgH12a0D4IspLh92HnQtrYU2mF4UnLOiEfRPdCCHVtVSwQcsbIpy_wwwr dltWQc4sPD229tJbY.averTISk7c9MtlOc4ai3ZmrUhNlv9YANCgCu0WtwB.VSP27JjBb4R0jEpm XBP8bQymQOA7DYZB6oIHKDpxXwx0e2bgtSXSEoOGzoHyB.6bjIDDqZ75vDUavmL0x21kvvfuXJFh Gynbbjg5J1iLEy4en0SVm3UAg9DMYVJfwGD5TPsK6KwFSQq8wzuAB3sviexCrmwco1Y1MgE_gzgd xM6mxs82CnDuVQ1FwVgYZkCcubMeeZoGsxYCk_4hwzQuXHQdg1LVvWOi.0qloSo3UhUcV1d6Nuyw SKA7bIkvtq6BjTzxTHwjquGYBD7xjM5g6l0xGfPej2OiQpFSnsnh3F.C4MF4VwzT1vGShoi9Sf4p Xn7FHMqA3kWYzki3BV0nWZPO2LtJi1Mg8v55iJepB2TIw2A3skPA7VV9ioGVjKxgNMJDb1vJZgrl bh6lWTxS0UQotjB97pkTv_KEfpk4wdG2l.TOkwfQae3YHdQ6X37FTomib8ydKQDnFSNHtaiNHrr7 2YkwtCQO981x02vsuw0rK_fmTo3ptcUxblyL1rv2cfGqEN6TiLgqGH_FZj6ZLaIUhJCNQdHrNCJo 5EdijqPHhTn0stVrEr4GjwDWZsaWGrb2Gbk6W2ssBEvX7Rtjx9VvDiSKC285lxBz3qK0v_7PxOQ1 kpAWzA2F94NKC3Qgjae0_ndn8WxJAvsYAdD25RiX6OAUYi91.QZWXTI_Sc_aSmfDrszJKsJL_vCr mpE9aDUROXRZCPXvs3mhNzTGJyrNBFAWH7ad4I6tTgfYKVulR7FI02nYW9j13MkNhW.B6uQQN.rU o8ZpK6ID9WktCIk10ZnP6dKMSgfEc1qUdiDy1YVHGeF7LZNYBQKwNZ0lJUMaUs4lj59Uv1s.dJP. 0XbEM01gI6H.3XjgBXCGHR_65XPXxvO17P1sOuCRXkqx5O8ZnTbc9wMGjP8z0yEoh9Nc7K6ASBpL BG_8SRaDtggAYGRL7BQh0znKGFDmWfttDgRQkgb01g83KYvpFQsL1zNpEPURTTlKEo25Ax0oNGaI apgVfFly6JKJa6clLisAyIkSo.qkqQIv8ajNItZtFWRWRQ6mz_UC0EabyzGtwGjZyQBp8Qi4rAFP exSXbq2QNi48qurysq0JPOksa47zu8FZifiUQINyvYZiq7Lgw8x8uVzjNmEnffs06SL.tTsDYefZ TiW7NHM6Ptt1J55IFdYSNW7jKKKn_8_nK2pmkus0LZP.1S67.5.wYxGrd7ciLSfuP9wQpFYl95ct wpatLnrkpI2gGejpGUSojY8NT2qkkivEYW.LZ6ZSQGjrov4MU2ZcPm5jw4jxaaee3R._nlMCEwkx wcmNvYAy6FC3U5aO6Cr5MJn6JX7E_awlx6SHoaewc5pJQfeWLOsSHIZQYEGVxdU0tHzsFRk1asgq HFa9XIG7awjGbcVG2Ael_9MxWJXfuU5silKUEgpXxexzBFDzIQUx0V0Hlkk3mzJLGQLVf0SrcRGw aKDHdnvmElYJjEl5x289YGuCJSlpyj.DmFlHvui1ENi5jR77zJXDk6VlOd149xYJ9xAEPvthifg8 sbWgYQWYDZk6YaZqDJEW20Nn72MWerAtjNuGH_cp2yriD6JsCszpCAyDFjW_my6QL.2HjzoJQJ7u _CBo.V7hNY9mfglhw3_MfMcWXpnHY8tbgW7wVA4Tgcr2jzghTYZnumPTz3nnYcnDR90Q2cE6HBJK 1E27iMy5U6jjoTj2gbFtFrEY9rynRzPRbc7QBst3NChli_gxqdFwVwRQIAu9u5tF9HJy5C.hTkL8 PCBZSFVoN1Mn4zcekQD89LxOAEvfW2rVzZt57c5Ccw8.S1Lf6kTy793caicY0rVQuivnKe.CmOOa D5uRI3gR2d6IjC5h6MDwOk7H9I2bfYgoUCCVt6SN8A__d1ByQxHTT23zO1WJUmi1hCRuKX7SFR.J p4fLbFUJw1u.Yokzu8WX2swu6KKS0Lh5jkrbFrrV.jx.RN39VUAY1.OmXrN74lTskdaqKdahfKJh aesbW341CSz00 X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Thu, 17 Jun 2021 14:54:51 +0000 Date: Thu, 17 Jun 2021 14:54:49 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" Message-ID: <825092844.1776394.1623941689401@mail.yahoo.com> In-Reply-To: <20210607163003.621-1-ssbssa@yahoo.de> References: <20210607163003.621-1-ssbssa.ref@yahoo.de> <20210607163003.621-1-ssbssa@yahoo.de> Subject: Re: [PATCH 1/3] Refactor keypad calls to tui_set_win_focus_to MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.18469 YMailNorrin X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 14:54:54 -0000 This series is no longer useful, Pedro fixed the mouse problems in a much better way. Hannes Am Montag, 7. Juni 2021, 18:30:55 MESZ hat Hannes Domani via Gdb-patches Folgendes geschrieben: > Previously it always was called after tui_set_win_focus_to, except it was > missing in tui_apply_current_layout. > > gdb/ChangeLog: > > 2021-06-07=C2=A0 Hannes Domani=C2=A0 > >=C2=A0=C2=A0=C2=A0=C2=A0 * tui/tui-data.c (tui_set_win_focus_to): Add keyp= ad call. >=C2=A0=C2=A0=C2=A0=C2=A0 * tui/tui-win.c (tui_set_focus_command): Remove k= eypad call. >=C2=A0=C2=A0=C2=A0=C2=A0 * tui/tui.c (tui_rl_other_window): Likewise. >=C2=A0=C2=A0=C2=A0=C2=A0 (tui_enable): Likewise. > --- > gdb/tui/tui-data.c | 5 +++++ > gdb/tui/tui-win.c=C2=A0 | 1 - > gdb/tui/tui.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 2 -- > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c > index 691459abe2a..89afdb429ba 100644 > --- a/gdb/tui/tui-data.c > +++ b/gdb/tui/tui-data.c > @@ -22,6 +22,7 @@ > #include "defs.h" > #include "symtab.h" > #include "tui/tui.h" > +#include "tui/tui-command.h" > #include "tui/tui-data.h" > #include "tui/tui-win.h" > #include "tui/tui-wingeneral.h" > @@ -69,6 +70,10 @@ tui_set_win_focus_to (struct tui_win_info *win_info) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_unhighlight_win (win_with_focus); >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 win_with_focus =3D win_info; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_highlight_win (win_info); > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Enable the keypad if any window except= the command window has > +=C2=A0=C2=A0=C2=A0 the focus.=C2=A0 */ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 keypad (TUI_CMD_WIN->handle.get (), win_i= nfo !=3D TUI_CMD_WIN); >=C2=A0=C2=A0=C2=A0=C2=A0 } > } > > diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c > index 4e75a66a00e..094b503eae8 100644 > --- a/gdb/tui/tui-win.c > +++ b/gdb/tui/tui-win.c > @@ -703,7 +703,6 @@ tui_set_focus_command (const char *arg, int from_tty) >=C2=A0=C2=A0=C2=A0=C2=A0 error (_("Window \"%s\" is not visible"), arg); > >=C2=A0=C2=A0 tui_set_win_focus_to (win_info); > -=C2=A0 keypad (TUI_CMD_WIN->handle.get (), win_info !=3D TUI_CMD_WIN); >=C2=A0=C2=A0 printf_filtered (_("Focus set to %s window.\n"), >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_win_with_= focus ()->name ()); > } > diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c > index 529fc62c9ac..394c357cebb 100644 > --- a/gdb/tui/tui.c > +++ b/gdb/tui/tui.c > @@ -181,7 +181,6 @@ tui_rl_other_window (int count, int key) >=C2=A0=C2=A0 if (win_info) >=C2=A0=C2=A0=C2=A0=C2=A0 { >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_set_win_focus_to (win_info); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 keypad (TUI_CMD_WIN->handle.get (), win_i= nfo !=3D TUI_CMD_WIN); >=C2=A0=C2=A0=C2=A0=C2=A0 } >=C2=A0=C2=A0 return 0; > } > @@ -439,7 +438,6 @@ tui_enable (void) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_show_frame_info (0); >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_set_initial_layout (); >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_set_win_focus_to (TUI_SRC_WIN); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 keypad (TUI_CMD_WIN->handle.get (), TRUE)= ; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wrefresh (TUI_CMD_WIN->handle.get ())= ; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_finish_init =3D false; >=C2=A0=C2=A0=C2=A0=C2=A0 } > -- > 2.31.1