From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id E2C5F3858294 for ; Fri, 8 Dec 2023 16:51:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2C5F3858294 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2C5F3858294 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702054315; cv=none; b=pGDj+kH2XHy3p21icmYetScuc0W8oa1WaoNdAKTc3oK/zwYWLHqutXy4Fgc50m3xKpPTs9W2EkzgJgzI5BLAug28epBMp2Xtn/sCc3w6137xViSfjUhn9MUr/1V31YRhocy6uQkbPv49o17WL7y+/Qng5ndgjFuLyJcWSZq9fXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702054315; c=relaxed/simple; bh=ZTjyIeHdSGRQMleo8tR+WkFr7bOQ/6v8C4xBB8GqpVs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=m+3RBazjO2lnhrt3afsxPrmgNeqhqGMbs7LVpyK8oz6sqn8SbULL6A4IjVJFMS3mFiCj87+WdQxsHBKha/VL5Z1+8Ss72nsCUx88/vyA5Os1LZaAENtNNc7yxfo1IH5Z988zw/zmGGZD2y8xtC9AAEIRvoDgyw9ZX7LaNnZXnAo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C9B7D21C49; Fri, 8 Dec 2023 16:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702054303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1nU65cZXahyTx9Q8M4yyspD0VdpExiZLr8zBOKTCZMs=; b=njbWljEPWUU43jeFbH/ezhbtt3vDOOInaMol/E6OCPx9nZ7XqWplJu7gcS/Qq6qEHZ+n4N y8S/gp8i9QveKWHEjsUP1hl1gBYBAbrQmf7SXIY/FDW/9tF8DCx4y+d1YaDW5hK+HTGvcx 0ZwqOdqZDMvC0U3eOUztsMNJ+zju6C4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702054303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1nU65cZXahyTx9Q8M4yyspD0VdpExiZLr8zBOKTCZMs=; b=ZMgVJUFGmcdhNfeh0tqtejMtjM2p9X2WqzH2KC8sGOAEHhf+9oNBADbPwRowvcltEWPPGx NpVFNXDeOGmyT1BA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702054303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1nU65cZXahyTx9Q8M4yyspD0VdpExiZLr8zBOKTCZMs=; b=njbWljEPWUU43jeFbH/ezhbtt3vDOOInaMol/E6OCPx9nZ7XqWplJu7gcS/Qq6qEHZ+n4N y8S/gp8i9QveKWHEjsUP1hl1gBYBAbrQmf7SXIY/FDW/9tF8DCx4y+d1YaDW5hK+HTGvcx 0ZwqOdqZDMvC0U3eOUztsMNJ+zju6C4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702054303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1nU65cZXahyTx9Q8M4yyspD0VdpExiZLr8zBOKTCZMs=; b=ZMgVJUFGmcdhNfeh0tqtejMtjM2p9X2WqzH2KC8sGOAEHhf+9oNBADbPwRowvcltEWPPGx NpVFNXDeOGmyT1BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B2D2A12FF7; Fri, 8 Dec 2023 16:51:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rbtVKp9Jc2WgEgAAD6G6ig (envelope-from ); Fri, 08 Dec 2023 16:51:43 +0000 Message-ID: <82a262ce-fdcb-4d81-b396-48cb996c7d02@suse.de> Date: Fri, 8 Dec 2023 17:51:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/tui] Show focus window in status line To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231127034534.13593-1-tdevries@suse.de> <87r0jwhfht.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87r0jwhfht.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spam-Score: -1.34 X-Spamd-Result: default: False [-1.45 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.16)[88.84%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Flag: NO X-Spam-Level: X-Spam-Score: -1.45 Authentication-Results: smtp-out1.suse.de; none X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/23 16:37, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> The focused window is highlighting by using active-border-kind instead of > Tom> border-kind. > > Tom> But if the focused window is the cmd window (which is an unboxed window), then > Tom> no highlighting is done, and it's not obvious from looking at the screen which > Tom> window has the focus. Instead, you have to notice the absence of highlighting > Tom> on boxed windows, and then infer that the focus is on the unboxed window. > > Tom> That approach stops working if there are multiple unboxed windows. > > Tom> Likewise if highlighting is switched off by setting active-border-kind to the > Tom> same value as border-kind. > > Tom> Make it more explicit which window has the focus by mentioning it in the status > Tom> window, like so: > Tom> ... > Tom> native process 8282 (src) In: main L7 PC: 0x400525 > Tom> ... > > This seems fine to me, but the contents of the status line are > documented in the "TUI Overview" section, so I think that should be > updated. Thanks for the review. I've sent a v2 with doc added here ( https://sourceware.org/pipermail/gdb-patches/2023-December/204912.html ). Thanks, - Tom