From: Simon Marchi <simon.marchi@polymtl.ca>
To: Magne Hov <mhov@undo.io>, gdb-patches@sourceware.org
Subject: Re: [RFC PATCH] gdb: fix eval.c assert during inferior exit event
Date: Mon, 10 May 2021 13:33:15 -0400 [thread overview]
Message-ID: <82a7ee2a-439b-85ce-2b18-766e0f4f46e3@polymtl.ca> (raw)
In-Reply-To: <5swns6le6u.fsf@undo.io>
>>> +standard_testfile .cc
>>
>> Is C++ really required? I was able to reproduce the bug with your
>> reproducer, but compiled as C. If we can re-use the existing test
>> program for this test (just let it run to completion), it would be
>> simpler and preferable.
>>
>
> I agree that it would be nice to reuse the existing test program. The only
> requirement is that `language_defn->la_language == language_cplus` evaluates to
> true in order to prevent the asserting condition in `eval.c` from being
> short-circuited. We can force this by executing `set language c++`. In my
> revised patch I do this and I have removed the unnecessary program.
Sorry, I thought I tried with the source file as C and saw the bug, but
I no longer see it. I probably tested with the wrong file or something.
Using "set language c++" sounds good.
Simon
next prev parent reply other threads:[~2021-05-10 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 15:56 Magne Hov
2021-05-06 1:59 ` Simon Marchi
2021-05-10 16:57 ` Magne Hov
2021-05-10 17:33 ` Simon Marchi [this message]
2021-05-10 17:21 ` [PATCH v2] " Magne Hov
2021-05-10 17:44 ` Simon Marchi
2021-05-14 16:24 ` Magne Hov
2021-05-11 7:16 ` Aktemur, Tankut Baris
2021-05-14 16:22 ` Magne Hov
2021-05-24 19:23 ` Joel Brobecker
2021-05-26 13:02 ` [PATCH v3] " Magne Hov
2021-05-29 2:25 ` Simon Marchi
2021-06-02 11:34 ` Magne Hov
2021-06-03 21:07 ` Magne Hov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82a7ee2a-439b-85ce-2b18-766e0f4f46e3@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=mhov@undo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).