From: Luis Machado <luis.machado@linaro.org>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH,v3 testsuite] Fix some duplicate test names
Date: Wed, 27 May 2020 09:39:14 -0300 [thread overview]
Message-ID: <82d942ff-efcc-49fd-c763-b57032df13f1@linaro.org> (raw)
In-Reply-To: <a20e4b0d-5139-c513-e7f7-37d103c24e50@redhat.com>
On 5/26/20 5:52 PM, Pedro Alves wrote:
> On 5/26/20 9:23 PM, Luis Machado wrote:
>> On 5/26/20 4:35 PM, Pedro Alves wrote:
>>> On 5/26/20 8:02 PM, Luis Machado via Gdb-patches wrote:
>>>
>>>> @@ -45,10 +45,10 @@ proc break_at { breakpoint where } {
>>>> set test "break $breakpoint"
>>>> set bp 0
>>>> - gdb_test_multiple "$test" "$test" {
>>>> + gdb_test_multiple "$test" "$test inserted as number $bp" {
>>>
>>> As discussed, this change should be backed out, and replaced with
>>> with_test_prefix, right? $bp is always zero here.
>>
>> Ugh... EWRONGPATCH, apologies. I must have mixed up the files when sending. This was already fixed.
>>
>> Follows the updated one (for sure).
>
> OK.
>
> Thanks,
> Pedro Alves
>
Thanks for the review. I've pushed this now.
prev parent reply other threads:[~2020-05-27 12:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:18 [PATCH, " Luis Machado
2020-05-26 15:35 ` Pedro Alves
2020-05-26 17:08 ` Luis Machado
2020-05-26 17:39 ` [PATCH,v2 " Luis Machado
2020-05-26 17:50 ` Pedro Alves
2020-05-26 18:42 ` Luis Machado
2020-05-26 18:53 ` Pedro Alves
2020-05-26 19:02 ` [PATCH,v3 " Luis Machado
2020-05-26 19:35 ` Pedro Alves
2020-05-26 20:23 ` Luis Machado
2020-05-26 20:52 ` Pedro Alves
2020-05-27 12:39 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82d942ff-efcc-49fd-c763-b57032df13f1@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).