From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH v2 0/4] Use checked_static_cast for breakpoint casts
Date: Tue, 19 Sep 2023 10:00:48 -0400 [thread overview]
Message-ID: <82ef90d4-6d80-49f8-b2c6-5be1b755da46@polymtl.ca> (raw)
In-Reply-To: <20230918-watchpoint-casts-v2-0-f636ec38fdc4@adacore.com>
On 9/18/23 10:25, Tom Tromey via Gdb-patches wrote:
> While reviewing a patch, I noticed some unchecked casts to watchpoint.
> This series replaces all the unchecked breakpoint casts I could find
> with checked casts.
Thanks, LGTM.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2023-09-19 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 14:25 Tom Tromey
2023-09-18 14:25 ` [PATCH v2 1/4] Use gdb::checked_static_cast for watchpoints Tom Tromey
2023-09-18 14:25 ` [PATCH v2 2/4] Use gdb::checked_static_cast for tracepoints Tom Tromey
2023-09-18 14:25 ` [PATCH v2 3/4] Use gdb::checked_static_cast for code_breakpoint Tom Tromey
2023-09-18 14:25 ` [PATCH v2 4/4] Use gdb::checked_static_cast for catchpoints Tom Tromey
2023-09-19 14:00 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82ef90d4-6d80-49f8-b2c6-5be1b755da46@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).