From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 5DB5A3858296 for ; Sat, 26 Nov 2022 13:19:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DB5A3858296 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6C35F21B46; Sat, 26 Nov 2022 13:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669468785; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vkwz3zY39BcbIDfWLaSRHmP+SUxO013oZfyz71DmpTg=; b=T3FQLUvyInLjYqMkpBB0vFA76rT2QlwH8JpYcxZuwsYfxc056j4qD6NKPvfswLG43WIZL/ fbTFTEhvlkSGCM/FCSSTl3IDR88RLEvOcs4dtbmn6VLnmADPX0vQ9gdQFvLnOKEy3OBMxv 6M3UU5E8O7U5emVnTcIJVrOtUpNn0W0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669468785; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vkwz3zY39BcbIDfWLaSRHmP+SUxO013oZfyz71DmpTg=; b=v51p6PEHMJR5uagWcoy1hGrSD3zy3SoU5bheZMSR3OXo1zp6eYqiY5S87kndGrSveTHSRf /RhW9uCxiFLLYcBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DAC1713A8D; Sat, 26 Nov 2022 13:19:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id O6eXK3ASgmMmCwAAMHmgww (envelope-from ); Sat, 26 Nov 2022 13:19:44 +0000 Content-Type: multipart/mixed; boundary="------------rHQV06CU55IhLrJNx6nUw90K" Message-ID: <83060e68-f94e-459c-8b99-77ddadf4c4c7@suse.de> Date: Sat, 26 Nov 2022 14:19:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] [gdb/symtab] Handle failure to open .gnu_debugaltlink file To: gdb-patches@sourceware.org Cc: Tom Tromey References: <20221119103216.19369-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: <20221119103216.19369-1-tdevries@suse.de> X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------rHQV06CU55IhLrJNx6nUw90K Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/19/22 11:32, Tom de Vries via Gdb-patches wrote: I've added a test-case and committed as below. Thanks, - Tom --------------rHQV06CU55IhLrJNx6nUw90K Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-symtab-Handle-failure-to-open-.gnu_debugaltlink-.patch" Content-Disposition: attachment; filename*0="0001-gdb-symtab-Handle-failure-to-open-.gnu_debugaltlink-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBkNWJjYjQ1OGE5YjMxNTBhYWU1NWJhODA1YmM5NGQ0NDUwYjYyYzYzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFNhdCwgMTkgTm92IDIwMjIgMDc6NDQ6MTUgKzAxMDAKU3ViamVjdDogW3B1c2hl ZF0gW2dkYi9zeW10YWJdIEhhbmRsZSBmYWlsdXJlIHRvIG9wZW4gLmdudV9kZWJ1Z2FsdGxp bmsgZmlsZQoKSWYgd2UgaW5zdHJ1bWVudCBjYy13aXRoLXR3ZWFrcy5zaCB0byByZW1vdmUg dGhlIC5nbnVfZGVidWdhbHRsaW5rIGZpbGUgYWZ0ZXIKZHd6IGhhcyBjcmVhdGVkIGl0LCB3 aXRoIHRlc3QtY2FzZQpnZGIudGhyZWFkcy9hY2Nlc3MtbWVtLXJ1bm5pbmctdGhyZWFkLWV4 aXQuZXhwIGFuZCB0YXJnZXQgYm9hcmQgY2Mtd2l0aC1kd3otbQp3ZSBydW4gaW50bzoKLi4u CihnZGIpIGZpbGUgYWNjZXNzLW1lbS1ydW5uaW5nLXRocmVhZC1leGl0Xk0KUmVhZGluZyBz eW1ib2xzIGZyb20gYWNjZXNzLW1lbS1ydW5uaW5nLXRocmVhZC1leGl0Li4uXk0KY291bGQg bm90IGZpbmQgJy5nbnVfZGVidWdhbHRsaW5rJyBmaWxlIGZvciBhY2Nlc3MtbWVtLXJ1bm5p bmctdGhyZWFkLWV4aXReTQouLi4KZm9sbG93ZWQgYSBiaXQgbGF0ZXIgYnk6Ci4uLgooZ2Ri KSBmaWxlIGFjY2Vzcy1tZW0tcnVubmluZy10aHJlYWQtZXhpdF5NClJlYWRpbmcgc3ltYm9s cyBmcm9tIGFjY2Vzcy1tZW0tcnVubmluZy10aHJlYWQtZXhpdC4uLl5NCmdkYi9kd2FyZjIv cmVhZC5jOjcyODQ6IGludGVybmFsLWVycm9yOiBjcmVhdGVfYWxsX3VuaXRzOiBcCiAgQXNz ZXJ0aW9uIGBwZXJfb2JqZmlsZS0+cGVyX2JmZC0+YWxsX3VuaXRzLmVtcHR5ICgpJyBmYWls ZWQuXk0KLi4uCgpUaGUgcHJvYmxlbSBpcyB0aGF0IGNyZWF0ZV91bml0cyBkb2VzIG5vdCBj YXRjaCB0aGUgZXJyb3IgdGhyb3duIGJ5CmR3YXJmMl9nZXRfZHd6X2ZpbGUuCgpGaXggdGhp cyBieSBjYXRjaGluZyB0aGUgZXJyb3IgYW5kIHBlcmZvcm1pbmcgdGhlIG5lY2Vzc2FyeSBj bGVhbnVwLCBnZXR0aW5nCnRoZSBzYW1lIHJlc3VsdCBmb3IgdGhlIGZpcnN0IGFuZCBzZWNv bmQgZmlsZSBjb21tYW5kLgoKUFIgc3ltdGFiLzI5ODA1CkJ1ZzogaHR0cHM6Ly9zb3VyY2V3 YXJlLm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9Mjk4MDUKLS0tCiBnZGIvZHdhcmYy L3JlYWQuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMSArKysrLQogZ2RiL3Rl c3RzdWl0ZS9nZGIuZHdhcmYyL25vLWdudS1kZWJ1Z2xpbmsuZXhwIHwgNDggKysrKysrKysr KysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA1OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgZ2RiL3Rlc3RzdWl0ZS9nZGIuZHdhcmYyL25v LWdudS1kZWJ1Z2xpbmsuZXhwCgpkaWZmIC0tZ2l0IGEvZ2RiL2R3YXJmMi9yZWFkLmMgYi9n ZGIvZHdhcmYyL3JlYWQuYwppbmRleCA2MGUxMjBhOWQ3Ni4uNTNhNmE4YjVlNmQgMTAwNjQ0 Ci0tLSBhL2dkYi9kd2FyZjIvcmVhZC5jCisrKyBiL2dkYi9kd2FyZjIvcmVhZC5jCkBAIC03 MjkxLDcgKzcyOTEsMTYgQEAgY3JlYXRlX2FsbF91bml0cyAoZHdhcmYyX3Blcl9vYmpmaWxl ICpwZXJfb2JqZmlsZSkKIAkJCQkgICZwZXJfb2JqZmlsZS0+cGVyX2JmZC0+YWJicmV2LCAw LAogCQkJCSAgdHlwZXNfaHRhYiwgcmN1aF9raW5kOjpUWVBFKTsKIAotICBkd3pfZmlsZSAq ZHd6ID0gZHdhcmYyX2dldF9kd3pfZmlsZSAocGVyX29iamZpbGUtPnBlcl9iZmQpOworICBk d3pfZmlsZSAqZHd6OworICB0cnkKKyAgICB7CisgICAgICBkd3ogPSBkd2FyZjJfZ2V0X2R3 el9maWxlIChwZXJfb2JqZmlsZS0+cGVyX2JmZCk7CisgICAgfQorICBjYXRjaCAoY29uc3Qg Z2RiX2V4Y2VwdGlvbl9lcnJvciAmKQorICAgIHsKKyAgICAgIHBlcl9vYmpmaWxlLT5wZXJf YmZkLT5hbGxfdW5pdHMuY2xlYXIgKCk7CisgICAgICB0aHJvdzsKKyAgICB9CiAgIGlmIChk d3ogIT0gTlVMTCkKICAgICB7CiAgICAgICAvKiBQcmUtcmVhZCB0aGUgc2VjdGlvbnMgd2Un bGwgbmVlZCB0byBjb25zdHJ1Y3QgYW4gaW5kZXguICAqLwpkaWZmIC0tZ2l0IGEvZ2RiL3Rl c3RzdWl0ZS9nZGIuZHdhcmYyL25vLWdudS1kZWJ1Z2xpbmsuZXhwIGIvZ2RiL3Rlc3RzdWl0 ZS9nZGIuZHdhcmYyL25vLWdudS1kZWJ1Z2xpbmsuZXhwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwLi43M2Y3MjMzMTkyZQotLS0gL2Rldi9udWxsCisrKyBiL2dk Yi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9uby1nbnUtZGVidWdsaW5rLmV4cApAQCAtMCwwICsx LDQ4IEBACisjIENvcHlyaWdodCAyMDIyIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5j LgorCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJp YnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNv ZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9y CisjIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJv Z3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVs LAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGll ZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNl IGZvciBtb3JlIGRldGFpbHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNv cHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGggdGhp cyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+ LgorCisjIENoZWNrIHRoYXQgbG9hZGluZyBhIGZpbGUgd2l0aCBhIGJyb2tlbiAuZ251X2Rl YnVnYWx0bGluayBkb2Vzbid0IGNyYXNoIGdkYi4KKworbG9hZF9saWIgZHdhcmYuZXhwCisK KyMgVGhpcyB0ZXN0IGNhbiBvbmx5IGJlIHJ1biBvbiB0YXJnZXRzIHdoaWNoIHN1cHBvcnQg RFdBUkYtMiBhbmQgdXNlIGdhcy4KK2lmIHshW2R3YXJmMl9zdXBwb3J0XX0geworICAgIHJl dHVybiAwCit9CisKKyMgTm8gcmVtb3RlIGhvc3QgdGVzdGluZyBlaXRoZXIuCitpZiB7W2lz X3JlbW90ZSBob3N0XX0geworICAgIHJldHVybiAwCit9CisKK3N0YW5kYXJkX3Rlc3RmaWxl IG1haW4uYyBuby1nbnUtZGVidWdsaW5rLlMKKworc2V0IGFzbV9maWxlIFtzdGFuZGFyZF9v dXRwdXRfZmlsZSAkc3JjZmlsZTJdCisKK0R3YXJmOjphc3NlbWJsZSAkYXNtX2ZpbGUgewor ICAgIGdudV9kZWJ1Z2FsdGxpbmsgImZpbGUtbm90LWhlcmUiICIwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwIgorfQorCitpZiB7IFtidWlsZF9leGVjdXRhYmxl ICR0ZXN0ZmlsZS5leHAgJHRlc3RmaWxlIFtsaXN0ICRzcmNmaWxlICRhc21fZmlsZV1dIH0g eworICAgIHJldHVybiAtMQorfQorCitjbGVhbl9yZXN0YXJ0CisKK3NldCBtc2cgIlxyXG5j b3VsZCBub3QgZmluZCAnXC5nbnVfZGVidWdhbHRsaW5rJyBmaWxlIGZvciBcW15cclxuXF0q IgorZ2RiX3Rlc3QgImZpbGUgJGJpbmZpbGUiICIkbXNnIiAiZmlsZSBjb21tYW5kIgorCitz ZXQgcXVlc3Rpb24gIkxvYWQgbmV3IHN5bWJvbCB0YWJsZSBmcm9tIC4qXD8gLnkgb3Igbi4g IgorZ2RiX3Rlc3QgImZpbGUgJGJpbmZpbGUiICIkbXNnIiAiZmlsZSBjb21tYW5kLCBhZ2Fp biIgJHF1ZXN0aW9uICJ5IgoKYmFzZS1jb21taXQ6IDE0YWUyODVmMzQ0ZmU3NmFmZjFkMGRh ODM2NmNkNTQ1OTlhZWE3MzAKLS0gCjIuMzUuMwoK --------------rHQV06CU55IhLrJNx6nUw90K--