From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108383 invoked by alias); 29 Oct 2018 18:13:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108372 invoked by uid 89); 29 Oct 2018 18:13:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Oct 2018 18:13:49 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FFB63DD47; Mon, 29 Oct 2018 18:13:48 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4703B2937D; Mon, 29 Oct 2018 18:13:47 +0000 (UTC) Subject: Re: [PATCH v3 3/3] Aarch64: Fix segfault when casting dummy calls To: Alan Hayward References: <20181011144905.66908-1-alan.hayward@arm.com> <20181011144905.66908-4-alan.hayward@arm.com> <95a5dd34-6815-f3f5-107c-13f4956b741e@redhat.com> <9290BC71-862C-48B1-97FD-A46C5D15A65C@arm.com> <201c7a49-ddf3-636a-f15a-eb9a4ccf284e@redhat.com> <3FFDA486-3FC8-4DA2-92C9-83C320F589F6@arm.com> <862cf8f4-9491-a1eb-251e-6c7c1ffffa6c@redhat.com> Cc: GDB Patches , nd From: Pedro Alves Message-ID: <830e7c3b-3469-6cea-61d1-5a1e7e230de1@redhat.com> Date: Mon, 29 Oct 2018 18:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-10/txt/msg00697.txt.bz2 On 10/29/2018 02:56 PM, Alan Hayward wrote: > A-ha! Now I understand why I get two calls into _push_dummy_call. > > So to answer your question, the TYPE_CODE_PTR->TYPE_CODE_INT is the malloc call. > > Then the next call to _push_dummy_call has a return type of 0, as expected. > This doesn’t segfault because it goes into language_pass_by_reference which > routes to default_pass_by_reference. The same as the C shared library version. > > > I’ve updated the test so it does {c,c++}*{debug nodebug}. > I can also update it to do both shared lib and non shared lib too. That should > cover everything. But still, why do you see a difference between shared library and non-shared library? Thanks, Pedro Alves