From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Q5cO=BF=gnu.org=eliz@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id 4B6073858C20
	for <gdb-patches@sourceware.org>; Tue, 16 May 2023 02:27:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B6073858C20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pykPX-0008SY-Vz; Mon, 15 May 2023 22:27:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=xl+edLvGkEYFqC+VM2Ibo3ELDJyAUWpwIbkpyJM0658=; b=C8PQAzwC0hpV
	rdQpIyfvGQlMg0lBzamMfkEoOaGMaFv79exizCPAzQqySeDS1n6/MXuJbZc4YhdyPIaZR+IjvcKDv
	xYmywEChtLIzeNEn2vGHkZIBq7dwi2RDdprMORnA57tRZ8IIytKIkyH+5ryRxPM9jMhlaf4fsn82y
	RZhpG6dBqMSlFuedFUFZkkPhBQzciKpBvF+i1gU/vNo9L5FoHT/sDhij45CrlT1fe7URtzPiQnt8m
	anEdjIsrfTycjBVeTuMswmTel5Nb3reAWAFIw7Z8ldYaMbt9tJ9l1fPSsuY+ehPBluzXj+J1h8Jsc
	Jjmo6X+JWHIibXqxhiD8Gg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pykPX-0001qk-4Q; Mon, 15 May 2023 22:27:35 -0400
Date: Tue, 16 May 2023 05:27:40 +0300
Message-Id: <831qjh104j.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Merey <amerey@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To:
	<CAJDtP-SZ3-vVOHvXSBim1iuQsEhWB3XiS5OfYphderO-rqw-zw@mail.gmail.com>
	(message from Aaron Merey on Mon, 15 May 2023 17:32:48 -0400)
Subject: Re: [PATCH] gdb/cli-out.c: clear_current_line shouldn't trigger
 pagination prompt
References: <20230511232203.247173-1-amerey@redhat.com> <83h6si3vva.fsf@gnu.org> <CAJDtP-SZ3-vVOHvXSBim1iuQsEhWB3XiS5OfYphderO-rqw-zw@mail.gmail.com>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

> From: Aaron Merey <amerey@redhat.com>
> Date: Mon, 15 May 2023 17:32:48 -0400
> Cc: gdb-patches@sourceware.org
> 
> > I'm not sure we should rely on the fact that the final character of
> > the line is never there.  clear_current_line is a general-purpose
> > method, so it should do its job regardless.
> >
> > Can't we do something to handle the last character as well?  E.g.,
> > could it be possible first to delete one character, so there are
> > really only N-1 characters to fill with blank spaces?
> 
> We could rename clear_current_line to something like clear_progress_notify
> to help indicate that this is a special purpose function.  We could also
> just disable pagination for the duration of clear_current_line.

I think we should do both, thanks.