From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 519EB3842AEA
 for <gdb-patches@sourceware.org>; Thu, 30 Jun 2022 13:46:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 519EB3842AEA
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50122)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1o6uUp-0005ai-Lj; Thu, 30 Jun 2022 09:46:15 -0400
Received: from [87.69.77.57] (port=3309 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1o6uUp-0007dj-2z; Thu, 30 Jun 2022 09:46:15 -0400
Date: Thu, 30 Jun 2022 16:46:24 +0300
Message-Id: <831qv65knj.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <87a69ucpdo.fsf@redhat.com> (message from Andrew Burgess on Thu, 
 30 Jun 2022 13:22:27 +0100)
Subject: Re: [PATCH 2/2] gdb: add support for disassembler styling using
 libopcodes
References: <cover.1655462053.git.aburgess@redhat.com>
 <eb9059907131fd9acb37ead1b4fc8aa9ff7a1e18.1655462053.git.aburgess@redhat.com>
 <835ykzpmjz.fsf@gnu.org> <87a69ucpdo.fsf@redhat.com>
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2022 13:46:17 -0000

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 30 Jun 2022 13:22:27 +0100
> 
> Thanks for your feedback.  The updated patch below I believe addresses
> all these issues.

It does, thanks.  One last nit:

> +  disasm_mnemonic_style.add_setshow_commands (no_class, _("\
> +Disassembler mnemonic display styling.\n\
> +Configure the colors and display intensity for instruction mnemonics\n\
> +in the disassembler output.  The \"disassembler mnemonic\" style is\n\
> +used to displaying instruction mnemonics as well as any assembler\n\
        ^^^^^^^^^^^^^
Either "to display" or "for displaying".