From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@palves.net>
Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org,
simon.marchi@efficios.com
Subject: Re: [PATCH v2] gdbsupport: add path_join function
Date: Wed, 20 Apr 2022 15:45:00 +0300 [thread overview]
Message-ID: <831qxrudo3.fsf@gnu.org> (raw)
In-Reply-To: <c1c1da46-738e-102b-9218-0d88fd1fb881@palves.net> (message from Pedro Alves on Wed, 20 Apr 2022 13:38:08 +0100)
> Date: Wed, 20 Apr 2022 13:38:08 +0100
> Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org,
> simon.marchi@efficios.com
> From: Pedro Alves <pedro@palves.net>
>
> On 2022-04-20 13:35, Eli Zaretskii wrote:
>
> >> " (...) joining with an absolute path on the right hand side, like this:
> >>
> >> path_join ("/foo", "/bar");
> >>
> >> results in just the right hand side being kept. In this example, the
> >> result is "/bar".
> >> "
> >
> > Or maybe I've lost the track of the discussion, since the above
> > doesn't sound consistent with what I though this function should do.
> > Did we switch the concept at some point?
>
> Yes, we did. This is mentioned in the the commit log of the v2 patch, where
> the snippet above was copied from.
Sorry for missing that. But that brings in a whole new bunch of
issues. For example, what should the below yield on MS-Windows?
path_join ("C:\\foo", "\\\\host\\share");
Or what about the one below?
path_join ("d:/foo/bar", "d:quux");
IOW, do we really want this function to become as complex as
expand-file-name in Emacs?
next prev parent reply other threads:[~2022-04-20 12:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 0:20 Simon Marchi
2022-04-20 6:08 ` Eli Zaretskii
2022-04-20 11:52 ` Pedro Alves
2022-04-20 12:35 ` Eli Zaretskii
2022-04-20 12:38 ` Pedro Alves
2022-04-20 12:45 ` Eli Zaretskii [this message]
2022-04-20 13:12 ` Pedro Alves
2022-04-20 14:45 ` Simon Marchi
2022-04-20 15:57 ` Eli Zaretskii
2022-04-20 16:11 ` Simon Marchi
2022-04-20 16:47 ` Eli Zaretskii
2022-04-20 17:31 ` Pedro Alves
2022-04-20 17:22 ` Pedro Alves
2022-04-20 17:35 ` Simon Marchi
2022-04-20 17:44 ` Pedro Alves
2022-04-20 14:55 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qxrudo3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).