From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] gdbsupport: add path_join function
Date: Mon, 18 Apr 2022 21:30:08 +0300 [thread overview]
Message-ID: <831qxuw8gf.fsf@gnu.org> (raw)
In-Reply-To: <c9629980-853e-b284-60d5-f0ad24053b9d@polymtl.ca> (message from Simon Marchi on Mon, 18 Apr 2022 14:11:34 -0400)
> Date: Mon, 18 Apr 2022 14:11:34 -0400
> Cc: gdb-patches@sourceware.org
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> > Suggest to add a couple of Windows-specific tests here: one which
> > starts with "d:/" instead of just "/", and another with backslashes.
>
> Should these tests only be ran on Windows hosts?
Yes, I think so.
> > I think this should use IS_DIR_SEPARATOR (or override the '=' and '!='
> > operators), to support Windows file names with backslashes.
>
> Changed both instances of '/' to use IS_DIR_SEPARATOR.
Thanks.
next prev parent reply other threads:[~2022-04-18 18:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 20:01 [PATCH 1/5] gdb: call gdb_tilde_expand instead of gdb_tilde_expand_up in source_script_with_search Simon Marchi
2022-04-14 20:01 ` [PATCH 2/5] gdbsupport: make gdb_abspath return an std::string Simon Marchi
2022-04-18 19:41 ` Tom Tromey
2022-04-18 20:09 ` Pedro Alves
2022-04-18 20:11 ` Simon Marchi
2022-04-14 20:01 ` [PATCH 3/5] gdbsupport: make gdb_realpath_keepfile " Simon Marchi
2022-04-18 19:44 ` Tom Tromey
2022-04-14 20:01 ` [PATCH 4/5] gdb: use gdb_tilde_expand instead of gdb_tilde_expand_up in source_script_with_search Simon Marchi
2022-04-18 19:44 ` Tom Tromey
2022-04-18 20:12 ` Simon Marchi
2022-04-14 20:01 ` [PATCH 5/5] gdbsupport: add path_join function Simon Marchi
2022-04-15 5:59 ` Eli Zaretskii
2022-04-18 18:11 ` Simon Marchi
2022-04-18 18:30 ` Eli Zaretskii [this message]
2022-04-18 19:24 ` Pedro Alves
2022-04-15 14:38 ` Lancelot SIX
2022-04-15 16:55 ` Lancelot SIX
2022-04-18 18:43 ` Simon Marchi
2022-04-18 19:09 ` Pedro Alves
2022-04-18 19:12 ` Simon Marchi
2022-04-18 20:55 ` Simon Marchi
2022-04-18 21:07 ` Pedro Alves
2022-04-19 0:19 ` Simon Marchi
2022-04-18 19:22 ` Pedro Alves
2022-04-18 20:01 ` Tom Tromey
2022-04-18 23:11 ` Lancelot SIX
2022-04-20 0:22 ` Simon Marchi
2022-04-18 19:36 ` [PATCH 1/5] gdb: call gdb_tilde_expand instead of gdb_tilde_expand_up in source_script_with_search Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qxuw8gf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).