From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 6C2B63858D1E
 for <gdb-patches@sourceware.org>; Mon, 18 Apr 2022 18:30:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C2B63858D1E
Received: from fencepost.gnu.org ([2001:470:142:3::e]:49138)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ngW95-0005nK-M8; Mon, 18 Apr 2022 14:30:44 -0400
Received: from [87.69.77.57] (port=2188 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ngW8k-0003IK-8i; Mon, 18 Apr 2022 14:30:41 -0400
Date: Mon, 18 Apr 2022 21:30:08 +0300
Message-Id: <831qxuw8gf.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <c9629980-853e-b284-60d5-f0ad24053b9d@polymtl.ca> (message from
 Simon Marchi on Mon, 18 Apr 2022 14:11:34 -0400)
Subject: Re: [PATCH 5/5] gdbsupport: add path_join function
References: <20220414200137.3479373-1-simon.marchi@polymtl.ca>
 <20220414200137.3479373-5-simon.marchi@polymtl.ca> <83h76u3n04.fsf@gnu.org>
 <c9629980-853e-b284-60d5-f0ad24053b9d@polymtl.ca>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Apr 2022 18:30:46 -0000

> Date: Mon, 18 Apr 2022 14:11:34 -0400
> Cc: gdb-patches@sourceware.org
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> > Suggest to add a couple of Windows-specific tests here: one which
> > starts with "d:/" instead of just "/", and another with backslashes.
> 
> Should these tests only be ran on Windows hosts?

Yes, I think so.

> > I think this should use IS_DIR_SEPARATOR (or override the '=' and '!='
> > operators), to support Windows file names with backslashes.
> 
> Changed both instances of '/' to use IS_DIR_SEPARATOR.

Thanks.