From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 18FF23858C3A
 for <gdb-patches@sourceware.org>; Sun,  6 Feb 2022 16:41:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18FF23858C3A
Received: from [2001:470:142:3::e] (port=60194 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nGkbR-0007NG-Ts; Sun, 06 Feb 2022 11:41:29 -0500
Received: from [87.69.77.57] (port=2525 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nGkbR-0004Nd-CR; Sun, 06 Feb 2022 11:41:29 -0500
Date: Sun, 06 Feb 2022 18:41:13 +0200
Message-Id: <831r0gyml2.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, torbjorn.svensson@st.com
In-Reply-To: <Yf/06P1kpPotdgrX@adacore.com> (message from Joel Brobecker via
 Gdb-patches on Sun, 6 Feb 2022 17:18:48 +0100)
Subject: Re: [PATCH v2 5/5] gdb/arm: Extend arm_m_addr_is_magic to support
 FNC_RETURN, add unwind-ns-to-s command
References: <20220127133247.440019-1-christophe.lyon@foss.st.com>
 <20220127133247.440019-5-christophe.lyon@foss.st.com>
 <Yf/06P1kpPotdgrX@adacore.com>
X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Feb 2022 16:41:33 -0000

> Date: Sun, 6 Feb 2022 17:18:48 +0100
> From: Joel Brobecker via Gdb-patches <gdb-patches@sourceware.org>
> Cc: torbjorn.svensson@st.com, Joel Brobecker <brobecker@adacore.com>
> 
> Note that the NEWS patch need a review from Eli Z.
> 
> A few comments and questions.
> 
> > 
> > Co-Authored-By: Torbjorn Svensson <torbjorn.svensson@st.com>
> > ---
> >  gdb/NEWS            |   5 +
> >  gdb/arm-tdep.c      | 341 ++++++++++++++++++++++++++++++++++++--------
> >  gdb/doc/gdb.texinfo |  11 ++
> >  3 files changed, 295 insertions(+), 62 deletions(-)

The documentation parts are fine with me, although unwind-ns-to-s
sounds a bit too cryptic to me.

Thanks.