From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id CD0EE3858439
 for <gdb-patches@sourceware.org>; Thu,  4 Nov 2021 18:52:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD0EE3858439
Received: from fencepost.gnu.org ([2001:470:142:3::e]:52146)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mihqt-0004WL-D7; Thu, 04 Nov 2021 14:52:43 -0400
Received: from [87.69.77.57] (port=1283 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mihqs-0005R1-VR; Thu, 04 Nov 2021 14:52:43 -0400
Date: Thu, 04 Nov 2021 20:52:38 +0200
Message-Id: <831r3vg3d5.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20211104173751.3029898-3-tromey@adacore.com> (message from Tom
 Tromey via Gdb-patches on Thu, 4 Nov 2021 11:37:51 -0600)
Subject: Re: [PATCH 2/2] Implement 'task apply'
References: <20211104173751.3029898-1-tromey@adacore.com>
 <20211104173751.3029898-3-tromey@adacore.com>
X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Nov 2021 18:52:45 -0000

> Date: Thu,  4 Nov 2021 11:37:51 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index b6331d5585f..3ae65b17f07 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS

This part is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo

This is also okay, with one comment:

> +The @var{flag} arguments control what output to produce and how to
> +handle errors raised when applying @var{command} to a task.
> +@var{flag} must start with a @code{-} directly followed by one letter
> +in @code{qcs}.  If several flags are provided, they must be given
> +individually, such as @code{-c -q}.
> +
> +By default, @value{GDBN} displays some task information before the
> +output produced by @var{command}, and an error raised during the
> +execution of a @var{command} will abort @code{task apply}.  The
> +following flags can be used to fine-tune this behavior:

There seems to be some redundancy between these two paragraphs.  Given
the detailed description that follows the second paragraph, I wonder
whether the first one is at all needed.

Thanks.