From: Eli Zaretskii <eliz@gnu.org>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/2] [PR gdb/22640] ptype: add option to use hexadecimal notation
Date: Sat, 24 Apr 2021 09:15:26 +0300 [thread overview]
Message-ID: <831rb0nr7l.fsf@gnu.org> (raw)
In-Reply-To: <20210423222838.41119-3-lsix@lancelotsix.com> (message from Lancelot SIX via Gdb-patches on Fri, 23 Apr 2021 23:28:38 +0100)
> Date: Fri, 23 Apr 2021 23:28:38 +0100
> From: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Lancelot SIX <lsix@lancelotsix.com>
>
> gdb/ChangeLog:
>
> PR gdb/22640
> * typeprint.h (struct type_print_options): Add print_in_hex
> flag.
> (struct print_offset_data): Add print_in_hex flag, add a
> constructor accepting a type_print_options* argument.
> * typeprint.c (type_print_raw_options, default_ptype_flags): Set
> default value for print_in_hex.
> (print_offset_data::indentation): Allow more horizontal space.
> (print_offset_data::print_offset_data): Add ctor.
> (print_offset_data::maybe_print_hole, print_offset_data::update):
> Handle the print_in_hex flag.
> (whatis_exp): Handle 'x' and 'd' flags.
> (print_offsets_and_sizes_in_hex): Declare.
> (set_print_offsets_and_sizes_in_hex): Create.
> (show_print_offsets_and_sizes_in_hex): Create.
> (_initialize_typeprint): Update help message for the ptype
> command, register the 'set print type hex' and 'show print type
> hex' commands.
> * c-typeprint.c (c_print_type, c_type_print_base_struct_union)
> (c_type_print_base): Construct the print_offset_data
> object using the type_print_optons parameter.
> * rust-lang.c (rust_language::print_type): Construct the
> print_offset_data object using the type_print_optons parameter.
> * NEWS: Mention the new flags of the ptype command.
>
> gdb/doc/ChangeLog:
>
> PR gdb/22640
> * gdb.texinfo (Symbols): Describe the 'x' and 'd' flags of the
> ptype command, describe 'set print type hex' and 'show print
> type hex' commands. Update 'ptype/o' examples.
>
> gdb/testsuite/ChangeLog:
>
> PR gdb/22640
> * gdb.base/ptype-offsets.exp: Add tests to verify the behavior
> of 'ptype/ox' and 'ptype/od'. Check that 'set print type hex'
> changes the default behavior of 'ptype/o'. Update to take into
> account new horizontal layout.
> * gdb.rust/simple.exp: Update ptype test to check new horizontal
> layout.
> * gdb.rust/union.exp: Same.
Thanks, the documentation parts are OK.
next prev parent reply other threads:[~2021-04-24 6:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 22:28 [PATCH v3 0/2] Have ptype support hex display of offsets and sizes Lancelot SIX
2021-04-23 22:28 ` [PATCH v3 1/2] typeprint.h: reorder struct declaration Lancelot SIX
2021-04-23 22:28 ` [PATCH v3 2/2] [PR gdb/22640] ptype: add option to use hexadecimal notation Lancelot SIX
2021-04-24 6:15 ` Eli Zaretskii [this message]
2021-04-24 15:32 ` [PATCH v3 0/2] Have ptype support hex display of offsets and sizes Tom Tromey
2021-04-25 17:12 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rb0nr7l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).