public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Zied Guermazi <zied.guermazi@trande.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 8/8] document btrace support for arm targets using coresight etm traces
Date: Thu, 11 Mar 2021 08:23:23 +0200	[thread overview]
Message-ID: <831rcmnr8k.fsf@gnu.org> (raw)
In-Reply-To: <20210311025039.57112-9-zied.guermazi@trande.de> (message from Zied Guermazi on Thu, 11 Mar 2021 03:50:39 +0100)

> From: Zied Guermazi <zied.guermazi@trande.de>
> Date: Thu, 11 Mar 2021 03:50:39 +0100
> Cc: Zied Guermazi <zied.guermazi@trande.de>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 7f5a745d0c0..0c31af6ed0b 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS

This part is OK.

> +Use the value @kbd{default} to reset it to default sink.

Please use @code{default} or @samp{default}, not @kbd.

> +(@pxref{Qbtrace:bts}).

Please don't use the colon character in the names of anchors and in
the corresponding cross-references: those could cause trouble to some
Info readers, and are best avoided.  Please choose some other
character, like '_'.

The documentation part of this patch series is approved as soon as
those 2 nits are fixed.

Thanks.

  reply	other threads:[~2021-03-11  6:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  2:50 [PATCH v2 0/8] extend branch tracing to use ARM CoreSight traces Zied Guermazi
2021-03-11  2:50 ` [PATCH v2 1/8] configure gdb build system for supporting btrace on arm processors Zied Guermazi
2021-03-11  2:50 ` [PATCH v2 2/8] add btrace coresight related commands Zied Guermazi
2021-03-11  2:50 ` [PATCH v2 3/8] start/stop btrace with coresight etm and parse etm buffer. nat independant Zied Guermazi
2021-03-11  2:50 ` [PATCH v2 4/8] start/stop btrace with coresight etm and collect etm buffer on linux os Zied Guermazi
2021-03-11  2:50 ` [PATCH v2 5/8] fix issue: gdb hangs in the command following a commad returning with TARGET_WAITKIND_NO_HISTORY Zied Guermazi
2021-03-11  2:50 ` [PATCH v2 6/8] add support for coresight btrace via remote protocol Zied Guermazi
2021-03-11  2:50 ` [PATCH v2 7/8] adapt btrace testcases for arm target Zied Guermazi
2021-03-11  2:50 ` [PATCH 8/8] document btrace support for arm targets using coresight etm traces Zied Guermazi
2021-03-11  6:23   ` Eli Zaretskii [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-26  2:45 [PATCH 0/8] extend branch tracing to use ARM CoreSight traces Zied Guermazi
2021-02-26  2:46 ` [PATCH 8/8] document btrace support for arm targets using coresight etm traces Zied Guermazi
2021-02-26  7:36   ` Eli Zaretskii
2021-03-10 20:36     ` Zied Guermazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rcmnr8k.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=zied.guermazi@trande.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).