From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id F08023870891
 for <gdb-patches@sourceware.org>; Thu, 11 Mar 2021 06:23:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F08023870891
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56143)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lKEjG-0006fF-IW; Thu, 11 Mar 2021 01:23:26 -0500
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2274
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lKEjF-0003d0-6y; Thu, 11 Mar 2021 01:23:25 -0500
Date: Thu, 11 Mar 2021 08:23:23 +0200
Message-Id: <831rcmnr8k.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Zied Guermazi <zied.guermazi@trande.de>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20210311025039.57112-9-zied.guermazi@trande.de> (message from
 Zied Guermazi on Thu, 11 Mar 2021 03:50:39 +0100)
Subject: Re: [PATCH 8/8] document btrace support for arm targets using
 coresight etm traces
References: <20210311025039.57112-1-zied.guermazi@trande.de>
 <20210311025039.57112-9-zied.guermazi@trande.de>
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Mar 2021 06:23:29 -0000

> From: Zied Guermazi <zied.guermazi@trande.de>
> Date: Thu, 11 Mar 2021 03:50:39 +0100
> Cc: Zied Guermazi <zied.guermazi@trande.de>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 7f5a745d0c0..0c31af6ed0b 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS

This part is OK.

> +Use the value @kbd{default} to reset it to default sink.

Please use @code{default} or @samp{default}, not @kbd.

> +(@pxref{Qbtrace:bts}).

Please don't use the colon character in the names of anchors and in
the corresponding cross-references: those could cause trouble to some
Info readers, and are best avoided.  Please choose some other
character, like '_'.

The documentation part of this patch series is approved as soon as
those 2 nits are fixed.

Thanks.